[PATCH] bzip2: set correct soname

[PATCH] bzip2: set correct soname

[Ross Burton]

The correct name for the bzip2 shared library is libbz2.so.1.0.6, not
libbz2.so.0.0.0.  Pass -version-info to libtool to correct this.

Also fix the configure.ac so that is doesn't mention libXrender and has the
right version.

Signed-off-by: Ross Burton <ross.burton@intel.com>
---
 meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am  | 1 +
 meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac | 5 +----
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am b/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am
index 1d163b6..05d389f 100644
--- a/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am
+++ b/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am
@@ -1,5 +1,6 @@
 
 lib_LTLIBRARIES = libbz2.la
+libbz2_la_LDFLAGS = -version-info 1:6:0
 
 libbz2_la_SOURCES = blocksort.c  \
                     huffman.c    \
diff --git a/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac b/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac
index 47ee576..e2bf1bf 100644
--- a/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac
+++ b/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac
@@ -1,12 +1,9 @@
 AC_PREREQ([2.57])
 
-AC_INIT(bzip2, 2.0.5, , libXrender)
+AC_INIT(bzip2, 1.0.6)
 AM_INIT_AUTOMAKE(foreign)
 AM_MAINTAINER_MODE
 
-#AM_CONFIG_HEADER(config.h)
-
-# Check for progs
 AC_PROG_CC
 AC_PROG_LIBTOOL
 
-- 
2.7.0

Re: [PATCH] bzip2: set correct soname

[Andre McCurdy]

On Tue, Apr 5, 2016 at 2:26 PM, Ross Burton <ross.burton@intel.com> wrote:
> The correct name for the bzip2 shared library is libbz2.so.1.0.6, not
> libbz2.so.0.0.0.  Pass -version-info to libtool to correct this.
>
> Also fix the configure.ac so that is doesn't mention libXrender and has the
> right version.
>
> Signed-off-by: Ross Burton <ross.burton@intel.com>
> ---
>  meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am  | 1 +
>  meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac | 5 +----
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am b/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am
> index 1d163b6..05d389f 100644
> --- a/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am
> +++ b/meta/recipes-extended/bzip2/bzip2-1.0.6/Makefile.am
> @@ -1,5 +1,6 @@
>
>  lib_LTLIBRARIES = libbz2.la
> +libbz2_la_LDFLAGS = -version-info 1:6:0

1:6:0 or 1:0:6 ?

>
>  libbz2_la_SOURCES = blocksort.c  \
>                      huffman.c    \
> diff --git a/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac b/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac
> index 47ee576..e2bf1bf 100644
> --- a/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac
> +++ b/meta/recipes-extended/bzip2/bzip2-1.0.6/configure.ac
> @@ -1,12 +1,9 @@
>  AC_PREREQ([2.57])
>
> -AC_INIT(bzip2, 2.0.5, , libXrender)
> +AC_INIT(bzip2, 1.0.6)
>  AM_INIT_AUTOMAKE(foreign)
>  AM_MAINTAINER_MODE
>
> -#AM_CONFIG_HEADER(config.h)
> -
> -# Check for progs
>  AC_PROG_CC
>  AC_PROG_LIBTOOL
>
> --
> 2.7.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] bzip2: set correct soname

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 274 bytes --]

On 5 April 2016 at 23:02, Andre McCurdy <armccurdy@gmail.com> wrote:

> > +libbz2_la_LDFLAGS = -version-info 1:6:0
>
> 1:6:0 or 1:0:6 ?


1:6:0 results in /usr/lib/libbz2.so.1.0.6, which is what upstream intended
in their broken Makefile that we don't use.

Ross

[-- Attachment #2: Type: text/html, Size: 715 bytes --]

Re: [PATCH] bzip2: set correct soname

[Robert Yang]

Hi Ross,

I got this error when build in an old build dir:

| pbzip2: error while loading shared libraries: libbz2.so.0: cannot open shared 
object file: No such file or directory
| WARNING: exit code 127 from a shell command.
| ERROR: Function failed: do_image_tar (log file is located at 
/buildarea/lyang1/test_fetch/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/temp/log.do_image_tar.33968)
ERROR: Task 19 
(/buildarea/lyang1/poky/meta/recipes-core/images/core-image-minimal.bb, 
do_image_tar) failed with exit code '1'

It is OK when clean pbzip2-native and rebuild. But I wonder how can this
happen since pbzip2-native DEPENDS on bzip2-native.

// Robert

On 04/06/2016 04:23 PM, Burton, Ross wrote:
>
> On 5 April 2016 at 23:02, Andre McCurdy <armccurdy@gmail.com
> <mailto:armccurdy@gmail.com>> wrote:
>
>     > +libbz2_la_LDFLAGS = -version-info 1:6:0
>
>     1:6:0 or 1:0:6 ?
>
>
> 1:6:0 results in /usr/lib/libbz2.so.1.0.6, which is what upstream intended in
> their broken Makefile that we don't use.
>
> Ross
>
>

Re: [PATCH] bzip2: set correct soname

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 858 bytes --]

On 7 April 2016 at 03:37, Robert Yang <liezhi.yang@windriver.com> wrote:

> I got this error when build in an old build dir:
>
> | pbzip2: error while loading shared libraries: libbz2.so.0: cannot open
> shared object file: No such file or directory
> | WARNING: exit code 127 from a shell command.
> | ERROR: Function failed: do_image_tar (log file is located at
> /buildarea/lyang1/test_fetch/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/temp/log.do_image_tar.33968)
> ERROR: Task 19 (/buildarea/lyang1/poky/meta/recipes-core/images/
> core-image-minimal.bb, do_image_tar) failed with exit code '1'
>
> It is OK when clean pbzip2-native and rebuild. But I wonder how can this
> happen since pbzip2-native DEPENDS on bzip2-native.
>

Can you find the cooker log for this run?  Did it rebuild pbzip2-native as
expected?

Ross

[-- Attachment #2: Type: text/html, Size: 1358 bytes --]

Re: [PATCH] bzip2: set correct soname

[Robert Yang]

On 04/07/2016 05:12 PM, Burton, Ross wrote:
>
> On 7 April 2016 at 03:37, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
>     I got this error when build in an old build dir:
>
>     | pbzip2: error while loading shared libraries: libbz2.so.0: cannot open
>     shared object file: No such file or directory
>     | WARNING: exit code 127 from a shell command.
>     | ERROR: Function failed: do_image_tar (log file is located at
>     /buildarea/lyang1/test_fetch/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/temp/log.do_image_tar.33968)
>     ERROR: Task 19
>     (/buildarea/lyang1/poky/meta/recipes-core/images/core-image-minimal.bb
>     <http://core-image-minimal.bb>, do_image_tar) failed with exit code '1'
>
>     It is OK when clean pbzip2-native and rebuild. But I wonder how can this
>     happen since pbzip2-native DEPENDS on bzip2-native.
>
>
> Can you find the cooker log for this run?  Did it rebuild pbzip2-native as expected?

Yes, it did:

NOTE: recipe pbzip2-native-1.1.13-r0: task do_populate_sysroot: Started
NOTE: recipe pbzip2-native-1.1.13-r0: task do_populate_sysroot: Succeeded

// Robert

>
> Ross

Re: [PATCH] bzip2: set correct soname

[Robert Yang]

On 04/07/2016 05:50 PM, Robert Yang wrote:
>
>
> On 04/07/2016 05:12 PM, Burton, Ross wrote:
>>
>> On 7 April 2016 at 03:37, Robert Yang <liezhi.yang@windriver.com
>> <mailto:liezhi.yang@windriver.com>> wrote:
>>
>>     I got this error when build in an old build dir:
>>
>>     | pbzip2: error while loading shared libraries: libbz2.so.0: cannot open
>>     shared object file: No such file or directory
>>     | WARNING: exit code 127 from a shell command.
>>     | ERROR: Function failed: do_image_tar (log file is located at
>>
>> /buildarea/lyang1/test_fetch/tmp/work/qemux86_64-poky-linux/core-image-minimal/1.0-r0/temp/log.do_image_tar.33968)
>>
>>     ERROR: Task 19
>>     (/buildarea/lyang1/poky/meta/recipes-core/images/core-image-minimal.bb
>>     <http://core-image-minimal.bb>, do_image_tar) failed with exit code '1'
>>
>>     It is OK when clean pbzip2-native and rebuild. But I wonder how can this
>>     happen since pbzip2-native DEPENDS on bzip2-native.
>>
>>
>> Can you find the cooker log for this run?  Did it rebuild pbzip2-native as
>> expected?
>
> Yes, it did:
>
> NOTE: recipe pbzip2-native-1.1.13-r0: task do_populate_sysroot: Started
> NOTE: recipe pbzip2-native-1.1.13-r0: task do_populate_sysroot: Succeeded
>

I think that I've figured out the reason, do_compile re-runs, but make does
nothing:

make: Nothing to be done for `all'

I will send a patch for it.

// Robert

> // Robert
>
>>
>> Ross