Re: [PATCH 2/4] image_types.bbclass: fix ubi ubifs and multiubi

[Stefano Babic <sbabic@denx.de>]

Hi Robert,

On 08/04/2016 09:15, Robert Yang wrote:
> Fixed when do_image_ubi:
> | DEBUG: Executing shell function do_image_ubifs
> | Error: min. I/O unit was not specified (use -h for help)
> | WARNING: exit code 255 from a shell command.
> 
> Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
> ---
>  meta/classes/image_types.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/classes/image_types.bbclass b/meta/classes/image_types.bbclass
> index 3f97ddd..caa4dbb 100644
> --- a/meta/classes/image_types.bbclass
> +++ b/meta/classes/image_types.bbclass
> @@ -120,6 +120,9 @@ IMAGE_CMD_elf () {
>  }
>  IMAGE_TYPEDEP_elf = "cpio.gz"
>  
> +MKUBIFS_ARGS ?= "-m 1KiB -e 128KiB -c $ROOTFS_SIZE"
> +UBINIZE_ARGS ?= "-m 1KiB -p 128KiB"
> +

These are machine specific and are generally set in the machine
configuration file. Default values you set here could be wrong in most
cases, depending on the NAND chip.

Is it not better to get the error ? Then I know that I forget to set the
two variables and I can easy fix it. If no error is raised, we get a
ubifs that never run on the machine and as rootfs is not mounted - and
finding the reason is much more difficult.

Best regards,
Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================