Re: [PATCH 2/4] image_types.bbclass: fix ubi ubifs and multiubi

[Robert Yang <liezhi.yang@windriver.com>]

On 04/08/2016 05:54 PM, Anders Darander wrote:
> * Stefano Babic <sbabic@denx.de> [160408 11:19]:
>> On 08/04/2016 09:15, Robert Yang wrote:
>>> Fixed when do_image_ubi:
>>> | DEBUG: Executing shell function do_image_ubifs
>>> | Error: min. I/O unit was not specified (use -h for help)
>>> | WARNING: exit code 255 from a shell command.
>
> NAK
>
>>> +MKUBIFS_ARGS ?= "-m 1KiB -e 128KiB -c $ROOTFS_SIZE"
>>> +UBINIZE_ARGS ?= "-m 1KiB -p 128KiB"
>>> +
>
>> These are machine specific and are generally set in the machine
>> configuration file. Default values you set here could be wrong in most
>> cases, depending on the NAND chip.
>
>> Is it not better to get the error ? Then I know that I forget to set the
>> two variables and I can easy fix it. If no error is raised, we get a
>> ubifs that never run on the machine and as rootfs is not mounted - and
>> finding the reason is much more difficult.
>
> I agree with Stefano here; I'd also prefer a build failure instead of a
> non-working image.

My concerns was that if they can't be built out by default, then we have no
idea about whether they work or not. But as you said ubifs is a little
special, so I removed the patch from the repo. In YP 2.2, maybe we can
make it work a with a qemu machine ?

// Robert

>
> Cheers,
> Anders
>