[PATCH 0/2] fix buildtools-tarball and meta.bbclass

[PATCH 0/2] fix buildtools-tarball and meta.bbclass

[Robert Yang]

The following changes since commit 37aac647d510557323083c77c3114476440a325d:

  fs-perms.txt: fix ROOT_HOME's permission (2016-04-15 06:58:49 +0100)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/meta
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/meta

Robert Yang (2):
  buildtools-tarball.bb: fix unexpected operator
  meta.bbclass: set INHIBIT_DEFAULT_DEPS

 meta/classes/meta.bbclass                    | 2 ++
 meta/recipes-core/meta/buildtools-tarball.bb | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

-- 
2.8.0

[PATCH 1/2] buildtools-tarball.bb: fix unexpected operator

[Robert Yang]

Fixed:
run.create_sdk_files.45747: 131: [: =: unexpected operator

The SDKMACHINE is not set by default.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/recipes-core/meta/buildtools-tarball.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb
index 7186ac4..d39bd9a 100644
--- a/meta/recipes-core/meta/buildtools-tarball.bb
+++ b/meta/recipes-core/meta/buildtools-tarball.bb
@@ -58,7 +58,7 @@ create_sdk_files_append () {
 
 	echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script
 
-	if [ ${SDKMACHINE} = "i686" ]; then
+	if [ "${SDKMACHINE}" = "i686" ]; then
 		echo 'export NO32LIBS="0"' >>$script
 		echo 'echo "$BB_ENV_EXTRAWHITE" | grep -q "NO32LIBS"' >>$script
 		echo '[ $? != 0 ] && export BB_ENV_EXTRAWHITE="NO32LIBS $BB_ENV_EXTRAWHITE"' >>$script
-- 
2.8.0

[PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS

[Robert Yang]

The recipe which inherits meta.bbclass doesn't require any default deps.

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
---
 meta/classes/meta.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/meta.bbclass b/meta/classes/meta.bbclass
index 5e68902..aefcdb6 100644
--- a/meta/classes/meta.bbclass
+++ b/meta/classes/meta.bbclass
@@ -2,3 +2,5 @@
 PACKAGES = ""
 
 do_build[recrdeptask] = "do_build"
+
+INHIBIT_DEFAULT_DEPS = "1"
-- 
2.8.0

Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 379 bytes --]

On 18 April 2016 at 03:57, Robert Yang <liezhi.yang@windriver.com> wrote:

> The recipe which inherits meta.bbclass doesn't require any default deps.
>

meta is only inherited by one class (populate_sdk_base.bbclass) and three
recipes (two of which indirectly inherit populate_sdk_base) so do we really
need this class?  Maybe we should drop it in the 2.2 cycle.

Ross

[-- Attachment #2: Type: text/html, Size: 850 bytes --]

Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS

[Robert Yang]

On 04/19/2016 04:27 AM, Burton, Ross wrote:
>
> On 18 April 2016 at 03:57, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
>     The recipe which inherits meta.bbclass doesn't require any default deps.
>
>
> meta is only inherited by one class (populate_sdk_base.bbclass) and three
> recipes (two of which indirectly inherit populate_sdk_base) so do we really need

The INHIBIT_DEFAULT_DEPS = "1" was for buildtools-tarball, I will move it into
buildtools-tarball since meta.bbclass may go. And I noticed that another patch
has been merged so I will send a new PULL for it.

// Robert

> this class?  Maybe we should drop it in the 2.2 cycle.
>
> Ross

Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS

[Paul Eggleton]

On Mon, 18 Apr 2016 21:27:25 Burton, Ross wrote:
> On 18 April 2016 at 03:57, Robert Yang <liezhi.yang@windriver.com> wrote:
> > The recipe which inherits meta.bbclass doesn't require any default deps.
> 
> meta is only inherited by one class (populate_sdk_base.bbclass) and three
> recipes (two of which indirectly inherit populate_sdk_base) so do we really
> need this class?  Maybe we should drop it in the 2.2 cycle.

I don't think we ought to be in too much of a hurry to remove this - it's 
still a handy class. Besides I was planning on using it to solve this issue:

  https://bugzilla.yoctoproject.org/show_bug.cgi?id=9257 

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 2/2] meta.bbclass: set INHIBIT_DEFAULT_DEPS

[Richard Purdie]

On Tue, 2016-04-19 at 15:33 +1200, Paul Eggleton wrote:
> On Mon, 18 Apr 2016 21:27:25 Burton, Ross wrote:
> > On 18 April 2016 at 03:57, Robert Yang <liezhi.yang@windriver.com>
> > wrote:
> > > The recipe which inherits meta.bbclass doesn't require any
> > > default deps.
> > 
> > meta is only inherited by one class (populate_sdk_base.bbclass) and
> > three
> > recipes (two of which indirectly inherit populate_sdk_base) so do
> > we really
> > need this class?  Maybe we should drop it in the 2.2 cycle.
> 
> I don't think we ought to be in too much of a hurry to remove this -
> it's 
> still a handy class. Besides I was planning on using it to solve this
> issue:
> 
>   https://bugzilla.yoctoproject.org/show_bug.cgi?id=9257 

I have the opposite view. Its pretty much impossible to tell what a
"meta" class would do from its name or have any idea of whether a given
change should be added to the class since its purpose is so vague.

I'l like to see it renamed to something more useful, or removed given
its just two lines...

Cheers,

Richard