[PATCH] classes/base: get_lic_checksum_file_list imporve validaton of url's

[PATCH] classes/base: get_lic_checksum_file_list imporve validaton of url's

[Aníbal Limón]

When specify an URL different that supported file:// the function
returns an empty path causing an exception without notice the user
that the URL is Malformed.

[YOCTO #9211]

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
---
 meta/classes/base.bbclass | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
index a7ca3a6..c3c2669 100644
--- a/meta/classes/base.bbclass
+++ b/meta/classes/base.bbclass
@@ -105,6 +105,9 @@ def get_lic_checksum_file_list(d):
         # any others should be covered by SRC_URI.
         try:
             path = bb.fetch.decodeurl(url)[2]
+            if not path:
+                raise bb.fetch.MalformedUrl(url)
+
             if path[0] == '/':
                 if path.startswith(tmpdir):
                     continue
-- 
2.1.4

Re: [PATCH] classes/base: get_lic_checksum_file_list imporve validaton of url's

[Aníbal Limón]

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

ping

On 05/11/2016 11:41 AM, Aníbal Limón wrote:
> When specify an URL different that supported file:// the function
> returns an empty path causing an exception without notice the user
> that the URL is Malformed.
> 
> [YOCTO #9211]
> 
> Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> ---
>  meta/classes/base.bbclass | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> index a7ca3a6..c3c2669 100644
> --- a/meta/classes/base.bbclass
> +++ b/meta/classes/base.bbclass
> @@ -105,6 +105,9 @@ def get_lic_checksum_file_list(d):
>          # any others should be covered by SRC_URI.
>          try:
>              path = bb.fetch.decodeurl(url)[2]
> +            if not path:
> +                raise bb.fetch.MalformedUrl(url)
> +
>              if path[0] == '/':
>                  if path.startswith(tmpdir):
>                      continue
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [PATCH] classes/base: get_lic_checksum_file_list imporve validaton of url's

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 1361 bytes --]

This is in master-next now, thanks Anibal!

Ross

On 16 May 2016 at 18:24, Aníbal Limón <anibal.limon@linux.intel.com> wrote:

> ping
>
> On 05/11/2016 11:41 AM, Aníbal Limón wrote:
> > When specify an URL different that supported file:// the function
> > returns an empty path causing an exception without notice the user
> > that the URL is Malformed.
> >
> > [YOCTO #9211]
> >
> > Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
> > ---
> >  meta/classes/base.bbclass | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass
> > index a7ca3a6..c3c2669 100644
> > --- a/meta/classes/base.bbclass
> > +++ b/meta/classes/base.bbclass
> > @@ -105,6 +105,9 @@ def get_lic_checksum_file_list(d):
> >          # any others should be covered by SRC_URI.
> >          try:
> >              path = bb.fetch.decodeurl(url)[2]
> > +            if not path:
> > +                raise bb.fetch.MalformedUrl(url)
> > +
> >              if path[0] == '/':
> >                  if path.startswith(tmpdir):
> >                      continue
> >
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 2177 bytes --]