[PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[Randle, William C]

Previous patch was not against master. Updated against master branch.

Fixes YOCTO 9201
Adds -Wno-error=trampolines to native CFLAGS prevent multiple compile
errors when using gcc 5.3.0 for gentoo.

Signed-off-by: Bill Randle <william.c.randle@intel.com>
---
 meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb b/meta/recipes-bsp/grub/grub-efi_2.00.bb
index 4e80e18..ca73234 100644
--- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
+++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
@@ -35,6 +35,10 @@ EXTRA_OECONF = "--with-platform=efi --disable-grub-mkfont \
 
 EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}"
 
+# ldm.c:114:7: error: trampoline generated for nested function 'hook' [-Werror=trampolines]
+# and many other places in the grub code when compiled with some native gcc 5.3 compilers
+CFLAGS_append_class-native = " -Wno-error=trampolines"
+
 do_install_class-native() {
    install -d ${D}${bindir}
    install -m 755 grub-mkimage ${D}${bindir}
--
2.5.0

Re: [PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[Lopez, Mariano]

On 3/17/2016 7:30 PM, Randle, William C wrote:
> Previous patch was not against master. Updated against master branch.
>
> Fixes YOCTO 9201
> Adds -Wno-error=trampolines to native CFLAGS prevent multiple compile
> errors when using gcc 5.3.0 for gentoo.
>
> Signed-off-by: Bill Randle <william.c.randle@intel.com>
> ---
>   meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb b/meta/recipes-bsp/grub/grub-efi_2.00.bb
> index 4e80e18..ca73234 100644
> --- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
> +++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
> @@ -35,6 +35,10 @@ EXTRA_OECONF = "--with-platform=efi --disable-grub-mkfont \
>   
>   EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}"
>   
> +# ldm.c:114:7: error: trampoline generated for nested function 'hook' [-Werror=trampolines]
> +# and many other places in the grub code when compiled with some native gcc 5.3 compilers
> +CFLAGS_append_class-native = " -Wno-error=trampolines"
> +
>   do_install_class-native() {
>      install -d ${D}${bindir}
>      install -m 755 grub-mkimage ${D}${bindir}
> --
> 2.5.0

I'm a gentoo user and I have the trampoline issue with gcc 4.9.3. I just 
tested this patch in gentoo and it works, I can remove my bbappend file 
from my personal layer!

Mariano

Re: [PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[ChenQi]

Hi,

Is the error still there for gcc6 without this option for CFLAGS?
The problem is that gcc on some old hosts don't support this option.

Best Regards,
Chen Qi

On 03/18/2016 09:30 AM, Randle, William C wrote:
> Previous patch was not against master. Updated against master branch.
>
> Fixes YOCTO 9201
> Adds -Wno-error=trampolines to native CFLAGS prevent multiple compile
> errors when using gcc 5.3.0 for gentoo.
>
> Signed-off-by: Bill Randle <william.c.randle@intel.com>
> ---
>   meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb b/meta/recipes-bsp/grub/grub-efi_2.00.bb
> index 4e80e18..ca73234 100644
> --- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
> +++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
> @@ -35,6 +35,10 @@ EXTRA_OECONF = "--with-platform=efi --disable-grub-mkfont \
>   
>   EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile', '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}"
>   
> +# ldm.c:114:7: error: trampoline generated for nested function 'hook' [-Werror=trampolines]
> +# and many other places in the grub code when compiled with some native gcc 5.3 compilers
> +CFLAGS_append_class-native = " -Wno-error=trampolines"
> +
>   do_install_class-native() {
>      install -d ${D}${bindir}
>      install -m 755 grub-mkimage ${D}${bindir}
> --
> 2.5.0

Re: [PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[Khem Raj]

On Thu, Jun 23, 2016 at 11:19 PM, ChenQi <Qi.Chen@windriver.com> wrote:
> Hi,
>
> Is the error still there for gcc6 without this option for CFLAGS?
> The problem is that gcc on some old hosts don't support this option.

how old is the host. We should start recommending minimum required GCC
version on build host.
Sometimes a newer gcc is available for older distros too as alternative package.

>
> Best Regards,
> Chen Qi
>
> On 03/18/2016 09:30 AM, Randle, William C wrote:
>>
>> Previous patch was not against master. Updated against master branch.
>>
>> Fixes YOCTO 9201
>> Adds -Wno-error=trampolines to native CFLAGS prevent multiple compile
>> errors when using gcc 5.3.0 for gentoo.
>>
>> Signed-off-by: Bill Randle <william.c.randle@intel.com>
>> ---
>>   meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 ++++
>>   1 file changed, 4 insertions(+)
>>
>> diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>> b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>> index 4e80e18..ca73234 100644
>> --- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>> +++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>> @@ -35,6 +35,10 @@ EXTRA_OECONF = "--with-platform=efi
>> --disable-grub-mkfont \
>>     EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile',
>> '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}"
>>   +# ldm.c:114:7: error: trampoline generated for nested function 'hook'
>> [-Werror=trampolines]
>> +# and many other places in the grub code when compiled with some native
>> gcc 5.3 compilers
>> +CFLAGS_append_class-native = " -Wno-error=trampolines"
>> +
>>   do_install_class-native() {
>>      install -d ${D}${bindir}
>>      install -m 755 grub-mkimage ${D}${bindir}
>> --
>> 2.5.0
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[ChenQi]

On 06/24/2016 10:04 PM, Khem Raj wrote:
> On Thu, Jun 23, 2016 at 11:19 PM, ChenQi <Qi.Chen@windriver.com> wrote:
>> Hi,
>>
>> Is the error still there for gcc6 without this option for CFLAGS?
>> The problem is that gcc on some old hosts don't support this option.
> how old is the host. We should start recommending minimum required GCC
> version on build host.
> Sometimes a newer gcc is available for older distros too as alternative package.

That is centos6.

Best Regards,
Chen Qi

>> Best Regards,
>> Chen Qi
>>
>> On 03/18/2016 09:30 AM, Randle, William C wrote:
>>> Previous patch was not against master. Updated against master branch.
>>>
>>> Fixes YOCTO 9201
>>> Adds -Wno-error=trampolines to native CFLAGS prevent multiple compile
>>> errors when using gcc 5.3.0 for gentoo.
>>>
>>> Signed-off-by: Bill Randle <william.c.randle@intel.com>
>>> ---
>>>    meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 ++++
>>>    1 file changed, 4 insertions(+)
>>>
>>> diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> index 4e80e18..ca73234 100644
>>> --- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> +++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>> @@ -35,6 +35,10 @@ EXTRA_OECONF = "--with-platform=efi
>>> --disable-grub-mkfont \
>>>      EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile',
>>> '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}"
>>>    +# ldm.c:114:7: error: trampoline generated for nested function 'hook'
>>> [-Werror=trampolines]
>>> +# and many other places in the grub code when compiled with some native
>>> gcc 5.3 compilers
>>> +CFLAGS_append_class-native = " -Wno-error=trampolines"
>>> +
>>>    do_install_class-native() {
>>>       install -d ${D}${bindir}
>>>       install -m 755 grub-mkimage ${D}${bindir}
>>> --
>>> 2.5.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH v2] grub: add -Wno-error=trampolines to native CFLAGS

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 2556 bytes --]


> On Jun 26, 2016, at 7:00 PM, ChenQi <Qi.Chen@windriver.com> wrote:
> 
> On 06/24/2016 10:04 PM, Khem Raj wrote:
>> On Thu, Jun 23, 2016 at 11:19 PM, ChenQi <Qi.Chen@windriver.com> wrote:
>>> Hi,
>>> 
>>> Is the error still there for gcc6 without this option for CFLAGS?
>>> The problem is that gcc on some old hosts don't support this option.
>> how old is the host. We should start recommending minimum required GCC
>> version on build host.
>> Sometimes a newer gcc is available for older distros too as alternative package.
> 
> That is centos6.

we can recommend additional feeds for centos6 then ?
something like

http://people.centos.org/tru/devtools-2

Which will make gcc 4.8 available for centos6 along with 4.4 which is the default

If one wants to use devtools-3 then they can get gcc-4.9 as well, however its only
available for x86_64

> 
> Best Regards,
> Chen Qi
> 
>>> Best Regards,
>>> Chen Qi
>>> 
>>> On 03/18/2016 09:30 AM, Randle, William C wrote:
>>>> Previous patch was not against master. Updated against master branch.
>>>> 
>>>> Fixes YOCTO 9201
>>>> Adds -Wno-error=trampolines to native CFLAGS prevent multiple compile
>>>> errors when using gcc 5.3.0 for gentoo.
>>>> 
>>>> Signed-off-by: Bill Randle <william.c.randle@intel.com>
>>>> ---
>>>>   meta/recipes-bsp/grub/grub-efi_2.00.bb | 4 ++++
>>>>   1 file changed, 4 insertions(+)
>>>> 
>>>> diff --git a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>>> b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>>> index 4e80e18..ca73234 100644
>>>> --- a/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>>> +++ b/meta/recipes-bsp/grub/grub-efi_2.00.bb
>>>> @@ -35,6 +35,10 @@ EXTRA_OECONF = "--with-platform=efi
>>>> --disable-grub-mkfont \
>>>>     EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'largefile',
>>>> '--enable-largefile ac_cv_sizeof_off_t=8', '--disable-largefile', d)}"
>>>>   +# ldm.c:114:7: error: trampoline generated for nested function 'hook'
>>>> [-Werror=trampolines]
>>>> +# and many other places in the grub code when compiled with some native
>>>> gcc 5.3 compilers
>>>> +CFLAGS_append_class-native = " -Wno-error=trampolines"
>>>> +
>>>>   do_install_class-native() {
>>>>      install -d ${D}${bindir}
>>>>      install -m 755 grub-mkimage ${D}${bindir}
>>>> --
>>>> 2.5.0
>>> 
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]