Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] libpfm4: fix compile error
@ 2016-06-29  8:08 kai.kang
  2016-06-29  9:26 ` Kang Kai
  0 siblings, 1 reply; 2+ messages in thread
From: kai.kang @ 2016-06-29  8:08 UTC (permalink / raw)
  To: openembedded-core

From: Kai Kang <kai.kang@windriver.com>

It fails to compile libpfm4 with misleading-indentation error:

| syst_count.c:346:3: error: this 'for' clause does not guard...  [-Werror=misleading-indentation]
|   for(c=cmin ; c < cmax; c++)
|      ^~~

Add clauses to fix it.

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 .../files/fix-misleading-indentation-error.patch   | 38 ++++++++++++++++++++++
 meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb        |  1 +
 2 files changed, 39 insertions(+)
 create mode 100644 meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch

diff --git a/meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch b/meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch
new file mode 100644
index 0000000..25d47ef
--- /dev/null
+++ b/meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch
@@ -0,0 +1,38 @@
+Upstream-Status: Pending
+
+Fix compile error:
+
+| syst_count.c:346:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation] 
+|    for(c=cmin ; c < cmax; c++) 
+|       ^~~ 
+
+Signed-off-by: Kai Kang <kai.kang@windriver.com>
+---
+diff --git a/perf_examples/syst_count.c b/perf_examples/syst_count.c
+index 0d53078..2dfb9b9 100644
+--- a/perf_examples/syst_count.c
++++ b/perf_examples/syst_count.c
+@@ -343,8 +343,9 @@ measure(void)
+ 
+ 		for (delay = 1 ; delay <= options.delay; delay++) {
+ 
+-		for(c=cmin ; c < cmax; c++)
+-			start_cpu(c);
++			for(c=cmin ; c < cmax; c++) {
++				start_cpu(c);
++			}
+ 
+ 			if (0) {
+ 				tv.tv_sec = 0;
+@@ -353,8 +354,9 @@ measure(void)
+ 			} else
+ 				sleep(1);
+ 
+-		for(c=cmin ; c < cmax; c++)
+-			stop_cpu(c);
++			for(c=cmin ; c < cmax; c++) {
++				stop_cpu(c);
++			}
+ 
+ 			for(c = cmin; c < cmax; c++) {
+ 				printf("# %'ds -----\n", delay);
diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb b/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb
index 0b024ad..4136eac 100644
--- a/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb
+++ b/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb
@@ -14,6 +14,7 @@ COMPATIBLE_HOST = "powerpc64"
 
 SRC_URI = "http://downloads.sourceforge.net/project/perfmon2/${BPN}/libpfm-${PV}.tar.gz \
            file://0001-Makefile-Add-LDFLAGS-variable-to-SLDFLAGS.patch \
+           file://fix-misleading-indentation-error.patch \
           "
 
 SRC_URI[md5sum] = "5077b9022440e4951d96f2d0e73bd487"
-- 
2.6.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] libpfm4: fix compile error
  2016-06-29  8:08 [PATCH] libpfm4: fix compile error kai.kang
@ 2016-06-29  9:26 ` Kang Kai
  0 siblings, 0 replies; 2+ messages in thread
From: Kang Kai @ 2016-06-29  9:26 UTC (permalink / raw)
  To: openembedded-core

On 2016年06月29日 16:08, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> It fails to compile libpfm4 with misleading-indentation error:
>
> | syst_count.c:346:3: error: this 'for' clause does not guard...  [-Werror=misleading-indentation]
> |   for(c=cmin ; c < cmax; c++)
> |      ^~~
>
> Add clauses to fix it.

Oops...
s/clauses/braces/

--Kai

>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   .../files/fix-misleading-indentation-error.patch   | 38 ++++++++++++++++++++++
>   meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb        |  1 +
>   2 files changed, 39 insertions(+)
>   create mode 100644 meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch
>
> diff --git a/meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch b/meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch
> new file mode 100644
> index 0000000..25d47ef
> --- /dev/null
> +++ b/meta/recipes-kernel/libpfm/files/fix-misleading-indentation-error.patch
> @@ -0,0 +1,38 @@
> +Upstream-Status: Pending
> +
> +Fix compile error:
> +
> +| syst_count.c:346:3: error: this 'for' clause does not guard... [-Werror=misleading-indentation]
> +|    for(c=cmin ; c < cmax; c++)
> +|       ^~~
> +
> +Signed-off-by: Kai Kang <kai.kang@windriver.com>
> +---
> +diff --git a/perf_examples/syst_count.c b/perf_examples/syst_count.c
> +index 0d53078..2dfb9b9 100644
> +--- a/perf_examples/syst_count.c
> ++++ b/perf_examples/syst_count.c
> +@@ -343,8 +343,9 @@ measure(void)
> +
> + 		for (delay = 1 ; delay <= options.delay; delay++) {
> +
> +-		for(c=cmin ; c < cmax; c++)
> +-			start_cpu(c);
> ++			for(c=cmin ; c < cmax; c++) {
> ++				start_cpu(c);
> ++			}
> +
> + 			if (0) {
> + 				tv.tv_sec = 0;
> +@@ -353,8 +354,9 @@ measure(void)
> + 			} else
> + 				sleep(1);
> +
> +-		for(c=cmin ; c < cmax; c++)
> +-			stop_cpu(c);
> ++			for(c=cmin ; c < cmax; c++) {
> ++				stop_cpu(c);
> ++			}
> +
> + 			for(c = cmin; c < cmax; c++) {
> + 				printf("# %'ds -----\n", delay);
> diff --git a/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb b/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb
> index 0b024ad..4136eac 100644
> --- a/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb
> +++ b/meta/recipes-kernel/libpfm/libpfm4_4.6.0.bb
> @@ -14,6 +14,7 @@ COMPATIBLE_HOST = "powerpc64"
>   
>   SRC_URI = "http://downloads.sourceforge.net/project/perfmon2/${BPN}/libpfm-${PV}.tar.gz \
>              file://0001-Makefile-Add-LDFLAGS-variable-to-SLDFLAGS.patch \
> +           file://fix-misleading-indentation-error.patch \
>             "
>   
>   SRC_URI[md5sum] = "5077b9022440e4951d96f2d0e73bd487"


-- 
Regards,
Neil | Kai Kang



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-06-29  9:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-29  8:08 [PATCH] libpfm4: fix compile error kai.kang
2016-06-29  9:26 ` Kang Kai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox