From: Mariano Lopez <mariano.lopez@linux.intel.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] selftest/runtime-test.py: Add test for import test from other layers
Date: Tue, 26 Jul 2016 15:24:14 -0500 [thread overview]
Message-ID: <5797C6EE.2080600@linux.intel.com> (raw)
In-Reply-To: <CAJTo0LZG6Zqonn8miXcDzG=CxqcWgo67du49FX4ZMjw48nU1pw@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1069 bytes --]
On 07/25/2016 05:38 PM, Burton, Ross wrote:
>
> On 13 June 2016 at 14:32, <mariano.lopez@linux.intel.com
> <mailto:mariano.lopez@linux.intel.com>> wrote:
>
> + features = 'INHERIT += "testexport"\n'
>
>
> You mean testimage here as that class isn't inherited by default.
>
> + features = 'TEST_SUITES = "ping ssh selftest"\n'
>
>
> This overwrites the first assignment to features, and neither is
> actually written using self.write_config().
>
> + # Build core-image-sato and testimage
> + bitbake('core-image-sato socat')
> + bitbake('-c testimage core-image-sato')
>
>
> I personally believe that core-image-sato is massive overkill for
> selftest and core-image-full-cmdline is just as comprehensive (has
> ssh, for example) without building all of Sato.
I don't know what happened when I made this commit and submitted the
patch, this patch is just wrong. I swear I tested it locally, perhaps I
messed up the branches or something like that. I'll work on a v2 of this.
Mariano
[-- Attachment #2: Type: text/html, Size: 2855 bytes --]
prev parent reply other threads:[~2016-07-26 20:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1465824701.git.mariano.lopez@linux.intel.com>
2016-06-13 13:32 ` [PATCH 1/1] selftest/runtime-test.py: Add test for import test from other layers mariano.lopez
2016-06-14 9:26 ` Burton, Ross
2016-06-14 22:08 ` Mariano Lopez
2016-06-15 20:47 ` Khem Raj
2016-06-15 21:01 ` Mariano Lopez
2016-06-15 21:05 ` Khem Raj
2016-06-15 21:16 ` Mariano Lopez
2016-07-25 22:38 ` Burton, Ross
2016-07-26 20:24 ` Mariano Lopez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5797C6EE.2080600@linux.intel.com \
--to=mariano.lopez@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox