[PATCH V1] e2fsprogs: fix ptest bug for second running

[PATCH V1] e2fsprogs: fix ptest bug for second running

[qiutt]

[-- Attachment #1: Type: text/plain, Size: 1591 bytes --]

From db4b5e31703e4143450b1e7239b2502a89ed042a Mon Sep 17 00:00:00 2001
From: Qiu Tingting <qiutt@fujitsu.com>
Date: Thu, 27 Apr 2023 15:29:14 +0800
Subject: [PATCH V1] e2fsprogs: fix ptest bug for second running

At second running, there are four new failed case:
d_loaddump f_bigalloc_badinode f_bigalloc_orphan_list f_dup_resize

The test_data.tmp is necessary, but it is deleted by run-ptest.
So it should be restored after testing.

Signed-off-by: Qiu Tingting <qiutt@fujitsu.com>
---
meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 1 +
meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb | 3 +++
2 files changed, 4 insertions(+)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
index c97c0377e9..279923db8e 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
@@ -8,3 +8,4 @@ rm -f *.tmp
rm -f *.ok
rm -f *.failed
rm -f *.log
+cp ../data/test_data.tmp ./
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
index a2eb4f8f8f..87e13d744b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
@@ -143,4 +143,7 @@ do_install_ptest() {

install -d ${D}${PTEST_PATH}/lib
install -m 0644 ${B}/lib/config.h  ${D}${PTEST_PATH}/lib/
+
+        install -d ${D}${PTEST_PATH}/data
+        install -m 0644 ${B}/tests/test_data.tmp ${D}${PTEST_PATH}/data/
}
--
2.25.1

[-- Attachment #2: Type: text/html, Size: 2245 bytes --]

Re: [OE-core] [PATCH V1] e2fsprogs: fix ptest bug for second running

[Khem Raj]

This seems to be problematic. See

Log data follows:


[265/1914]
| DEBUG: Executing shell function do_install_ptest_base
| /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/e2fsprogs/1.47.0-r0/temp/run.do_install_ptest_base.2332727:
line 192:  : command not found
| WARNING: /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/e2fsprogs/1.47.0-r0/temp/run.do_install_ptest_base.2332727:192
exit 127 from '  install -Dm 0644
/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-lin
ux-musl/e2fsprogs/1.47.0-r0/build/tests/test_data.tmp
/mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/e2fsprogs/1.47.0-r0/image/usr/lib/e2fsprogs/ptest/data/test_data.tmp'

On Thu, Apr 27, 2023 at 1:26 AM qiutt@fujitsu.com <qiutt@fujitsu.com> wrote:
>
> From db4b5e31703e4143450b1e7239b2502a89ed042a Mon Sep 17 00:00:00 2001
> From: Qiu Tingting <qiutt@fujitsu.com>
> Date: Thu, 27 Apr 2023 15:29:14 +0800
> Subject: [PATCH V1] e2fsprogs: fix ptest bug for second running
>
> At second running, there are four new failed case:
>   d_loaddump f_bigalloc_badinode f_bigalloc_orphan_list f_dup_resize
>
> The test_data.tmp is necessary, but it is deleted by run-ptest.
> So it should be restored after testing.
>
> Signed-off-by: Qiu Tingting <qiutt@fujitsu.com>
> ---
>  meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 1 +
>  meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb | 3 +++
>  2 files changed, 4 insertions(+)
>
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
> index c97c0377e9..279923db8e 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
> @@ -8,3 +8,4 @@ rm -f *.tmp
>  rm -f *.ok
>  rm -f *.failed
>  rm -f *.log
> +cp ../data/test_data.tmp ./
> diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
> index a2eb4f8f8f..87e13d744b 100644
> --- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
> +++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
> @@ -143,4 +143,7 @@ do_install_ptest() {
>
>          install -d ${D}${PTEST_PATH}/lib
>          install -m 0644 ${B}/lib/config.h  ${D}${PTEST_PATH}/lib/
> +
> +        install -d ${D}${PTEST_PATH}/data
> +        install -m 0644 ${B}/tests/test_data.tmp ${D}${PTEST_PATH}/data/
>  }
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#180487): https://lists.openembedded.org/g/openembedded-core/message/180487
> Mute This Topic: https://lists.openembedded.org/mt/98532860/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [PATCH V1] e2fsprogs: fix ptest bug for second running

[qiutt]

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

Hi， Khem Raj

> 
> | WARNING:
> /mnt/b/yoe/master/build/tmp/work/core2-64-yoe-linux-musl/e2fsprogs/1.47.0-r0/temp/run.do_install_ptest_base.2332727:192
> 
> exit 127 from ' install -Dm 0644
> 

There is no warning in my env, so could you share the file " run.do_install_ptest_base.2332727" ?
And the parameter "D" looks a bit strange.
command in warning: install -Dm 644
command in patch: install -m 0644

Thanks,
Qiu Tingting

[-- Attachment #2: Type: text/html, Size: 1106 bytes --]

Re: [PATCH V1] e2fsprogs: fix ptest bug for second running

[qiutt]

[-- Attachment #1.1: Type: text/plain, Size: 124 bytes --]

Hi， Khem Raj

It may be mangled by my mailer.

Could you use the attachments and try again?

Thanks,
Qiu Tingting

[-- Attachment #1.2: Type: text/html, Size: 6232 bytes --]

[-- Attachment #2: 0001-e2fsprogs-fix-ptest-bug-for-second-running.patch --]
[-- Type: application/octet-stream, Size: 1572 bytes --]

From db4b5e31703e4143450b1e7239b2502a89ed042a Mon Sep 17 00:00:00 2001
From: Qiu Tingting <qiutt@fujitsu.com>
Date: Thu, 27 Apr 2023 15:29:14 +0800
Subject: [PATCH V1] e2fsprogs: fix ptest bug for second running

At second running, there are four new failed case:
  d_loaddump f_bigalloc_badinode f_bigalloc_orphan_list f_dup_resize

The test_data.tmp is necessary, but it is deleted by run-ptest.
So it should be restored after testing.

Signed-off-by: Qiu Tingting <qiutt@fujitsu.com>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 1 +
 meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
index c97c0377e9..279923db8e 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
@@ -8,3 +8,4 @@ rm -f *.tmp
 rm -f *.ok
 rm -f *.failed
 rm -f *.log
+cp ../data/test_data.tmp ./
diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
index a2eb4f8f8f..87e13d744b 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs_1.47.0.bb
@@ -143,4 +143,7 @@ do_install_ptest() {
 
         install -d ${D}${PTEST_PATH}/lib
         install -m 0644 ${B}/lib/config.h  ${D}${PTEST_PATH}/lib/
+
+        install -d ${D}${PTEST_PATH}/data
+        install -m 0644 ${B}/tests/test_data.tmp ${D}${PTEST_PATH}/data/
 }
-- 
2.25.1