[PATCH] perl: correct the path of perl used by ptest

[PATCH] perl: correct the path of perl used by ptest

[Zhenbo Gao]

some files from perl-ptest depends on perl, which is located at /usr/bin/

Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
---
 meta/recipes-devtools/perl/perl-ptest.inc | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/meta/recipes-devtools/perl/perl-ptest.inc b/meta/recipes-devtools/perl/perl-ptest.inc
index d136c5c..94e40e6 100644
--- a/meta/recipes-devtools/perl/perl-ptest.inc
+++ b/meta/recipes-devtools/perl/perl-ptest.inc
@@ -24,6 +24,12 @@ do_install_ptest () {
 
 	ln -sf ${bindir}/perl ${D}${PTEST_PATH}/t/perl
 
+	# perl is located at /usr/bin/
+	p='^#![/.]*perl'
+	files=`grep -E ${p} ${D} -nr | grep -v -E 'Binary|win32' | cut -d ':' -f 1`
+	for f in ${files}; do
+		sed -i -e "s:${p}:#! ${USRBINPATH}/perl:g" ${f}
+	done
 }
 
 python populate_packages_prepend() {
-- 
1.9.1

Re: [PATCH] perl: correct the path of perl used by ptest

[Bill Randle]

[-- Attachment #1: Type: text/plain, Size: 1528 bytes --]

Under what conditions is the explicit path to /usr/bin/perl required? Just
before your added code, it creates a symlink from the installed perl
location to the "t" directory where the tests are run. What if the perl
that was built was an alternate version and installed in /usr/local/bin?

    -Bill

On Tue, Aug 30, 2016 at 10:37 PM, Zhenbo Gao <zhenbo.gao@windriver.com>
wrote:

> some files from perl-ptest depends on perl, which is located at /usr/bin/
>
> Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
> ---
>  meta/recipes-devtools/perl/perl-ptest.inc | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/meta/recipes-devtools/perl/perl-ptest.inc
> b/meta/recipes-devtools/perl/perl-ptest.inc
> index d136c5c..94e40e6 100644
> --- a/meta/recipes-devtools/perl/perl-ptest.inc
> +++ b/meta/recipes-devtools/perl/perl-ptest.inc
> @@ -24,6 +24,12 @@ do_install_ptest () {
>
>         ln -sf ${bindir}/perl ${D}${PTEST_PATH}/t/perl
>
> +       # perl is located at /usr/bin/
> +       p='^#![/.]*perl'
> +       files=`grep -E ${p} ${D} -nr | grep -v -E 'Binary|win32' | cut -d
> ':' -f 1`
> +       for f in ${files}; do
> +               sed -i -e "s:${p}:#! ${USRBINPATH}/perl:g" ${f}
> +       done
>  }
>
>  python populate_packages_prepend() {
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

[-- Attachment #2: Type: text/html, Size: 2312 bytes --]

Re: [PATCH] perl: correct the path of perl used by ptest

[zhenbo]

[-- Attachment #1: Type: text/plain, Size: 2409 bytes --]

Hi Bill,

Sorry that i just notice this email, sorry for the late reply.

I made this patch based on the following two points:
1. Please see commit 467eb93f and 84a39786, there has the following code 
in files automake_1.15.bb and autoconf.inc:
     CACHED_CONFIGUREVARS += "ac_cv_path_PERL=${USRBINPATH}/perl"
2. The familiar modifications for other files are accepted by oe-core, 
like gobject-introspection groff texi2html quilt and so on...

Thanks,
Zhenbo


On 2016年08月31日 22:42, Bill Randle wrote:
> Under what conditions is the explicit path to /usr/bin/perl required? 
> Just before your added code, it creates a symlink from the installed 
> perl location to the "t" directory where the tests are run. What if 
> the perl that was built was an alternate version and installed in 
> /usr/local/bin?
>
>     -Bill
>
> On Tue, Aug 30, 2016 at 10:37 PM, Zhenbo Gao <zhenbo.gao@windriver.com 
> <mailto:zhenbo.gao@windriver.com>> wrote:
>
>     some files from perl-ptest depends on perl, which is located at
>     /usr/bin/
>
>     Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com
>     <mailto:zhenbo.gao@windriver.com>>
>     ---
>      meta/recipes-devtools/perl/perl-ptest.inc | 6 ++++++
>      1 file changed, 6 insertions(+)
>
>     diff --git a/meta/recipes-devtools/perl/perl-ptest.inc
>     b/meta/recipes-devtools/perl/perl-ptest.inc
>     index d136c5c..94e40e6 100644
>     --- a/meta/recipes-devtools/perl/perl-ptest.inc
>     +++ b/meta/recipes-devtools/perl/perl-ptest.inc
>     @@ -24,6 +24,12 @@ do_install_ptest () {
>
>             ln -sf ${bindir}/perl ${D}${PTEST_PATH}/t/perl
>
>     +       # perl is located at /usr/bin/
>     +       p='^#![/.]*perl'
>     +       files=`grep -E ${p} ${D} -nr | grep -v -E 'Binary|win32' |
>     cut -d ':' -f 1`
>     +       for f in ${files}; do
>     +               sed -i -e "s:${p}:#! ${USRBINPATH}/perl:g" ${f}
>     +       done
>      }
>
>      python populate_packages_prepend() {
>     --
>     1.9.1
>
>     --
>     _______________________________________________
>     Openembedded-core mailing list
>     Openembedded-core@lists.openembedded.org
>     <mailto:Openembedded-core@lists.openembedded.org>
>     http://lists.openembedded.org/mailman/listinfo/openembedded-core
>     <http://lists.openembedded.org/mailman/listinfo/openembedded-core>
>
>


[-- Attachment #2: Type: text/html, Size: 4182 bytes --]