Openembedded Core Discussions
 help / color / mirror / Atom feed
From: zhenbo <zhenbo.gao@windriver.com>
To: Leonardo Sandoval <leonardo.sandoval.gonzalez@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] lsb: add checking for chkconfig existence when creating the symbolic
Date: Tue, 18 Jul 2017 09:48:24 +0800	[thread overview]
Message-ID: <596D68E8.60003@windriver.com> (raw)
In-Reply-To: <1500299820.5349.102.camel@linux.intel.com>



On 2017年07月17日 21:57, Leonardo Sandoval wrote:
> On Mon, 2017-07-17 at 17:13 +0800, Zhenbo Gao wrote:
>> remove_initd and remove_initd will be created as the symbolic file
> I believe you mean 'install_initd and remove_initd'...
Hi Leonardo,

Thanks for pointing this mistake, sorry about that.
I will send a V2 patch later to correct this.

Thanks,
Zhenbo

>> of chkconfig, which will be not existed when systemd is configured,
>> so adding the check for the existence of chkconfig before creating
>> the symbolic.
>>
>> Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
>> ---
>>   meta/recipes-extended/lsb/lsb_4.1.bb | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
>> index cedf39e..c8db1a8 100644
>> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
>> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
>> @@ -90,11 +90,13 @@ do_install_append() {
>>          install -m 0755 ${WORKDIR}/init-functions ${D}${nonarch_base_libdir}/lsb
>>   
>>          # create links for LSB test
>> -       if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
>> -               install -d ${D}${nonarch_libdir}/lsb
>> +       if [ -e ${sbindir}/chkconfig ]; then
>> +               if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
>> +                       install -d ${D}${nonarch_libdir}/lsb
>> +               fi
>> +               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
>> +               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
>>          fi
>> -       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
>> -       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
>>   
>>          if [ "${TARGET_ARCH}" = "x86_64" ]; then
>>                  if [ "${base_libdir}" != "${base_prefix}/lib64" ]; then
>> -- 
>> 1.9.1
>>
>



      reply	other threads:[~2017-07-18  1:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-17  9:13 [PATCH] lsb: add checking for chkconfig existence when creating the symbolic Zhenbo Gao
2017-07-17 13:57 ` Leonardo Sandoval
2017-07-18  1:48   ` zhenbo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=596D68E8.60003@windriver.com \
    --to=zhenbo.gao@windriver.com \
    --cc=leonardo.sandoval.gonzalez@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox