[PATCH] lsb: add checking for chkconfig existence when creating the symbolic

[PATCH] lsb: add checking for chkconfig existence when creating the symbolic

[Zhenbo Gao]

remove_initd and remove_initd will be created as the symbolic file
of chkconfig, which will be not existed when systemd is configured,
so adding the check for the existence of chkconfig before creating
the symbolic.

Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
---
 meta/recipes-extended/lsb/lsb_4.1.bb | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
index cedf39e..c8db1a8 100644
--- a/meta/recipes-extended/lsb/lsb_4.1.bb
+++ b/meta/recipes-extended/lsb/lsb_4.1.bb
@@ -90,11 +90,13 @@ do_install_append() {
        install -m 0755 ${WORKDIR}/init-functions ${D}${nonarch_base_libdir}/lsb
 
        # create links for LSB test
-       if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
-               install -d ${D}${nonarch_libdir}/lsb
+       if [ -e ${sbindir}/chkconfig ]; then
+               if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
+                       install -d ${D}${nonarch_libdir}/lsb
+               fi
+               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
+               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
        fi
-       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
-       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
 
        if [ "${TARGET_ARCH}" = "x86_64" ]; then
                if [ "${base_libdir}" != "${base_prefix}/lib64" ]; then
-- 
1.9.1

Re: [PATCH] lsb: add checking for chkconfig existence when creating the symbolic

[Leonardo Sandoval]

On Mon, 2017-07-17 at 17:13 +0800, Zhenbo Gao wrote:
> remove_initd and remove_initd will be created as the symbolic file

I believe you mean 'install_initd and remove_initd'...

> of chkconfig, which will be not existed when systemd is configured,
> so adding the check for the existence of chkconfig before creating
> the symbolic.
> 
> Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
> ---
>  meta/recipes-extended/lsb/lsb_4.1.bb | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
> index cedf39e..c8db1a8 100644
> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
> @@ -90,11 +90,13 @@ do_install_append() {
>         install -m 0755 ${WORKDIR}/init-functions ${D}${nonarch_base_libdir}/lsb
>  
>         # create links for LSB test
> -       if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
> -               install -d ${D}${nonarch_libdir}/lsb
> +       if [ -e ${sbindir}/chkconfig ]; then
> +               if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
> +                       install -d ${D}${nonarch_libdir}/lsb
> +               fi
> +               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
> +               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
>         fi
> -       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
> -       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
>  
>         if [ "${TARGET_ARCH}" = "x86_64" ]; then
>                 if [ "${base_libdir}" != "${base_prefix}/lib64" ]; then
> -- 
> 1.9.1
> 

Re: [PATCH] lsb: add checking for chkconfig existence when creating the symbolic

[zhenbo]

On 2017年07月17日 21:57, Leonardo Sandoval wrote:
> On Mon, 2017-07-17 at 17:13 +0800, Zhenbo Gao wrote:
>> remove_initd and remove_initd will be created as the symbolic file
> I believe you mean 'install_initd and remove_initd'...
Hi Leonardo,

Thanks for pointing this mistake, sorry about that.
I will send a V2 patch later to correct this.

Thanks,
Zhenbo

>> of chkconfig, which will be not existed when systemd is configured,
>> so adding the check for the existence of chkconfig before creating
>> the symbolic.
>>
>> Signed-off-by: Zhenbo Gao <zhenbo.gao@windriver.com>
>> ---
>>   meta/recipes-extended/lsb/lsb_4.1.bb | 10 ++++++----
>>   1 file changed, 6 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/recipes-extended/lsb/lsb_4.1.bb b/meta/recipes-extended/lsb/lsb_4.1.bb
>> index cedf39e..c8db1a8 100644
>> --- a/meta/recipes-extended/lsb/lsb_4.1.bb
>> +++ b/meta/recipes-extended/lsb/lsb_4.1.bb
>> @@ -90,11 +90,13 @@ do_install_append() {
>>          install -m 0755 ${WORKDIR}/init-functions ${D}${nonarch_base_libdir}/lsb
>>   
>>          # create links for LSB test
>> -       if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
>> -               install -d ${D}${nonarch_libdir}/lsb
>> +       if [ -e ${sbindir}/chkconfig ]; then
>> +               if [ "${nonarch_base_libdir}" != "${nonarch_libdir}" ] ; then
>> +                       install -d ${D}${nonarch_libdir}/lsb
>> +               fi
>> +               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
>> +               ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
>>          fi
>> -       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/install_initd
>> -       ln -sf ${sbindir}/chkconfig ${D}${nonarch_libdir}/lsb/remove_initd
>>   
>>          if [ "${TARGET_ARCH}" = "x86_64" ]; then
>>                  if [ "${base_libdir}" != "${base_prefix}/lib64" ]; then
>> -- 
>> 1.9.1
>>
>