Re: [OE-core] [PATCH] lttng-tools: not rrecommend on lttng-modules

[Kai <kai.kang@windriver.com>]

On 3/2/26 14:40, Kai Kang via lists.openembedded.org wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> As in the lttng manual [1]:
>
>    Most distributions mark the LTTng-modules and LTTng-UST packages as
>    optional when installing LTTng-tools (which is always required). In
>    the following sections, we always provide the steps to install all
>    three, but note that:
>
>    * You only need to install LTTng-modules if you intend to use the
>      Linux kernel LTTng tracer.
>    * You only need to install LTTng-UST if you intend to use the user
>      space LTTng tracer.
>
> there should be no force dependency between lttng-tools and
> lttng-modules. When set lttng-modules in RRECOMMENDS, it always forces
> to build lttng-modules whether it is required or not.
>
> Compare to rpm spec [2] and debian conf [3], there are no any dependency
> between them too.
>
> So remove the RRECOMMENDS setting.

Hi,

The commit had been staged in master-next for a while. But why removed 
eventually? Is there a plan to add it back?

Thanks,
Kai

>
> [1]: https://lttng.org/docs/v2.14/#doc-installing-lttng
> [2]: https://rpmfind.net/linux/RPM/fedora/updates/testing/43/aarch64/Packages/l/lttng-tools-2.14.0-4.fc43.aarch64.html
> [3]: https://packages.debian.org/trixie/lttng-tools
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb b/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
> index 620ddfb1cf..3a3f2cff2c 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
> @@ -14,7 +14,6 @@ include lttng-platforms.inc
>   
>   DEPENDS = "liburcu popt libxml2 util-linux bison-native babeltrace2"
>   RDEPENDS:${PN} = "libgcc"
> -RRECOMMENDS:${PN} += "${LTTNGMODULES}"
>   RDEPENDS:${PN}-ptest += "make perl bash gawk procps perl-module-overloading coreutils util-linux kmod ${LTTNGMODULES} sed python3-core grep binutils python3-multiprocessing"
>   RDEPENDS:${PN}-ptest:append:libc-glibc = " glibc-utils"
>   RDEPENDS:${PN}-ptest:append:libc-musl = " musl-utils"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#232171): https://lists.openembedded.org/g/openembedded-core/message/232171
> Mute This Topic: https://lists.openembedded.org/mt/118089750/3616933
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kai.kang@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

-- 
Kai Kang
Wind River Linux