public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH] lttng-tools: not rrecommend on lttng-modules
@ 2026-03-02  6:40 kai.kang
  2026-03-18  2:08 ` [OE-core] " Kai
  2026-03-18  7:37 ` Richard Purdie
  0 siblings, 2 replies; 4+ messages in thread
From: kai.kang @ 2026-03-02  6:40 UTC (permalink / raw)
  To: richard.purdie; +Cc: openembedded-core

From: Kai Kang <kai.kang@windriver.com>

As in the lttng manual [1]:

  Most distributions mark the LTTng-modules and LTTng-UST packages as
  optional when installing LTTng-tools (which is always required). In
  the following sections, we always provide the steps to install all
  three, but note that:

  * You only need to install LTTng-modules if you intend to use the
    Linux kernel LTTng tracer.
  * You only need to install LTTng-UST if you intend to use the user
    space LTTng tracer.

there should be no force dependency between lttng-tools and
lttng-modules. When set lttng-modules in RRECOMMENDS, it always forces
to build lttng-modules whether it is required or not.

Compare to rpm spec [2] and debian conf [3], there are no any dependency
between them too.

So remove the RRECOMMENDS setting.

[1]: https://lttng.org/docs/v2.14/#doc-installing-lttng
[2]: https://rpmfind.net/linux/RPM/fedora/updates/testing/43/aarch64/Packages/l/lttng-tools-2.14.0-4.fc43.aarch64.html
[3]: https://packages.debian.org/trixie/lttng-tools

Signed-off-by: Kai Kang <kai.kang@windriver.com>
---
 meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb b/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
index 620ddfb1cf..3a3f2cff2c 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
@@ -14,7 +14,6 @@ include lttng-platforms.inc
 
 DEPENDS = "liburcu popt libxml2 util-linux bison-native babeltrace2"
 RDEPENDS:${PN} = "libgcc"
-RRECOMMENDS:${PN} += "${LTTNGMODULES}"
 RDEPENDS:${PN}-ptest += "make perl bash gawk procps perl-module-overloading coreutils util-linux kmod ${LTTNGMODULES} sed python3-core grep binutils python3-multiprocessing"
 RDEPENDS:${PN}-ptest:append:libc-glibc = " glibc-utils"
 RDEPENDS:${PN}-ptest:append:libc-musl = " musl-utils"
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [OE-core] [PATCH] lttng-tools: not rrecommend on lttng-modules
  2026-03-02  6:40 [PATCH] lttng-tools: not rrecommend on lttng-modules kai.kang
@ 2026-03-18  2:08 ` Kai
  2026-03-18  7:37 ` Richard Purdie
  1 sibling, 0 replies; 4+ messages in thread
From: Kai @ 2026-03-18  2:08 UTC (permalink / raw)
  To: richard.purdie; +Cc: openembedded-core

On 3/2/26 14:40, Kai Kang via lists.openembedded.org wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> As in the lttng manual [1]:
>
>    Most distributions mark the LTTng-modules and LTTng-UST packages as
>    optional when installing LTTng-tools (which is always required). In
>    the following sections, we always provide the steps to install all
>    three, but note that:
>
>    * You only need to install LTTng-modules if you intend to use the
>      Linux kernel LTTng tracer.
>    * You only need to install LTTng-UST if you intend to use the user
>      space LTTng tracer.
>
> there should be no force dependency between lttng-tools and
> lttng-modules. When set lttng-modules in RRECOMMENDS, it always forces
> to build lttng-modules whether it is required or not.
>
> Compare to rpm spec [2] and debian conf [3], there are no any dependency
> between them too.
>
> So remove the RRECOMMENDS setting.

Hi,

The commit had been staged in master-next for a while. But why removed 
eventually? Is there a plan to add it back?

Thanks,
Kai

>
> [1]: https://lttng.org/docs/v2.14/#doc-installing-lttng
> [2]: https://rpmfind.net/linux/RPM/fedora/updates/testing/43/aarch64/Packages/l/lttng-tools-2.14.0-4.fc43.aarch64.html
> [3]: https://packages.debian.org/trixie/lttng-tools
>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb b/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
> index 620ddfb1cf..3a3f2cff2c 100644
> --- a/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
> +++ b/meta/recipes-kernel/lttng/lttng-tools_2.14.1.bb
> @@ -14,7 +14,6 @@ include lttng-platforms.inc
>   
>   DEPENDS = "liburcu popt libxml2 util-linux bison-native babeltrace2"
>   RDEPENDS:${PN} = "libgcc"
> -RRECOMMENDS:${PN} += "${LTTNGMODULES}"
>   RDEPENDS:${PN}-ptest += "make perl bash gawk procps perl-module-overloading coreutils util-linux kmod ${LTTNGMODULES} sed python3-core grep binutils python3-multiprocessing"
>   RDEPENDS:${PN}-ptest:append:libc-glibc = " glibc-utils"
>   RDEPENDS:${PN}-ptest:append:libc-musl = " musl-utils"
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#232171): https://lists.openembedded.org/g/openembedded-core/message/232171
> Mute This Topic: https://lists.openembedded.org/mt/118089750/3616933
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kai.kang@windriver.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

-- 
Kai Kang
Wind River Linux



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lttng-tools: not rrecommend on lttng-modules
  2026-03-02  6:40 [PATCH] lttng-tools: not rrecommend on lttng-modules kai.kang
  2026-03-18  2:08 ` [OE-core] " Kai
@ 2026-03-18  7:37 ` Richard Purdie
  2026-03-18  7:45   ` Kai
  1 sibling, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2026-03-18  7:37 UTC (permalink / raw)
  To: kai.kang; +Cc: openembedded-core

On Mon, 2026-03-02 at 14:40 +0800, kai.kang@windriver.com wrote:
> From: Kai Kang <kai.kang@windriver.com>
> 
> As in the lttng manual [1]:
> 
>   Most distributions mark the LTTng-modules and LTTng-UST packages as
>   optional when installing LTTng-tools (which is always required). In
>   the following sections, we always provide the steps to install all
>   three, but note that:
> 
>   * You only need to install LTTng-modules if you intend to use the
>     Linux kernel LTTng tracer.
>   * You only need to install LTTng-UST if you intend to use the user
>     space LTTng tracer.
> 
> there should be no force dependency between lttng-tools and
> lttng-modules. When set lttng-modules in RRECOMMENDS, it always
> forces
> to build lttng-modules whether it is required or not.
> 
> Compare to rpm spec [2] and debian conf [3], there are no any
> dependency
> between them too.
> 
> So remove the RRECOMMENDS setting.
> 
> [1]: https://lttng.org/docs/v2.14/#doc-installing-lttng
> [2]:
> https://rpmfind.net/linux/RPM/fedora/updates/testing/43/aarch64/Packages/l/lttng-tools-2.14.0-4.fc43.aarch64.html
> [3]: https://packages.debian.org/trixie/lttng-tools
> 
> Signed-off-by: Kai Kang <kai.kang@windriver.com>

The removal of the dependency probably makes sense but we need to add
lttng-modules to packagegroup-core-tools-profile instead.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] lttng-tools: not rrecommend on lttng-modules
  2026-03-18  7:37 ` Richard Purdie
@ 2026-03-18  7:45   ` Kai
  0 siblings, 0 replies; 4+ messages in thread
From: Kai @ 2026-03-18  7:45 UTC (permalink / raw)
  To: Richard Purdie; +Cc: openembedded-core

On 3/18/26 15:37, Richard Purdie wrote:
> On Mon, 2026-03-02 at 14:40 +0800, kai.kang@windriver.com wrote:
>> From: Kai Kang <kai.kang@windriver.com>
>>
>> As in the lttng manual [1]:
>>
>>    Most distributions mark the LTTng-modules and LTTng-UST packages as
>>    optional when installing LTTng-tools (which is always required). In
>>    the following sections, we always provide the steps to install all
>>    three, but note that:
>>
>>    * You only need to install LTTng-modules if you intend to use the
>>      Linux kernel LTTng tracer.
>>    * You only need to install LTTng-UST if you intend to use the user
>>      space LTTng tracer.
>>
>> there should be no force dependency between lttng-tools and
>> lttng-modules. When set lttng-modules in RRECOMMENDS, it always
>> forces
>> to build lttng-modules whether it is required or not.
>>
>> Compare to rpm spec [2] and debian conf [3], there are no any
>> dependency
>> between them too.
>>
>> So remove the RRECOMMENDS setting.
>>
>> [1]: https://lttng.org/docs/v2.14/#doc-installing-lttng
>> [2]:
>> https://rpmfind.net/linux/RPM/fedora/updates/testing/43/aarch64/Packages/l/lttng-tools-2.14.0-4.fc43.aarch64.html
>> [3]: https://packages.debian.org/trixie/lttng-tools
>>
>> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> The removal of the dependency probably makes sense but we need to add
> lttng-modules to packagegroup-core-tools-profile instead.

OK. v2 will be sent.

Thanks,

Kai

>
> Cheers,
>
> Richard
>

-- 
Kai Kang
Wind River Linux



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-03-18  7:46 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-02  6:40 [PATCH] lttng-tools: not rrecommend on lttng-modules kai.kang
2026-03-18  2:08 ` [OE-core] " Kai
2026-03-18  7:37 ` Richard Purdie
2026-03-18  7:45   ` Kai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox