Re: [OE-core][PATCH] oeqa/selftest: add test case to cover 'devtool modify -n' for a git recipe

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Mon, 2024-01-22 at 13:29 +0800, Chen Qi via lists.openembedded.org
wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
> 
> Add a test case to ensure the following error does not happen again for
> 'devtool modify -n'.
> 
> Traceback (most recent call last):
>   File "/buildarea2/chenqi/poky/scripts/devtool", line 349, in <module>
>     ret = main()
>   File "/buildarea2/chenqi/poky/scripts/devtool", line 336, in main
>     ret = args.func(args, config, basepath, workspace)
>   File "/buildarea2/chenqi/poky/scripts/lib/devtool/standard.py", line 924, in modify
>     if not initial_revs["."]:
> KeyError: '.'
> 
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> ---
>  meta/lib/oeqa/selftest/cases/devtool.py | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/meta/lib/oeqa/selftest/cases/devtool.py b/meta/lib/oeqa/selftest/cases/devtool.py
> index a877720769..22ea0ecba9 100644
> --- a/meta/lib/oeqa/selftest/cases/devtool.py
> +++ b/meta/lib/oeqa/selftest/cases/devtool.py
> @@ -917,6 +917,28 @@ class DevtoolModifyTests(DevtoolBase):
>          # Try building
>          bitbake(testrecipe)
>  
> +    def test_devtool_modify_git_no_extract(self):
> +        # Check preconditions
> +        testrecipe = 'psplash'
> +        src_uri = get_bb_var('SRC_URI', testrecipe)
> +        self.assertIn('git://', src_uri, 'This test expects the %s recipe to be a git recipe' % testrecipe)
> +        # Clean up anything in the workdir/sysroot/sstate cache
> +        bitbake('%s -c cleansstate' % testrecipe)

I'm afraid we can't use cleansstate inside oe-selftest as it may race
against other copies of oe-selftest running against the same sstate
cache (or other builds using psplash in this case).

We'll need to find another way to make this work.

Cheers,

Richard