Re: [OE-core][PATCH] oeqa/selftest: add test case to cover 'devtool modify -n' for a git recipe

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Fri, 2024-01-26 at 16:00 +0100, Alexander Kanavin wrote:
> On Fri, 26 Jan 2024 at 15:54, Richard Purdie
> <richard.purdie@linuxfoundation.org> wrote:
> 
> > > +    def test_devtool_modify_git_no_extract(self):
> > > +        # Check preconditions
> > > +        testrecipe = 'psplash'
> > > +        src_uri = get_bb_var('SRC_URI', testrecipe)
> > > +        self.assertIn('git://', src_uri, 'This test expects the %s recipe to be a git recipe' % testrecipe)
> > > +        # Clean up anything in the workdir/sysroot/sstate cache
> > > +        bitbake('%s -c cleansstate' % testrecipe)
> > 
> > I'm afraid we can't use cleansstate inside oe-selftest as it may race
> > against other copies of oe-selftest running against the same sstate
> > cache (or other builds using psplash in this case).
> > 
> > We'll need to find another way to make this work.
> 
> There's a number of existing tests in
> meta/lib/oeqa/selftest/cases/devtool.py which do rely on cleansstate;
> I can only presume they do it with utmost care, and can be used as
> examples for how things could be done.

Thanks for the reminder. devtool is "special" in that it does:

        cls.sstate_conf  = 'SSTATE_DIR = "%s"\n' % cls.devtool_sstate
        cls.sstate_conf += ('SSTATE_MIRRORS += "file://.* file:///%s/PATH"\n' % cls.original_sstate)

in DevtoolBase which means it can call cleansstate.

I'll queue it for merge, thanks.

Cheers,

Richard