[PATCH v2] file: add PACKAGECONFIG for auto options

[PATCH v2] file: add PACKAGECONFIG for auto options

[Konrad Weihmann]

A few options of file configure are set to auto, which can lead to
unpredictable effect when something in the sysroot does provide
things that satisfy the autotools checks.
In the worst case this will lead to package-qa failure as libraries are
not set in RDEPENDS but configured for the tool.

To mitigate changes of accidental configure set explicit options via
newly introduced PACKAGECONFIG variables for bzip, lzma and zlib
support, where the default is just zlib, as it was before

changes v2:

- add explicit enable options

Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
---
 meta/recipes-devtools/file/file_5.38.bb | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/file/file_5.38.bb b/meta/recipes-devtools/file/file_5.38.bb
index b8f09107e8..e528d84cdd 100644
--- a/meta/recipes-devtools/file/file_5.38.bb
+++ b/meta/recipes-devtools/file/file_5.38.bb
@@ -8,7 +8,7 @@ SECTION = "console/utils"
 LICENSE = "BSD-2-Clause"
 LIC_FILES_CHKSUM = "file://COPYING;beginline=2;md5=0251eaec1188b20d9a72c502ecfdda1b"
 
-DEPENDS = "zlib file-replacement-native"
+DEPENDS = "file-replacement-native"
 DEPENDS_class-native = "zlib-native"
 
 SRC_URI = "git://github.com/file/file.git"
@@ -18,6 +18,11 @@ S = "${WORKDIR}/git"
 
 inherit autotools update-alternatives
 
+PACKAGECONFIG ??= "zlib"
+PACKAGECONFIG[bz2] = "--enable-bzlib,--disable-bzlib,bzip2"
+PACKAGECONFIG[lzma] = "--enable-xzlib,--disable-xzlib,xz"
+PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
+
 EXTRA_OECONF += "--disable-libseccomp"
 
 ALTERNATIVE_${PN} = "file"
-- 
2.20.1

Re: [OE-core] [PATCH v2] file: add PACKAGECONFIG for auto options

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Konrad Weihmann
> Sent: den 9 maj 2020 23:08
> To: openembedded-core@lists.openembedded.org
> Cc: Konrad Weihmann <kweihmann@outlook.com>
> Subject: [OE-core] [PATCH v2] file: add PACKAGECONFIG for auto options
> 
> A few options of file configure are set to auto, which can lead to
> unpredictable effect when something in the sysroot does provide
> things that satisfy the autotools checks.
> In the worst case this will lead to package-qa failure as libraries are
> not set in RDEPENDS but configured for the tool.
> 
> To mitigate changes of accidental configure set explicit options via
> newly introduced PACKAGECONFIG variables for bzip, lzma and zlib
> support, where the default is just zlib, as it was before
> 
> changes v2:
> 
> - add explicit enable options

The v2 information belongs after the --- below as it relates to the 
review process.

//Peter

> 
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
>  meta/recipes-devtools/file/file_5.38.bb | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/file/file_5.38.bb b/meta/recipes-
> devtools/file/file_5.38.bb
> index b8f09107e8..e528d84cdd 100644
> --- a/meta/recipes-devtools/file/file_5.38.bb
> +++ b/meta/recipes-devtools/file/file_5.38.bb
> @@ -8,7 +8,7 @@ SECTION = "console/utils"
>  LICENSE = "BSD-2-Clause"
>  LIC_FILES_CHKSUM =
> "file://COPYING;beginline=2;md5=0251eaec1188b20d9a72c502ecfdda1b"
> 
> -DEPENDS = "zlib file-replacement-native"
> +DEPENDS = "file-replacement-native"
>  DEPENDS_class-native = "zlib-native"
> 
>  SRC_URI = "git://github.com/file/file.git"
> @@ -18,6 +18,11 @@ S = "${WORKDIR}/git"
> 
>  inherit autotools update-alternatives
> 
> +PACKAGECONFIG ??= "zlib"
> +PACKAGECONFIG[bz2] = "--enable-bzlib,--disable-bzlib,bzip2"
> +PACKAGECONFIG[lzma] = "--enable-xzlib,--disable-xzlib,xz"
> +PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
> +
>  EXTRA_OECONF += "--disable-libseccomp"
> 
>  ALTERNATIVE_${PN} = "file"
> --
> 2.20.1

Re: [OE-core] [PATCH v2] file: add PACKAGECONFIG for auto options

[Andre McCurdy]

On Sat, May 9, 2020 at 2:08 PM Konrad Weihmann <kweihmann@outlook.com> wrote:
>
> A few options of file configure are set to auto, which can lead to
> unpredictable effect when something in the sysroot does provide
> things that satisfy the autotools checks.
> In the worst case this will lead to package-qa failure as libraries are
> not set in RDEPENDS but configured for the tool.
>
> To mitigate changes of accidental configure set explicit options via
> newly introduced PACKAGECONFIG variables for bzip, lzma and zlib
> support, where the default is just zlib, as it was before
>
> changes v2:
>
> - add explicit enable options
>
> Signed-off-by: Konrad Weihmann <kweihmann@outlook.com>
> ---
>  meta/recipes-devtools/file/file_5.38.bb | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/file/file_5.38.bb b/meta/recipes-devtools/file/file_5.38.bb
> index b8f09107e8..e528d84cdd 100644
> --- a/meta/recipes-devtools/file/file_5.38.bb
> +++ b/meta/recipes-devtools/file/file_5.38.bb
> @@ -8,7 +8,7 @@ SECTION = "console/utils"
>  LICENSE = "BSD-2-Clause"
>  LIC_FILES_CHKSUM = "file://COPYING;beginline=2;md5=0251eaec1188b20d9a72c502ecfdda1b"
>
> -DEPENDS = "zlib file-replacement-native"
> +DEPENDS = "file-replacement-native"
>  DEPENDS_class-native = "zlib-native"

If you use PACKAGECONFIG to express the dependency on zlib then you
should do so consistently for both target and native. ie remove the
DEPENDS_class-native above and then add PACKAGECONFIG_class-native =
"zlib" below.

>  SRC_URI = "git://github.com/file/file.git"
> @@ -18,6 +18,11 @@ S = "${WORKDIR}/git"
>
>  inherit autotools update-alternatives
>
> +PACKAGECONFIG ??= "zlib"
> +PACKAGECONFIG[bz2] = "--enable-bzlib,--disable-bzlib,bzip2"
> +PACKAGECONFIG[lzma] = "--enable-xzlib,--disable-xzlib,xz"
> +PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
> +
>  EXTRA_OECONF += "--disable-libseccomp"
>
>  ALTERNATIVE_${PN} = "file"
> --
> 2.20.1
>
>