Re: [PATCH] openssl: use nativeperl to build

[richard.purdie@linuxfoundation.org]

On Fri, 2018-10-12 at 15:54 +0800, Hongxu Jia wrote:
> On 2018年10月11日 22:58, Hongxu Jia wrote:
> > On 2018年10月11日 20:00, richard.purdie@linuxfoundation.org wrote:
> > > On Thu, 2018-10-11 at 02:55 -0700, Hongxu Jia wrote:
> > > > If host perl is old version (such as perl v5.16.3 on CentOS-
> > > > 7.5),
> > > > the openssl-native failed at do_install, the reason is its
> > > > Makefile
> > > > is not correct which is generated at do_configure by perl
> > > > script.
> > > > 
> > > > Use nativeperl to assure latest perl on host for openssl build.
> > > > 
> > > > Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> > > > ---
> > > >   meta/recipes-connectivity/openssl/openssl_1.1.1.bb | 6 ++++--
> > > >   1 file changed, 4 insertions(+), 2 deletions(-)
> > > 
> > > I think this will have a noticeable effect on built times
> > > unfortunately
> > > since it means openssl-native would then depend upon perl-
> > > native...
> 
> Hi RP,
> 
> With some digging on upstream, more than perl version,
> the building also requires to install perl Text::Template module
> which does not exist in core perl, I think we have to add the recipe
> 
> [snip]
>   Notes on Perl modules we use
>   ----------------------------
>   We make increasing use of Perl modules, and do our best to limit
>   ourselves to core Perl modules to keep the requirements down. There
>   are just a few exceptions:
>   Test::More         We require the minimum version to be 0.96, which
>                      appeared in Perl 5.13.4, because that version
> was
>                      the first to have all the features we're using.
>                      This module is required for testing only!  If
> you
>                      don't plan on running the tests, you don't need
> to
>                      bother with this one.
> 
>   Text::Template     This module is not part of the core Perl
> modules.
>                      As a matter of fact, the core Perl modules do
> not
>                      include any templating module to date.
>                      This module is absolutely needed, configuration
> depends on it.
> [snip]
> 
> https://github.com/openssl/openssl/blob/master/NOTES.PERL
> 
https://github.com/openssl/openssl/commit/4e351ca92e3a1f447cef3d2e330f13941f9412c6

That is a good find. Perhaps we could check for that in sanity.bbclass?
Is it commonly available in distributions like centos? 

I am worried about the build time impact of a nativeperl dependency as
whilst your test doesn't show it in the image build, it will show up on
slower build machines with fewer threads.

Cheers,

Richard