Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Hongxu Jia <hongxu.jia@windriver.com>
To: <richard.purdie@linuxfoundation.org>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] openssl: use nativeperl to build
Date: Fri, 12 Oct 2018 17:03:07 +0800	[thread overview]
Message-ID: <d79efe64-c2a1-fb09-d174-7d27ab741442@windriver.com> (raw)
In-Reply-To: <62308c8aac0596271b7ca1f12aabb78547f1a7a9.camel@linuxfoundation.org>

[-- Attachment #1: Type: text/plain, Size: 2226 bytes --]

On 2018年10月12日 16:57, richard.purdie@linuxfoundation.org wrote:
>> Hi RP,
>>
>> With some digging on upstream, more than perl version,
>> the building also requires to install perl Text::Template module
>> which does not exist in core perl, I think we have to add the recipe
>>
>> [snip]
>>    Notes on Perl modules we use
>>    ----------------------------
>>    We make increasing use of Perl modules, and do our best to limit
>>    ourselves to core Perl modules to keep the requirements down. There
>>    are just a few exceptions:
>>    Test::More         We require the minimum version to be 0.96, which
>>                       appeared in Perl 5.13.4, because that version
>> was
>>                       the first to have all the features we're using.
>>                       This module is required for testing only!  If
>> you
>>                       don't plan on running the tests, you don't need
>> to
>>                       bother with this one.
>>
>>    Text::Template     This module is not part of the core Perl
>> modules.
>>                       As a matter of fact, the core Perl modules do
>> not
>>                       include any templating module to date.
>>                       This module is absolutely needed, configuration
>> depends on it.
>> [snip]
>>
>> https://github.com/openssl/openssl/blob/master/NOTES.PERL
>>
> https://github.com/openssl/openssl/commit/4e351ca92e3a1f447cef3d2e330f13941f9412c6
>
> That is a good find. Perhaps we could check for that in sanity.bbclass?
> Is it commonly available in distributions like centos?
I am afraid the perl module (Text::Template) is not common,
available on most distro, since they do not need to build
openssl :(

But I am curious that without that perl module, the build seem
ok with newer perl (perl v5.22.1 in ubuntu 1804 and without Text::Template)

I am going on digging the root cause why the build works well
without the perl module

//Hongxu


> I am worried about the build time impact of a nativeperl dependency as
> whilst your test doesn't show it in the image build, it will show up on
> slower build machines with fewer threads.
>
> Cheers,
>
> Richard
>


[-- Attachment #2: Type: text/html, Size: 3231 bytes --]

  reply	other threads:[~2018-10-12  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-11  9:55 [PATCH] openssl: use nativeperl to build Hongxu Jia
2018-10-11 12:00 ` richard.purdie
2018-10-11 14:58   ` Hongxu Jia
2018-10-12  7:54     ` Hongxu Jia
2018-10-12  8:57       ` richard.purdie
2018-10-12  9:03         ` Hongxu Jia [this message]
2018-10-12  9:26           ` Hongxu Jia

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d79efe64-c2a1-fb09-d174-7d27ab741442@windriver.com \
    --to=hongxu.jia@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox