public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Khem Raj <raj.khem@gmail.com>, Ross Burton <ross.burton@arm.com>,
	openembedded-core@lists.openembedded.org
Cc: nd@arm.com
Subject: Re: [OE-core] [PATCH] pulseaudio: add m4-native to DEPENDS
Date: Fri, 15 Jul 2022 18:10:26 +0100	[thread overview]
Message-ID: <66a2252bde5d7e721d706b1581f7300e9bc61663.camel@linuxfoundation.org> (raw)
In-Reply-To: <d7ae54ce-8362-32ca-163e-539f5fa32805@gmail.com>

On Fri, 2022-07-15 at 13:05 -0400, Khem Raj wrote:
> 
> On 7/15/22 7:05 AM, Ross Burton wrote:
> > Normally m4-native ends up in the sysroot via the toolchain, but if a
> > non-standard toolchain is used them m4-native may not be installed.
> > 
> > However Pulseaudio explicitly checks for m4 in the meson.build, so add
> > it to DEPENDS.
> 
> I think default toolchain dependencies should be emulated by external 
> toolchains too. Or perhaps m4-native should be dropped from the internal 
> toolchain too.

See the section in OE-Core's layer.conf:

"""
# Avoid adding bison-native to the sysroot without a specific
# dependency in the recipe. This means indirect dependencies
# (e.g. X -> Y -> binutils-cross -> bison-native) no longer meet the
# dependency incidentally. This improves determinism and avoids build
# failures when people switch to external toolchains.
# libarchive only needs e2fsprogs headers at buildtime
SSTATE_EXCLUDEDEPS_SYSROOT += "\
    .*->autoconf-native \
    .*->automake-native \
    .*->bison-native \
"""

If we add m4-native to that list, it would do that. Just need someone
to work through all the failures it might generate.

Cheers,

Richard


  reply	other threads:[~2022-07-15 17:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-15 11:05 [PATCH] pulseaudio: add m4-native to DEPENDS Ross Burton
2022-07-15 17:05 ` [OE-core] " Khem Raj
2022-07-15 17:10   ` Richard Purdie [this message]
2022-07-15 17:16     ` Khem Raj

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=66a2252bde5d7e721d706b1581f7300e9bc61663.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=nd@arm.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=ross.burton@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox