From: Khem Raj <raj.khem@gmail.com>
To: Ross Burton <ross.burton@arm.com>,
openembedded-core@lists.openembedded.org
Cc: nd@arm.com
Subject: Re: [OE-core] [PATCH] pulseaudio: add m4-native to DEPENDS
Date: Fri, 15 Jul 2022 13:05:29 -0400 [thread overview]
Message-ID: <d7ae54ce-8362-32ca-163e-539f5fa32805@gmail.com> (raw)
In-Reply-To: <20220715110533.4008485-1-ross.burton@arm.com>
On 7/15/22 7:05 AM, Ross Burton wrote:
> Normally m4-native ends up in the sysroot via the toolchain, but if a
> non-standard toolchain is used them m4-native may not be installed.
>
> However Pulseaudio explicitly checks for m4 in the meson.build, so add
> it to DEPENDS.
I think default toolchain dependencies should be emulated by external
toolchains too. Or perhaps m4-native should be dropped from the internal
toolchain too.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> meta/recipes-multimedia/pulseaudio/pulseaudio.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> index 602d7263ce8..6055a9ebadb 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio.inc
> @@ -61,7 +61,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=0e5cd938de1a7a53ea5adac38cc10c39 \
> "
>
> # libtool is needed for libltdl, used in module loading.
> -DEPENDS = "libatomic-ops libsndfile1 libtool"
> +DEPENDS = "m4-native libatomic-ops libsndfile1 libtool"
> # optional
> DEPENDS += "udev alsa-lib glib-2.0"
> DEPENDS += "speexdsp libxml-parser-perl-native libcap"
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#168055): https://lists.openembedded.org/g/openembedded-core/message/168055
> Mute This Topic: https://lists.openembedded.org/mt/92398180/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2022-07-15 17:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-15 11:05 [PATCH] pulseaudio: add m4-native to DEPENDS Ross Burton
2022-07-15 17:05 ` Khem Raj [this message]
2022-07-15 17:10 ` [OE-core] " Richard Purdie
2022-07-15 17:16 ` Khem Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7ae54ce-8362-32ca-163e-539f5fa32805@gmail.com \
--to=raj.khem@gmail.com \
--cc=nd@arm.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox