From: Khem Raj <raj.khem@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/8] binutils: Fix variable conflict
Date: Wed, 5 Sep 2018 13:52:59 -0700 [thread overview]
Message-ID: <6fdfea5f-acd2-0644-89bf-4de5525ecda2@gmail.com> (raw)
In-Reply-To: <20180905165227.29435-4-richard.purdie@linuxfoundation.org>
[-- Attachment #1.1: Type: text/plain, Size: 1230 bytes --]
On 9/5/18 9:52 AM, Richard Purdie wrote:
> A recent binutils patch added the LDGOLD variable but its already used
> for controlling EXTRA_OECONF options for gold. Separate the two variables
> to different names to avoid build warnings and confusion.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
> meta/recipes-devtools/binutils/binutils.inc | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-devtools/binutils/binutils.inc b/meta/recipes-devtools/binutils/binutils.inc
> index b56fcd4cd01..81ecbb50cc1 100644
> --- a/meta/recipes-devtools/binutils/binutils.inc
> +++ b/meta/recipes-devtools/binutils/binutils.inc
> @@ -38,8 +38,8 @@ FILES_${PN}-dev = " \
> # Rather than duplicating multiple entries for these, make one
> # list and reuse it.
>
> -LDGOLD ?= "ld.gold dwp"
> -LDGOLD_riscv64 = ""
> +LDGOLD_ALTS ?= "ld.gold dwp"
> +LDGOLD_ALTS_riscv64 = ""
>
> USE_ALTERNATIVES_FOR = " \
> addr2line \
> @@ -50,7 +50,7 @@ USE_ALTERNATIVES_FOR = " \
> gprof \
> ld \
> ld.bfd \
> - ${LDGOLD} \
> + ${LDGOLD_ALTS} \
aw my bad. Thanks for taking care of it.
> nm \
> objcopy \
> objdump \
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 201 bytes --]
next prev parent reply other threads:[~2018-09-05 20:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 16:52 [PATCH 1/8] python: Run pybench once for optimisation task in pgo Richard Purdie
2018-09-05 16:52 ` [PATCH 2/8] os-release: fix to install in the expected location Richard Purdie
2018-09-05 17:16 ` Andre McCurdy
2018-09-05 17:20 ` richard.purdie
2018-09-05 16:52 ` [PATCH 3/8] gcc: Merge two related patches together Richard Purdie
2018-09-05 16:52 ` [PATCH 4/8] binutils: Fix variable conflict Richard Purdie
2018-09-05 20:52 ` Khem Raj [this message]
2018-09-05 16:52 ` [PATCH 5/8] populate_base_sdk: Stop running gcc --version all the time Richard Purdie
2018-09-05 16:52 ` [PATCH 6/8] maintainers: Add entry for fribidi Richard Purdie
2018-09-05 16:52 ` [PATCH 7/8] busybox: Put klogd/syslogd alternative links in syslog package Richard Purdie
2018-09-06 2:11 ` ChenQi
2018-09-06 8:19 ` richard.purdie
2018-09-06 9:04 ` ChenQi
2018-09-06 22:05 ` richard.purdie
2018-09-06 22:51 ` Richard Purdie
2018-09-07 14:07 ` Mark Hatle
2018-09-05 16:52 ` [PATCH 8/8] busybox: Sync arch and link locations with coreutils Richard Purdie
2018-09-06 8:15 ` [PATCH 1/8] python: Run pybench once for optimisation task in pgo Robert Yang
2018-09-06 8:17 ` richard.purdie
2018-09-06 8:22 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6fdfea5f-acd2-0644-89bf-4de5525ecda2@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox