Re: [PATCH 7/8] busybox: Put klogd/syslogd alternative links in syslog package

[ChenQi <Qi.Chen@windriver.com>]

Hi Richard,

I think my previous patch has covered this case.

   git://git.pokylinux.org/poky-contrib ChenQi/busybox-alternatives
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=ChenQi/busybox-alternatives

Chen Qi (1):
   busybox: fix the alternatives logic


Is there some problem with the patch?

Best Regards,
Chen Qi

On 09/06/2018 12:52 AM, Richard Purdie wrote:
> Currently these are in ${PN} and ${PN}-syslog may get replaced by
> other packages but update-alternatives would error in the postinst
> if other files were installed first. Avoid the problems by putting
> the links in the correct package.
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   meta/recipes-core/busybox/busybox.inc | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> index 586d5342e60..c26ef56bf78 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -367,7 +367,10 @@ python do_package_prepend () {
>               # Match coreutils
>               if alt_name == '[':
>                   alt_name = 'lbracket'
> -            d.appendVar('ALTERNATIVE_%s' % (pn), ' ' + alt_name)
> +            if alt_name == 'klogd' or alt_name == 'syslogd':
> +                d.appendVar('ALTERNATIVE_%s-syslog' % (pn), ' ' + alt_name)
> +            else:
> +                d.appendVar('ALTERNATIVE_%s' % (pn), ' ' + alt_name)
>               d.setVarFlag('ALTERNATIVE_LINK_NAME', alt_name, alt_link_name)
>               if os.path.exists('%s%s' % (dvar, target)):
>                   d.setVarFlag('ALTERNATIVE_TARGET', alt_name, target)