[PATCH] busybox: Fix busybox-init on non-tty consoles

[PATCH] busybox: Fix busybox-init on non-tty consoles

[Stefan Agner]

When using non-tty consoles (e.g. VirtIO console /dev/hvc0) the
current init system fails with:
process '/sbin/getty 115200 hvc0' (pid 545) exited. Scheduling for restart.
can't open /dev/ttyhvc0: No such file or directory

The first field needs to be a valid device. The BusyBox inittab example
explains as follows:
"<id>: WARNING: This field has a non-traditional meaning for BusyBox init!

The id field is used by BusyBox init to specify the controlling tty for
the specified process to run on.  The contents of this field are
appended to "/dev/" and used as-is."

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 meta/recipes-core/busybox/busybox.inc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
index 5e91a26..4765c28 100644
--- a/meta/recipes-core/busybox/busybox.inc
+++ b/meta/recipes-core/busybox/busybox.inc
@@ -286,8 +286,8 @@ do_install () {
                         for i in $tmp
                         do
                                 j=`echo ${i} | sed s/\;/\ /g`
-                                label=`echo ${i} | sed -e 's/tty//' -e 's/^.*;//' -e 's/;.*//'`
-                                echo "tty$label::respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
+                                id=`echo ${i} | -e 's/^.*;//' -e 's/;.*//'`
+                                echo "$id::respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
                         done
                 fi
         fi
-- 
2.9.0

Re: [PATCH] busybox: Fix busybox-init on non-tty consoles

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1781 bytes --]


> On Aug 7, 2016, at 6:30 PM, Stefan Agner <stefan@agner.ch> wrote:
> 
> When using non-tty consoles (e.g. VirtIO console /dev/hvc0) the
> current init system fails with:
> process '/sbin/getty 115200 hvc0' (pid 545) exited. Scheduling for restart.
> can't open /dev/ttyhvc0: No such file or directory
> 
> The first field needs to be a valid device. The BusyBox inittab example
> explains as follows:
> "<id>: WARNING: This field has a non-traditional meaning for BusyBox init!
> 
> The id field is used by BusyBox init to specify the controlling tty for
> the specified process to run on.  The contents of this field are
> appended to "/dev/" and used as-is."
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---
> meta/recipes-core/busybox/busybox.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
> index 5e91a26..4765c28 100644
> --- a/meta/recipes-core/busybox/busybox.inc
> +++ b/meta/recipes-core/busybox/busybox.inc
> @@ -286,8 +286,8 @@ do_install () {
>                         for i in $tmp
>                         do
>                                 j=`echo ${i} | sed s/\;/\ /g`
> -                                label=`echo ${i} | sed -e 's/tty//' -e 's/^.*;//' -e 's/;.*//'`
> -                                echo "tty$label::respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
> +                                id=`echo ${i} | -e 's/^.*;//' -e 's/;.*//‘`

what cmd is this piping it to now ?

> +                                echo "$id::respawn:${base_sbindir}/getty ${j}" >> ${D}${sysconfdir}/inittab
>                         done
>                 fi
>         fi
> --
> 2.9.0
> 


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]