[PATCH 1/2] systemd: Remove systemd_unitdir if systemd is not in distro features

[PATCH 1/2] systemd: Remove systemd_unitdir if systemd is not in distro features

[Shakeel, Muhammad]

From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

If systemd is not supported DISTRO_FEATURE than there is no need to
package related service files.

Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
 meta/classes/systemd.bbclass |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/meta/classes/systemd.bbclass b/meta/classes/systemd.bbclass
index 0447e53..9763faa 100644
--- a/meta/classes/systemd.bbclass
+++ b/meta/classes/systemd.bbclass
@@ -161,3 +161,12 @@ python systemd_populate_packages() {
 }
 
 PACKAGESPLITFUNCS_prepend = "systemd_populate_packages "
+
+python rm_systemd_unitdir (){
+    import shutil
+    if "systemd" not in d.getVar("DISTRO_FEATURES", True).split():
+        systemd_unitdir = oe.path.join(d.getVar("D", True), d.getVar('systemd_unitdir', True))
+        if os.path.exists(systemd_unitdir):
+            shutil.rmtree(systemd_unitdir)
+}
+do_install[postfuncs] += "rm_systemd_unitdir "
-- 
1.7.9.5

[PATCH 2/2] update-rc.d: Remove init.d dir if sysvinit is not in distro features

[Shakeel, Muhammad]

From: Muhammad Shakeel <muhammad_shakeel@mentor.com>

If sysvinit is not supported DISTRO_FEATURE than there is no need to
package related initialization scripts.

Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
---
 meta/classes/update-rc.d.bbclass |    9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/meta/classes/update-rc.d.bbclass b/meta/classes/update-rc.d.bbclass
index 5588569..946c077 100644
--- a/meta/classes/update-rc.d.bbclass
+++ b/meta/classes/update-rc.d.bbclass
@@ -99,3 +99,12 @@ python populate_packages_updatercd () {
         for pkg in pkgs.split():
             update_rcd_package(pkg)
 }
+
+python rm_sysvinit_initddir (){
+    import shutil
+    if "sysvinit" not in d.getVar("DISTRO_FEATURES", True).split():
+        sysv_initddir = oe.path.join(d.getVar("D", True), d.getVar('INIT_D_DIR', True))
+        if os.path.exists(sysv_initddir):
+            shutil.rmtree(sysv_initddir)
+}
+do_install[postfuncs] += "rm_sysvinit_initddir "
-- 
1.7.9.5

Re: [PATCH 2/2] update-rc.d: Remove init.d dir if sysvinit is not in distro features

[Chris Larson]

[-- Attachment #1: Type: text/plain, Size: 788 bytes --]

On Fri, Jul 19, 2013 at 4:53 AM, Shakeel, Muhammad <
muhammad_shakeel@mentor.com> wrote:

> From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>
> If sysvinit is not supported DISTRO_FEATURE than there is no need to
> package related initialization scripts.
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>

If we stop shipping init.d for non-sysvinit distros, which makes sense, we
should also consider automatically enabling/disabling sysv compat support
in the systems build based on that distro feature also. So, I support this
commit, but am proposing adding another for consistency :)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1267 bytes --]

Re: [PATCH 2/2] update-rc.d: Remove init.d dir if sysvinit is not in distro features

[Paul Eggleton]

On Friday 19 July 2013 08:02:32 Chris Larson wrote:
> On Fri, Jul 19, 2013 at 4:53 AM, Shakeel, Muhammad 
> <muhammad_shakeel@mentor.com> wrote:
> > From: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> > 
> > If sysvinit is not supported DISTRO_FEATURE than there is no need to
> > package related initialization scripts.
> > 
> > Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> 
> If we stop shipping init.d for non-sysvinit distros, which makes sense, we
> should also consider automatically enabling/disabling sysv compat support
> in the systems build based on that distro feature also. So, I support this
> commit, but am proposing adding another for consistency :)

Yes, actually at the moment I think we cannot delete the sysvinit initscripts 
unless the recipe also inherits systemd, otherwise there will be no fallback 
to sysvinit compatibility and the daemon will no longer be started.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 1/2] systemd: Remove systemd_unitdir if systemd is not in distro features

[Burton, Ross]

On 19 July 2013 12:53, Shakeel, Muhammad <muhammad_shakeel@mentor.com> wrote:
> If systemd is not supported DISTRO_FEATURE than there is no need to
> package related service files.

When this is merged can you follow this up with a series to remove all
of the conditional installations in oe-core?

Cheers,
Ross

Re: [PATCH 1/2] systemd: Remove systemd_unitdir if systemd is not in distro features

[Muhammad Shakeel]

On 07/23/2013 06:59 PM, Burton, Ross wrote:
> On 19 July 2013 12:53, Shakeel, Muhammad <muhammad_shakeel@mentor.com> wrote:
>> If systemd is not supported DISTRO_FEATURE than there is no need to
>> package related service files.
> When this is merged can you follow this up with a series to remove all
> of the conditional installations in oe-core?
>
> Cheers,
> Ross
Yes, I intend to follow this up with removal of conditional check for 
service file installation.

Thanks,
Shakeel