Openembedded Core Discussions
 help / color / mirror / Atom feed
* [OE-core] [PATCH V2] bluez5: change configuration directory mode
@ 2022-10-05 13:59 liu.ming50
  2022-10-05 15:09 ` Peter Kjellerstedt
  0 siblings, 1 reply; 3+ messages in thread
From: liu.ming50 @ 2022-10-05 13:59 UTC (permalink / raw)
  To: openembedded-core; +Cc: Ming Liu

From: Ming Liu <liu.ming50@gmail.com>

Change configuration directory mode from 0755 to 0555, this fixes a
following warning when bluetoothd starts:
| ConfigurationDirectory 'bluetooth' already exists but the mode is different.
| (File system: 755 ConfigurationDirectoryMode: 555)

Signed-off-by: Ming Liu <liu.ming50@gmail.com>
---
 meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
index 79d4645ca8..48b8bcbe75 100644
--- a/meta/recipes-connectivity/bluez5/bluez5.inc
+++ b/meta/recipes-connectivity/bluez5/bluez5.inc
@@ -82,7 +82,7 @@ do_install:append() {
 	install -d ${D}${INIT_D_DIR}
 	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
 
-	install -d ${D}${sysconfdir}/bluetooth/
+	install -m 0755 -d ${D}${sysconfdir}/bluetooth/
 	if [ -f ${S}/profiles/network/network.conf ]; then
 		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
 	fi
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [OE-core] [PATCH V2] bluez5: change configuration directory mode
  2022-10-05 13:59 [OE-core] [PATCH V2] bluez5: change configuration directory mode liu.ming50
@ 2022-10-05 15:09 ` Peter Kjellerstedt
  2022-10-05 15:24   ` Ming Liu
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Kjellerstedt @ 2022-10-05 15:09 UTC (permalink / raw)
  To: Ming Liu, openembedded-core@lists.openembedded.org

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Ming Liu
> Sent: den 5 oktober 2022 15:59
> To: openembedded-core@lists.openembedded.org
> Cc: Ming Liu <liu.ming50@gmail.com>
> Subject: [OE-core] [PATCH V2] bluez5: change configuration directory mode
> 
> From: Ming Liu <liu.ming50@gmail.com>
> 
> Change configuration directory mode from 0755 to 0555, this fixes a
> following warning when bluetoothd starts:
> | ConfigurationDirectory 'bluetooth' already exists but the mode is different.
> | (File system: 755 ConfigurationDirectoryMode: 555)
> 
> Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> ---
>  meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc b/meta/recipes-connectivity/bluez5/bluez5.inc
> index 79d4645ca8..48b8bcbe75 100644
> --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> @@ -82,7 +82,7 @@ do_install:append() {
>  	install -d ${D}${INIT_D_DIR}
>  	install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> 
> -	install -d ${D}${sysconfdir}/bluetooth/
> +	install -m 0755 -d ${D}${sysconfdir}/bluetooth/

The default mode used by `install` if not specified is 0755. 
The above change should not make any difference...

>  	if [ -f ${S}/profiles/network/network.conf ]; then
>  		install -m 0644 ${S}/profiles/network/network.conf ${D}/${sysconfdir}/bluetooth/
>  	fi
> --
> 2.25.1

//Peter



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH V2] bluez5: change configuration directory mode
  2022-10-05 15:09 ` Peter Kjellerstedt
@ 2022-10-05 15:24   ` Ming Liu
  0 siblings, 0 replies; 3+ messages in thread
From: Ming Liu @ 2022-10-05 15:24 UTC (permalink / raw)
  To: Peter Kjellerstedt; +Cc: openembedded-core@lists.openembedded.org

[-- Attachment #1: Type: text/plain, Size: 1865 bytes --]

Hi, Peter:

You are absolutely right, I also noticed that, it’s a typo, it should be
0555, will send a V3 soon.

//Ming Liu

> -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <
> openembedded-core@lists.openembedded.org> On Behalf Of Ming Liu
> > Sent: den 5 oktober 2022 15:59
> > To: openembedded-core@lists.openembedded.org
> > Cc: Ming Liu <liu.ming50@gmail.com>
> > Subject: [OE-core] [PATCH V2] bluez5: change configuration directory mode
> >
> > From: Ming Liu <liu.ming50@gmail.com>
> >
> > Change configuration directory mode from 0755 to 0555, this fixes a
> > following warning when bluetoothd starts:
> > | ConfigurationDirectory 'bluetooth' already exists but the mode is
> different.
> > | (File system: 755 ConfigurationDirectoryMode: 555)
> >
> > Signed-off-by: Ming Liu <liu.ming50@gmail.com>
> > ---
> >  meta/recipes-connectivity/bluez5/bluez5.inc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-connectivity/bluez5/bluez5.inc
> b/meta/recipes-connectivity/bluez5/bluez5.inc
> > index 79d4645ca8..48b8bcbe75 100644
> > --- a/meta/recipes-connectivity/bluez5/bluez5.inc
> > +++ b/meta/recipes-connectivity/bluez5/bluez5.inc
> > @@ -82,7 +82,7 @@ do_install:append() {
> >       install -d ${D}${INIT_D_DIR}
> >       install -m 0755 ${WORKDIR}/init ${D}${INIT_D_DIR}/bluetooth
> >
> > -     install -d ${D}${sysconfdir}/bluetooth/
> > +     install -m 0755 -d ${D}${sysconfdir}/bluetooth/
>
> The default mode used by `install` if not specified is 0755.
> The above change should not make any difference...
>
> >       if [ -f ${S}/profiles/network/network.conf ]; then
> >               install -m 0644 ${S}/profiles/network/network.conf
> ${D}/${sysconfdir}/bluetooth/
> >       fi
> > --
> > 2.25.1
>
> //Peter
>
>

[-- Attachment #2: Type: text/html, Size: 2825 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-05 15:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-05 13:59 [OE-core] [PATCH V2] bluez5: change configuration directory mode liu.ming50
2022-10-05 15:09 ` Peter Kjellerstedt
2022-10-05 15:24   ` Ming Liu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox