Re: [OE-core] [dunfell][PATCH 1/2] bitbake: fetch2: fix handling of `\` in file:// SRC_URI

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Tue, 2021-08-31 at 13:45 +0100, Andrei Gherzan wrote:
> Hey,
> 
> On Tue, 24 Aug 2021, at 16:25, Andrei Gherzan wrote:
> > On Tue, 24 Aug 2021, at 15:24, Richard Purdie wrote:
> > > On Tue, 2021-08-24 at 04:20 -1000, Steve Sakoman wrote:
> > > > On Mon, Aug 23, 2021 at 3:53 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> > > > > 
> > > > > From: Leif Middelschulte <leif.middelschulte@klsmartin.com>
> > > > > 
> > > > > Using backslashes in file:// URIs was broken.
> > > > > Either the resolver would fail or the subsequent `cp` command.
> > > > > Try to avoid this by putting the filenames into quotes.
> > > > > 
> > > > > Fixes https://bugzilla.yoctoproject.org/show_bug.cgi?id=8161
> > > > > 
> > > > > (Bitbake rev: aa857fa2e9cf3b0e43a9049b04ec4b0b3c779b11)
> > > > 
> > > > Patches for bitbake should be sent to: bitbake-devel@lists.openembedded.org
> > > > 
> > > > I tried applying this patch, but found that it caused errors on the autobuilder:
> > > > 
> > > > https://errors.yoctoproject.org/Errors/Build/129189/
> > > > 
> > > 
> > > We dropped wildcard support in master but that is still present in dunfell. That
> > > means we can't quote things as we are relying on expansion of the wildcards for
> > > some SRC_URIs. This could be difficult to fix with the compatibility constraints
> > > of an older release funfortunately :/.
> > 
> > Got it now. That's going to be painful indeed. I can't think of an easy 
> > way out of this either.
> 
> Can you guys think of a way forward with this? Or shall we just drop it and consider it unsupported?

The only idea I had was to see if wildcards were in the name and only quote it
if not. I'm not sure we ever have had backslashes working though so it has
always been unsupported until the fix in master afaict.

Cheers,

Richard