From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Steve Sakoman <steve@sakoman.com>, Andrei Gherzan <andrei@gherzan.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>,
Leif Middelschulte <leif.middelschulte@klsmartin.com>
Subject: Re: [OE-core] [dunfell][PATCH 1/2] bitbake: fetch2: fix handling of `\` in file:// SRC_URI
Date: Tue, 24 Aug 2021 15:24:45 +0100 [thread overview]
Message-ID: <d248b212e6724aac56ae6b1638e438f25d350486.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAOSpxdYA6FchYLNRASehUkPcQkdHkjRJyjE6VaX0z--y6m3BWg@mail.gmail.com>
On Tue, 2021-08-24 at 04:20 -1000, Steve Sakoman wrote:
> On Mon, Aug 23, 2021 at 3:53 AM Andrei Gherzan <andrei@gherzan.com> wrote:
> >
> > From: Leif Middelschulte <leif.middelschulte@klsmartin.com>
> >
> > Using backslashes in file:// URIs was broken.
> > Either the resolver would fail or the subsequent `cp` command.
> > Try to avoid this by putting the filenames into quotes.
> >
> > Fixes https://bugzilla.yoctoproject.org/show_bug.cgi?id=8161
> >
> > (Bitbake rev: aa857fa2e9cf3b0e43a9049b04ec4b0b3c779b11)
>
> Patches for bitbake should be sent to: bitbake-devel@lists.openembedded.org
>
> I tried applying this patch, but found that it caused errors on the autobuilder:
>
> https://errors.yoctoproject.org/Errors/Build/129189/
>
We dropped wildcard support in master but that is still present in dunfell. That
means we can't quote things as we are relying on expansion of the wildcards for
some SRC_URIs. This could be difficult to fix with the compatibility constraints
of an older release funfortunately :/.
Cheers,
Richard
next prev parent reply other threads:[~2021-08-24 14:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 13:52 [dunfell][PATCH 1/2] bitbake: fetch2: fix handling of `\` in file:// SRC_URI Andrei Gherzan
2021-08-23 13:52 ` [dunfell][PATCH 2/2] Use the label provided when formating a dos partition Andrei Gherzan
2021-08-24 14:20 ` [OE-core] [dunfell][PATCH 1/2] bitbake: fetch2: fix handling of `\` in file:// SRC_URI Steve Sakoman
2021-08-24 14:24 ` Richard Purdie [this message]
2021-08-24 15:25 ` Andrei Gherzan
[not found] ` <169E47906AF45A5C.6361@lists.openembedded.org>
2021-08-31 12:45 ` Andrei Gherzan
2021-08-31 13:03 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d248b212e6724aac56ae6b1638e438f25d350486.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=andrei@gherzan.com \
--cc=leif.middelschulte@klsmartin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=steve@sakoman.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox