public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Paul Barker <paul@pbarker.dev>
To: Harish.Sadineni@windriver.com, openembedded-core@lists.openembedded.org
Cc: Randy.MacLeod@windriver.com, Sundeep.Kokkonda@windriver.com,
	 alistair.francis@wdc.com, bruce.ashfield@gmail.com,
	yoann.congal@smile.fr,  elmehdi.younes@smile.fr,
	richard.purdie@linuxfoundation.org
Subject: Re: [OE-core] [PATCH v5 05/15] kernel-yocto: Fix for buildpaths errors when rust is enabled for kernel
Date: Wed, 04 Feb 2026 12:03:42 +0000	[thread overview]
Message-ID: <7d3c95f45c56ce0651c5dcfaea9b13fde9a28d65.camel@pbarker.dev> (raw)
In-Reply-To: <20260129163910.2612040-6-Harish.Sadineni@windriver.com>

[-- Attachment #1: Type: text/plain, Size: 1970 bytes --]

On Thu, 2026-01-29 at 08:39 -0800, Sadineni, Harish via
lists.openembedded.org wrote:
> From: Harish Sadineni <Harish.Sadineni@windriver.com>
> 
> Fixes for buildpaths errors after enabling rust for linux-kernel
> 
> Co-authored-by: El Mehdi YOUNES <elmehdi.younes@smile.fr>
> Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>

The commit message here should explain the introduction of KRUSTFLAGS.

> ---
>  meta/classes-recipe/kernel-yocto.bbclass | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/meta/classes-recipe/kernel-yocto.bbclass b/meta/classes-recipe/kernel-yocto.bbclass
> index 4323c4c80a..cd5daaf33b 100644
> --- a/meta/classes-recipe/kernel-yocto.bbclass
> +++ b/meta/classes-recipe/kernel-yocto.bbclass
> @@ -4,6 +4,8 @@
>  # SPDX-License-Identifier: MIT
>  #
>  
> +INHERIT:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'rust-kernel', ' rust-common', '', d)}"
> +

We should be able to use inherit_defer here instead of modifying
INHERIT.

>  # remove tasks that modify the source tree in case externalsrc is inherited
>  SRCTREECOVEREDTASKS += "do_validate_branches do_kernel_configcheck do_kernel_checkout do_fetch do_unpack do_patch"
>  PATCH_GIT_USER_EMAIL ?= "kernel-yocto@oe"
> @@ -27,6 +29,11 @@ KMETA_AUDIT ?= "yes"
>  KMETA_AUDIT_WERROR ?= ""
>  KMETA_CONFIG_FEATURES ?= ""
>  
> +RUST_DEBUG_REMAP = "${@bb.utils.contains('DISTRO_FEATURES', 'rust-kernel', '--remap-path-prefix=${WORKDIR}=${TARGET_DBGSRC_DIR} \
> +                      --remap-path-prefix=${TMPDIR}/work-shared=${TARGET_DBGSRC_DIR}', '',d)}"
> +KRUSTFLAGS:append = " ${RUST_DEBUG_REMAP}"

Why do we use :append here?

> +EXTRA_OEMAKE:append = " ${@bb.utils.contains('DISTRO_FEATURES', 'rust-kernel', ' KRUSTFLAGS="${KRUSTFLAGS}"', '',d)}"
> +
>  # returns local (absolute) path names for all valid patches in the
>  # src_uri
>  def find_patches(d,subdir):

Best regards,

-- 
Paul Barker


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

  reply	other threads:[~2026-02-04 12:03 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 16:38 [PATCH v5 00/15] Enable rust support for linux kernel Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 01/15] linux-yocto: conditionally add clang/rust/bindgen-cli-native to DEPENDS Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 02/15] rust: install Rust library sources for 'make rustavailable' support Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 03/15] kernel-yocto: enable Rust kernel support via 'make rustavailable' Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 04/15] linux-yocto: enable Rust support in kernel configuration Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 05/15] kernel-yocto: Fix for buildpaths errors when rust is enabled for kernel Harish.Sadineni
2026-02-04 12:03   ` Paul Barker [this message]
2026-01-29 16:39 ` [PATCH v5 06/15] make-mod-scripts: split `HOSTCC` flag to align with to linux-yocto Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 07/15] kernel-yocto.bbclass: Disable ccache when rust-kernel is enabled Harish.Sadineni
2026-02-04 12:05   ` [OE-core] " Paul Barker
2026-02-04 12:31     ` Yoann Congal
2026-02-04 12:34       ` Richard Purdie
2026-02-04 13:07         ` Yoann Congal
2026-02-10 15:24           ` Yoann Congal
2026-02-11 11:47             ` Harish Sadineni
2026-01-29 16:39 ` [PATCH v5 08/15] kernel-devsrc: copying rust-kernel source to $kerneldir/build Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 09/15] selftest/cases/runtime_test: Add test for Linux Rust sample Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 10/15] kernel.bbclass: Copy include/config/auto.conf in STAGING_KERNEL_BUILDDIR Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 11/15] kernel.bbclass: Export artifacts needed for out-of-tree Rust compilation Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 12/15] module.bbclass: Prepare out-of-tree rust module compilation Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 13/15] meta-skeleton: Add rust-out-of-tree-module recipe Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 14/15] make-mod-scripts: fix for buildpath issues with rust-out-of-tree compilation Harish.Sadineni
2026-02-04 12:08   ` [OE-core] " Paul Barker
2026-01-29 16:39 ` [PATCH v5 15/15] runtime_test: Add rust-out-of-tree selftest Harish.Sadineni
2026-01-29 16:47 ` [PATCH v5 00/15] Enable rust support for linux kernel Sadineni, Harish
2026-02-04 12:00 ` [OE-core] " Paul Barker
2026-02-04 12:24   ` Paul Barker
2026-02-04 13:52     ` Bruce Ashfield
2026-02-12 18:13     ` Harish Sadineni
2026-02-04 13:54   ` Bruce Ashfield
     [not found] ` <188F412032A5A3F8.3408700@lists.openembedded.org>
2026-02-11 16:19   ` [OE-core] [PATCH v5 11/15] kernel.bbclass: Export artifacts needed for out-of-tree Rust compilation Harish Sadineni
2026-02-12 11:25     ` Yoann Congal
2026-02-12 12:44       ` Harish Sadineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d3c95f45c56ce0651c5dcfaea9b13fde9a28d65.camel@pbarker.dev \
    --to=paul@pbarker.dev \
    --cc=Harish.Sadineni@windriver.com \
    --cc=Randy.MacLeod@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=alistair.francis@wdc.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=elmehdi.younes@smile.fr \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=yoann.congal@smile.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox