public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Yoann Congal" <yoann.congal@smile.fr>
To: "Harish Sadineni" <Harish.Sadineni@windriver.com>,
	<openembedded-core@lists.openembedded.org>
Cc: <Randy.MacLeod@windriver.com>, <Sundeep.Kokkonda@windriver.com>,
	<alistair.francis@wdc.com>, <bruce.ashfield@gmail.com>,
	<elmehdi.younes@smile.fr>, <richard.purdie@linuxfoundation.org>
Subject: Re: [OE-core] [PATCH v5 11/15] kernel.bbclass: Export artifacts needed for out-of-tree Rust compilation
Date: Thu, 12 Feb 2026 12:25:16 +0100	[thread overview]
Message-ID: <DGCY2H440Y82.34J28P87KRA06@smile.fr> (raw)
In-Reply-To: <e191dda3-0c66-4cc6-93be-c09152173138@windriver.com>

On Wed Feb 11, 2026 at 5:19 PM CET, Harish Sadineni wrote:
>
> On 1/29/2026 10:09 PM, Sadineni, Harish via lists.openembedded.org wrote:
>> From: Yoann Congal <yoann.congal@smile.fr>
>>
>> Publish artifacts from kernel compilation to allow out-of-tree Rust
>> compilation:
>> * scripts/target.json: target definition: architecture, ABI, compiler
>>    options, ...
>> * rust/: the crates compiled by the kernel available to
>>    out-of-tree-modules
> Hi Yoann,
>
> I am dropping this patch “kernel.bbclass: Export artifacts needed for 
> out-of-tree Rust compilation” from my v6 patch series.
>
> Without this patch, target.json and the rust/ directory were already 
> getting published for x86_64. On arm64, target.json will not be created, 
> yet the module is still generated and works fine.
>
> When building rust-out-f-tree-module for arm64 with this patch applied, 
> it emits a warning that Out-of-tree rust modules build will fail due to 
> a missing target.json in kernel. However, in practice, the build 
> completes successfully.
>
> I have tested without this patch on both arm64 and x86_64, both tests 
> were successful.
>
> So, this patch does not appear to be necessary. Are you OK with dropping 
> this patch?

Yes, as long as it builds without warnings and test succesfully, I'm fine with it.

> I have pushed the updated changes to the below oe-contrib branch:
> https://git.openembedded.org/openembedded-core-contrib/log/?h=deepesh/rust-in-kernel-v6
>
> Additionally, I have extended the ccache disabling to make-mod-scripts 
> (as part of "kernel: Disable ccache when kernel rust support is enabled" 
> patch) and updated "meta-skeleton: Add rust-out-of-tree-module recipe" 
> to align with the new changes.

Shouldn't the KERNEL_RUST_SUPPORT check in
rust-out-of-tree-module_git.bb be moved to the module-rust class?

Generally, If you think that you rewrote some patches, I'm OK with you
taking authorship (leaving me as Co-developed-by). That should allow you
to edit patches more freely.

Regards,

> Thanks,
> Harish
>> Signed-off-by: Yoann Congal <yoann.congal@smile.fr>
>> Signed-off-by: Harish Sadineni <Harish.Sadineni@windriver.com>
>> ---
>>   meta/classes-recipe/kernel.bbclass | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/meta/classes-recipe/kernel.bbclass b/meta/classes-recipe/kernel.bbclass
>> index 30a10b0801..dfb8604a68 100644
>> --- a/meta/classes-recipe/kernel.bbclass
>> +++ b/meta/classes-recipe/kernel.bbclass
>> @@ -632,6 +632,24 @@ do_shared_workdir () {
>>   		cp -r scripts/gcc-plugins ${kerneldir}/scripts
>>   	fi
>>   
>> +	if ${@bb.utils.contains("DISTRO_FEATURES", "rust-kernel", "true", "false", d)}; then
>> +		# Copy target.json file needed for out-of-tree rust modules
>> +		if [ -e scripts/target.json ]; then
>> +			bbnote "Copying scripts/target.json"
>> +			mkdir -p ${kerneldir}/scripts
>> +			cp scripts/target.json ${kerneldir}/scripts
>> +		else
>> +			bbwarn "scripts/target.json not found in compiled kernel. Out-of-tree rust modules will fail to build."
>> +		fi
>> +
>> +		# Copy rust/ needed by out-of-tree module (firstly for the core rust crate)
>> +		if [ -e rust/ ]; then
>> +			bbnote "Copying rust/"
>> +			cp -r rust ${kerneldir}/
>> +		else
>> +			bbwarn "rust/ not found in compiled kernel. Out-of-tree rust modules will fail to build."
>> +		fi
>> +	fi
>>   }
>>   
>>   # We don't need to stage anything, not the modules/firmware since those would clash with linux-firmware
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#230151): https://lists.openembedded.org/g/openembedded-core/message/230151
>> Mute This Topic: https://lists.openembedded.org/mt/117528980/8054390
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [Harish.Sadineni@windriver.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>


-- 
Yoann Congal
Smile ECS



  reply	other threads:[~2026-02-12 11:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 16:38 [PATCH v5 00/15] Enable rust support for linux kernel Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 01/15] linux-yocto: conditionally add clang/rust/bindgen-cli-native to DEPENDS Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 02/15] rust: install Rust library sources for 'make rustavailable' support Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 03/15] kernel-yocto: enable Rust kernel support via 'make rustavailable' Harish.Sadineni
2026-01-29 16:38 ` [PATCH v5 04/15] linux-yocto: enable Rust support in kernel configuration Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 05/15] kernel-yocto: Fix for buildpaths errors when rust is enabled for kernel Harish.Sadineni
2026-02-04 12:03   ` [OE-core] " Paul Barker
2026-01-29 16:39 ` [PATCH v5 06/15] make-mod-scripts: split `HOSTCC` flag to align with to linux-yocto Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 07/15] kernel-yocto.bbclass: Disable ccache when rust-kernel is enabled Harish.Sadineni
2026-02-04 12:05   ` [OE-core] " Paul Barker
2026-02-04 12:31     ` Yoann Congal
2026-02-04 12:34       ` Richard Purdie
2026-02-04 13:07         ` Yoann Congal
2026-02-10 15:24           ` Yoann Congal
2026-02-11 11:47             ` Harish Sadineni
2026-01-29 16:39 ` [PATCH v5 08/15] kernel-devsrc: copying rust-kernel source to $kerneldir/build Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 09/15] selftest/cases/runtime_test: Add test for Linux Rust sample Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 10/15] kernel.bbclass: Copy include/config/auto.conf in STAGING_KERNEL_BUILDDIR Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 11/15] kernel.bbclass: Export artifacts needed for out-of-tree Rust compilation Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 12/15] module.bbclass: Prepare out-of-tree rust module compilation Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 13/15] meta-skeleton: Add rust-out-of-tree-module recipe Harish.Sadineni
2026-01-29 16:39 ` [PATCH v5 14/15] make-mod-scripts: fix for buildpath issues with rust-out-of-tree compilation Harish.Sadineni
2026-02-04 12:08   ` [OE-core] " Paul Barker
2026-01-29 16:39 ` [PATCH v5 15/15] runtime_test: Add rust-out-of-tree selftest Harish.Sadineni
2026-01-29 16:47 ` [PATCH v5 00/15] Enable rust support for linux kernel Sadineni, Harish
2026-02-04 12:00 ` [OE-core] " Paul Barker
2026-02-04 12:24   ` Paul Barker
2026-02-04 13:52     ` Bruce Ashfield
2026-02-12 18:13     ` Harish Sadineni
2026-02-04 13:54   ` Bruce Ashfield
     [not found] ` <188F412032A5A3F8.3408700@lists.openembedded.org>
2026-02-11 16:19   ` [OE-core] [PATCH v5 11/15] kernel.bbclass: Export artifacts needed for out-of-tree Rust compilation Harish Sadineni
2026-02-12 11:25     ` Yoann Congal [this message]
2026-02-12 12:44       ` Harish Sadineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGCY2H440Y82.34J28P87KRA06@smile.fr \
    --to=yoann.congal@smile.fr \
    --cc=Harish.Sadineni@windriver.com \
    --cc=Randy.MacLeod@windriver.com \
    --cc=Sundeep.Kokkonda@windriver.com \
    --cc=alistair.francis@wdc.com \
    --cc=bruce.ashfield@gmail.com \
    --cc=elmehdi.younes@smile.fr \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox