Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Jeroen Hofstee <oe@myspectrum.nl>
To: richard.purdie@linuxfoundation.org,
	Jeroen Hofstee <jeroen@myspectrum.nl>,
	openembedded-core@lists.openembedded.org
Cc: Jeroen Hofstee <jhofstee@victronenergy.com>
Subject: Re: [OE-core] [PATCH] udev-extraconf: fix ifupdown for non hotplug devices
Date: Wed, 9 Apr 2025 12:40:13 +0200	[thread overview]
Message-ID: <7eb23b12-1fd1-48a5-83cd-eab2edb8777b@myspectrum.nl> (raw)
In-Reply-To: <687a5c15fb54930b999cf16a59baaff8f9897a94.camel@linuxfoundation.org>

Hello Richard,

On 4/9/25 11:27, Richard Purdie via lists.openembedded.org wrote:
>>> We've purposefully kept the code called from udev and in our
>>> initscripts relatively minimal/simple as the overhead of executing
>>> multiple programs does build up over time. Taking the above, we have
>>> loops, then pipelines, each of which runs more commands. Each command
>>> has a fork/exec overhead.
>>>
>>> Is there some way we can simplify this rather than all the shell
>>> pipelines and loops?
>> The simplest solution is to patch busybox to respect  --allow=hotplug I guess.
> Yes, I as wondering about that. I see patches from a long time ago but
> I guess they were never merged. It probably is easier for busybox to
> handle this rather than shell code but I don't know what chance they'd
> have of being merged upstream.
>
> I would probably perfer to fix busybox to support this but I don't know
> how well that is going to work out...

Unless they changed their mind, upstream busybox won't accept it, so it
has to be a patch in OE. But feel free to try to upstream it.

For completeness, this is not some theoretical issue, always calling if up
directly after a network device is discovered does cause issues and is
against spec as well.

The sed stuff isn't that complicated, is it?

Regards,
Jeroen



  reply	other threads:[~2025-04-09 10:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 17:49 [OE-core] [PATCH] udev-extraconf: fix ifupdown for non hotplug devices Jeroen Hofstee
2025-04-09  8:37 ` Richard Purdie
2025-04-09  9:08   ` Jeroen Hofstee
2025-04-09  9:27     ` Richard Purdie
2025-04-09 10:40       ` Jeroen Hofstee [this message]
2025-04-09 10:52         ` Richard Purdie
2025-04-10 10:14         ` Alexander Kanavin
2025-04-10 12:17           ` Yoann Congal
2025-04-10 18:32             ` Jeroen Hofstee
2025-04-10 19:05               ` Alexander Kanavin
2025-04-09  9:28   ` Mike Looijmans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eb23b12-1fd1-48a5-83cd-eab2edb8777b@myspectrum.nl \
    --to=oe@myspectrum.nl \
    --cc=jeroen@myspectrum.nl \
    --cc=jhofstee@victronenergy.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox