[PATCH] qemu: Avoid accidental librdmacm linkage

[PATCH] qemu: Avoid accidental librdmacm linkage

[Richard Purdie]

Avoid accidentally linking to the rdma library from the host by
adding a PACKAGECONFIG for the option. This was found on new
Fedora 36 autobuilder workers.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
 meta/recipes-devtools/qemu/qemu.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
index ef4e949805b..e9095fd750f 100644
--- a/meta/recipes-devtools/qemu/qemu.inc
+++ b/meta/recipes-devtools/qemu/qemu.inc
@@ -186,6 +186,7 @@ PACKAGECONFIG[pulsedio] = "--enable-pa,--disable-pa,pulseaudio"
 PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux"
 PACKAGECONFIG[bpf] = "--enable-bpf,--disable-bpf,libbpf"
 PACKAGECONFIG[capstone] = "--enable-capstone,--disable-capstone"
+PACKAGECONFIG[rdma] = "--enable-dma,--disable-rdma"
 
 INSANE_SKIP:${PN} = "arch"
 
-- 
2.34.1

RE: [OE-core] [PATCH] qemu: Avoid accidental librdmacm linkage

[Peter Kjellerstedt]

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-
> core@lists.openembedded.org> On Behalf Of Richard Purdie
> Sent: den 11 juli 2022 14:24
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH] qemu: Avoid accidental librdmacm linkage
> 
> Avoid accidentally linking to the rdma library from the host by
> adding a PACKAGECONFIG for the option. This was found on new
> Fedora 36 autobuilder workers.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-devtools/qemu/qemu.inc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-
> devtools/qemu/qemu.inc
> index ef4e949805b..e9095fd750f 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -186,6 +186,7 @@ PACKAGECONFIG[pulsedio] = "--enable-pa,--disable-
> pa,pulseaudio"
>  PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux"
>  PACKAGECONFIG[bpf] = "--enable-bpf,--disable-bpf,libbpf"
>  PACKAGECONFIG[capstone] = "--enable-capstone,--disable-capstone"
> +PACKAGECONFIG[rdma] = "--enable-dma,--disable-rdma"

Shouldn't that be "--enable-rdma"?

> 
>  INSANE_SKIP:${PN} = "arch"
> 
> --
> 2.34.1

//Peter

Re: [OE-core] [PATCH] qemu: Avoid accidental librdmacm linkage

[Khem Raj]

On 7/11/22 1:24 PM, Richard Purdie wrote:
> Avoid accidentally linking to the rdma library from the host by
> adding a PACKAGECONFIG for the option. This was found on new
> Fedora 36 autobuilder workers.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>   meta/recipes-devtools/qemu/qemu.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-devtools/qemu/qemu.inc
> index ef4e949805b..e9095fd750f 100644
> --- a/meta/recipes-devtools/qemu/qemu.inc
> +++ b/meta/recipes-devtools/qemu/qemu.inc
> @@ -186,6 +186,7 @@ PACKAGECONFIG[pulsedio] = "--enable-pa,--disable-pa,pulseaudio"
>   PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux"
>   PACKAGECONFIG[bpf] = "--enable-bpf,--disable-bpf,libbpf"
>   PACKAGECONFIG[capstone] = "--enable-capstone,--disable-capstone"
> +PACKAGECONFIG[rdma] = "--enable-dma,--disable-rdma"
                                    ^^

should this be rdma ?

>   
>   INSANE_SKIP:${PN} = "arch"
>   
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#167867): https://lists.openembedded.org/g/openembedded-core/message/167867
> Mute This Topic: https://lists.openembedded.org/mt/92308429/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

Re: [OE-core] [PATCH] qemu: Avoid accidental librdmacm linkage

[Richard Purdie]

On Mon, 2022-07-11 at 18:42 +0000, Peter Kjellerstedt wrote:
> > -----Original Message-----
> > From: openembedded-core@lists.openembedded.org <openembedded-
> > core@lists.openembedded.org> On Behalf Of Richard Purdie
> > Sent: den 11 juli 2022 14:24
> > To: openembedded-core@lists.openembedded.org
> > Subject: [OE-core] [PATCH] qemu: Avoid accidental librdmacm linkage
> > 
> > Avoid accidentally linking to the rdma library from the host by
> > adding a PACKAGECONFIG for the option. This was found on new
> > Fedora 36 autobuilder workers.
> > 
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/recipes-devtools/qemu/qemu.inc | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/meta/recipes-devtools/qemu/qemu.inc b/meta/recipes-
> > devtools/qemu/qemu.inc
> > index ef4e949805b..e9095fd750f 100644
> > --- a/meta/recipes-devtools/qemu/qemu.inc
> > +++ b/meta/recipes-devtools/qemu/qemu.inc
> > @@ -186,6 +186,7 @@ PACKAGECONFIG[pulsedio] = "--enable-pa,--
> > disable-
> > pa,pulseaudio"
> >  PACKAGECONFIG[selinux] = "--enable-selinux,--disable-selinux"
> >  PACKAGECONFIG[bpf] = "--enable-bpf,--disable-bpf,libbpf"
> >  PACKAGECONFIG[capstone] = "--enable-capstone,--disable-capstone"
> > +PACKAGECONFIG[rdma] = "--enable-dma,--disable-rdma"
> 
> Shouldn't that be "--enable-rdma"?

It should. I've tweaked the patch in master-next.

Cheers,

Richard