[PATCH] Add grep to RDEPENDS to avoid command failures.

[PATCH] Add grep to RDEPENDS to avoid command failures.

[Marc Ferland]

Fixes [YOCTO #1887]

Signed-off-by: Marc Ferland <ferlandm@sonatest.com>
---
 meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb
index a4ac230..5e09f7b 100644
--- a/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb
+++ b/meta/recipes-bsp/pm-utils/pm-utils_1.4.1.bb
@@ -1,12 +1,13 @@
 SECTION = "base"
 SUMMARY = "Utilities and scripts for power management"
-DESCRIPTION = "Simple shell command line toos to suspect and hibernate."
+DESCRIPTION = "Simple shell command line tools to suspend and hibernate."
 HOMEPAGE = "http://pm-utils.freedesktop.org/wiki/"
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f \
                     file://src/pm-pmu.c;beginline=1;endline=22;md5=3c1ddbc54e735fb4a0386e14c78a3147"
 
-PR = "r0"
+PR = "r1"
+RDEPENDS = "grep"
 
 SRC_URI = "http://pm-utils.freedesktop.org/releases/pm-utils-${PV}.tar.gz"
 
-- 
1.7.5.4

Re: [PATCH] Add grep to RDEPENDS to avoid command failures.

[Phil Blundell]

On Tue, 2012-01-10 at 15:22 -0500, Marc Ferland wrote:
> -PR = "r0"
> +PR = "r1"
> +RDEPENDS = "grep"

Do you not get a QA warning for that?  Usually it would be RDEPENDS_${PN}.

p.

Re: [PATCH] Add grep to RDEPENDS to avoid command failures.

[Marc Ferland]

Phil Blundell <philb@gnu.org> writes:

> On Tue, 2012-01-10 at 15:22 -0500, Marc Ferland wrote:
>> -PR = "r0"
>> +PR = "r1"
>> +RDEPENDS = "grep"
>
> Do you not get a QA warning for that?  Usually it would be RDEPENDS_${PN}.
>
Nope. Everything looks fine. Whant me to resubmit the patch with
RDEPENDS_${PN}?

BTW I'm using yocto, if that makes a difference.

Marc

Re: [PATCH] Add grep to RDEPENDS to avoid command failures.

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 372 bytes --]

On Tue, Jan 10, 2012 at 18:22, Marc Ferland <ferlandm@sonatest.com> wrote:

> ...

+PR = "r1"
> +RDEPENDS = "grep"
>

Busybox ought to provide it; what is missing?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[-- Attachment #2: Type: text/html, Size: 953 bytes --]

Re: [PATCH] Add grep to RDEPENDS to avoid command failures.

[Marc Ferland]

Otavio Salvador <otavio@ossystems.com.br> writes:

> [1:multipart/alternative Hide]
> [1/1:text/plain Hide]
> On Tue, Jan 10, 2012 at 18:22, Marc Ferland <ferlandm@sonatest.com> wrote:
>
>> ...
>
> +PR = "r1"
>> +RDEPENDS = "grep"
>>
>
> Busybox ought to provide it; what is missing?

I was having trouble running the pm-suspend command. See:
http://bugzilla.pokylinux.org/show_bug.cgi?id=1887

Basically the '-x' option is missing from busybox's grep.

Re: [PATCH] Add grep to RDEPENDS to avoid command failures.

[Otavio Salvador]

[-- Attachment #1: Type: text/plain, Size: 570 bytes --]

On Tue, Jan 10, 2012 at 19:14, Marc Ferland <ferlandm@sonatest.com> wrote:

> I was having trouble running the pm-suspend command. See:
> http://bugzilla.pokylinux.org/show_bug.cgi?id=1887
>
> Basically the '-x' option is missing from busybox's grep.


Can't pm-suspend be patched to avoid using the -x option? Maybe making the
regexp more strict, for example?

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

[-- Attachment #2: Type: text/html, Size: 1119 bytes --]

Re: [PATCH] Add grep to RDEPENDS to avoid command failures.

[Marc Ferland]

Otavio Salvador <otavio@ossystems.com.br> writes:

> [1:multipart/alternative Hide]
> [1/1:text/plain Hide]
> On Tue, Jan 10, 2012 at 19:14, Marc Ferland <ferlandm@sonatest.com> wrote:
>
>> I was having trouble running the pm-suspend command. See:
>> http://bugzilla.pokylinux.org/show_bug.cgi?id=1887
>>
>> Basically the '-x' option is missing from busybox's grep.
>
>
> Can't pm-suspend be patched to avoid using the -x option? Maybe making the
> regexp more strict, for example?

Looks like it uses grep to ignore some parameters that are specified in
a separate file. A combination of 'sort' and 'uniq' would probably work,
but we would loose the order of the parameters.

Any idea?
Marc