Re: [PATCH 4/4] busybox: Allow busybox-mdev to RPROVIDES hotplug

[Richard Tollerton <rich.tollerton@ni.com>]

Richard Purdie <richard.purdie@linuxfoundation.org> writes:

> On Mon, 2014-07-21 at 11:53 -0500, Ben Shelton wrote:
>> From: Richard Tollerton <rich.tollerton@ni.com>
>> 
>> This is for symmetry with udev which also RPROVIDES hotplug.
>> 
>> Signed-off-by: Richard Tollerton <rich.tollerton@ni.com>
>> Signed-off-by: Ben Shelton <ben.shelton@ni.com>
>> ---
>>  meta/recipes-core/busybox/busybox.inc | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/meta/recipes-core/busybox/busybox.inc b/meta/recipes-core/busybox/busybox.inc
>> index bd66e4f..b4b9684 100644
>> --- a/meta/recipes-core/busybox/busybox.inc
>> +++ b/meta/recipes-core/busybox/busybox.inc
>> @@ -42,6 +42,7 @@ SYSTEMD_SERVICE_${PN}-syslog = "busybox-syslog.service"
>>  
>>  CONFFILES_${PN}-syslog = "${sysconfdir}/syslog-startup.conf.${BPN}"
>>  CONFFILES_${PN}-mdev = "${sysconfdir}/mdev.conf"
>> +RPROVIDES_${PN}-mdev = "hotplug"
>>  
>>  RRECOMMENDS_${PN} = "${PN}-syslog ${PN}-udhcpc"
>
> Why add this? I'm curious what would actually use that naming?
>
> The RPROVIDES in udev was for backwards compatibility when hotplug
> actually existed iirc, its long since dead?

Sorry, this was a mild case of cargo cult programming on my part. I saw
the RPROVIDES in the udev recipe, and while I couldn't find it ever
being used, I couldn't preclude the possibility that some other layer
somebody else would use might depend on it.

I agree that AFAIK, this code is dead, and the patch can be dropped.

> Cheers,
>
> Richard

-- 
Richard Tollerton <rich.tollerton@ni.com>