public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH v2] kernel.bbclass: fix emit_depmod_pkgdata() workdir
@ 2016-08-11  9:39 Ioan-Adrian Ratiu
  2016-08-11 10:20 ` Burton, Ross
  0 siblings, 1 reply; 4+ messages in thread
From: Ioan-Adrian Ratiu @ 2016-08-11  9:39 UTC (permalink / raw)
  To: ross.burton, openembedded-core

bitbake commit 67a7b8b02 "build: don't use $B as the default cwd for
functions" breaks the assumption that this function is running under
${B}. This causes build failures because System.map is under ${B}.
Fix this by using an absolute path instead of relying on cwd.

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
 meta/classes/kernel.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 062a0df..f3e1bee 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -359,7 +359,7 @@ emit_depmod_pkgdata() {
 	# Stash data for depmod
 	install -d ${PKGDESTWORK}/${KERNEL_PACKAGE_NAME}-depmod/
 	echo "${KERNEL_VERSION}" > ${PKGDESTWORK}/${KERNEL_PACKAGE_NAME}-depmod/${KERNEL_PACKAGE_NAME}-abiversion
-	cp System.map ${PKGDESTWORK}/${KERNEL_PACKAGE_NAME}-depmod/System.map-${KERNEL_VERSION}
+	cp ${B}/System.map ${PKGDESTWORK}/${KERNEL_PACKAGE_NAME}-depmod/System.map-${KERNEL_VERSION}
 }
 
 PACKAGEFUNCS += "emit_depmod_pkgdata"
-- 
2.9.2



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] kernel.bbclass: fix emit_depmod_pkgdata() workdir
  2016-08-11  9:39 [PATCH v2] kernel.bbclass: fix emit_depmod_pkgdata() workdir Ioan-Adrian Ratiu
@ 2016-08-11 10:20 ` Burton, Ross
  2016-08-11 10:49   ` Ioan-Adrian Ratiu
  0 siblings, 1 reply; 4+ messages in thread
From: Burton, Ross @ 2016-08-11 10:20 UTC (permalink / raw)
  To: Ioan-Adrian Ratiu; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On 11 August 2016 at 10:39, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:

> bitbake commit 67a7b8b02 "build: don't use $B as the default cwd for
> functions" breaks the assumption that this function is running under
> ${B}. This causes build failures because System.map is under ${B}.
> Fix this by using an absolute path instead of relying on cwd.
>

This failed to apply and I noticed that I fixed this myself in July...

Ross

[-- Attachment #2: Type: text/html, Size: 835 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] kernel.bbclass: fix emit_depmod_pkgdata() workdir
  2016-08-11 10:20 ` Burton, Ross
@ 2016-08-11 10:49   ` Ioan-Adrian Ratiu
  2016-08-11 11:26     ` Ioan-Adrian Ratiu
  0 siblings, 1 reply; 4+ messages in thread
From: Ioan-Adrian Ratiu @ 2016-08-11 10:49 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Thu, 11 Aug 2016, "Burton, Ross" <ross.burton@intel.com> wrote:
> On 11 August 2016 at 10:39, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>
>> bitbake commit 67a7b8b02 "build: don't use $B as the default cwd for
>> functions" breaks the assumption that this function is running under
>> ${B}. This causes build failures because System.map is under ${B}.
>> Fix this by using an absolute path instead of relying on cwd.
>>
>
> This failed to apply and I noticed that I fixed this myself in July...

What commit id is the fix on the master branch? I can't find it..

>
> Ross


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v2] kernel.bbclass: fix emit_depmod_pkgdata() workdir
  2016-08-11 10:49   ` Ioan-Adrian Ratiu
@ 2016-08-11 11:26     ` Ioan-Adrian Ratiu
  0 siblings, 0 replies; 4+ messages in thread
From: Ioan-Adrian Ratiu @ 2016-08-11 11:26 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Thu, 11 Aug 2016, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
> On Thu, 11 Aug 2016, "Burton, Ross" <ross.burton@intel.com> wrote:
>> On 11 August 2016 at 10:39, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>>
>>> bitbake commit 67a7b8b02 "build: don't use $B as the default cwd for
>>> functions" breaks the assumption that this function is running under
>>> ${B}. This causes build failures because System.map is under ${B}.
>>> Fix this by using an absolute path instead of relying on cwd.
>>>
>>
>> This failed to apply and I noticed that I fixed this myself in July...
>
> What commit id is the fix on the master branch? I can't find it..
>

I managed to find it d596286bc4cf1977 thanks!

>>
>> Ross
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-08-11 11:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-11  9:39 [PATCH v2] kernel.bbclass: fix emit_depmod_pkgdata() workdir Ioan-Adrian Ratiu
2016-08-11 10:20 ` Burton, Ross
2016-08-11 10:49   ` Ioan-Adrian Ratiu
2016-08-11 11:26     ` Ioan-Adrian Ratiu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox