[PATCH] lsb: fix usrmerge install path & QA warning

[PATCH] lsb: fix usrmerge install path & QA warning

[Ioan-Adrian Ratiu]

${base_prefix} is set in bitbake.conf to empty. This makes lsb_release
always install under /bin which is a problem if usrmerge is in
DISTRO_FEATURES, because it needs to be installed under /usr/bin.

By using ${base_bindir} instead, we fix the usrmerge install path and
the following QA warning goes away.

WARNING: lsb-5.0-r0 do_package: QA Issue: lsb: Files/directories were
installed but not shipped in any package:
  /bin
  /bin/lsb_release
Please set FILES such that these items are packaged. Alternatively
if they are unneeded, avoid installing them or delete them within do_install.
lsb: 2 installed and not shipped files. [installed-vs-shipped]

Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
---
 meta/recipes-extended/lsb/lsb_5.0.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/lsb/lsb_5.0.bb b/meta/recipes-extended/lsb/lsb_5.0.bb
index 746204b6ec..1657ba6f78 100644
--- a/meta/recipes-extended/lsb/lsb_5.0.bb
+++ b/meta/recipes-extended/lsb/lsb_5.0.bb
@@ -33,7 +33,7 @@ S = "${WORKDIR}/lsb-release-1.4"
 CLEANBROKEN = "1"
 
 do_install() {
-	oe_runmake install prefix=${D}${base_prefix} mandir=${D}${datadir}/man/ DESTDIR=${D}
+	oe_runmake install prefix=${D}${base_bindir} mandir=${D}${datadir}/man/ DESTDIR=${D}
 
 	# these two dirs are needed by package lsb-dist-checker
 	mkdir -p ${D}${sysconfdir}/opt
-- 
2.18.0

Re: [PATCH] lsb: fix usrmerge install path & QA warning

[Burton, Ross]

Remember to check what happens without usrmerge:

packages/corei7-64-poky-linux/lsb/lsb: FILELIST: directory renamed
/bin -> /bin/bin, changed order

lsb:
/bin/bin/lsb_release

Ross

On 19 July 2018 at 14:41, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
> ${base_prefix} is set in bitbake.conf to empty. This makes lsb_release
> always install under /bin which is a problem if usrmerge is in
> DISTRO_FEATURES, because it needs to be installed under /usr/bin.
>
> By using ${base_bindir} instead, we fix the usrmerge install path and
> the following QA warning goes away.
>
> WARNING: lsb-5.0-r0 do_package: QA Issue: lsb: Files/directories were
> installed but not shipped in any package:
>   /bin
>   /bin/lsb_release
> Please set FILES such that these items are packaged. Alternatively
> if they are unneeded, avoid installing them or delete them within do_install.
> lsb: 2 installed and not shipped files. [installed-vs-shipped]
>
> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
> ---
>  meta/recipes-extended/lsb/lsb_5.0.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/lsb/lsb_5.0.bb b/meta/recipes-extended/lsb/lsb_5.0.bb
> index 746204b6ec..1657ba6f78 100644
> --- a/meta/recipes-extended/lsb/lsb_5.0.bb
> +++ b/meta/recipes-extended/lsb/lsb_5.0.bb
> @@ -33,7 +33,7 @@ S = "${WORKDIR}/lsb-release-1.4"
>  CLEANBROKEN = "1"
>
>  do_install() {
> -       oe_runmake install prefix=${D}${base_prefix} mandir=${D}${datadir}/man/ DESTDIR=${D}
> +       oe_runmake install prefix=${D}${base_bindir} mandir=${D}${datadir}/man/ DESTDIR=${D}
>
>         # these two dirs are needed by package lsb-dist-checker
>         mkdir -p ${D}${sysconfdir}/opt
> --
> 2.18.0
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [PATCH] lsb: fix usrmerge install path & QA warning

[Ioan-Adrian Ratiu]

On Fri, 20 Jul 2018, "Burton, Ross" <ross.burton@intel.com> wrote:
> Remember to check what happens without usrmerge:
>
> packages/corei7-64-poky-linux/lsb/lsb: FILELIST: directory renamed
> /bin -> /bin/bin, changed order
>
> lsb:
> /bin/bin/lsb_release

Sorry about that and thanks! I'll send v2 where I'll use ${root_prefix}
which takes into account the presence of usrmerge.

>
> Ross
>
> On 19 July 2018 at 14:41, Ioan-Adrian Ratiu <adrian.ratiu@ni.com> wrote:
>> ${base_prefix} is set in bitbake.conf to empty. This makes lsb_release
>> always install under /bin which is a problem if usrmerge is in
>> DISTRO_FEATURES, because it needs to be installed under /usr/bin.
>>
>> By using ${base_bindir} instead, we fix the usrmerge install path and
>> the following QA warning goes away.
>>
>> WARNING: lsb-5.0-r0 do_package: QA Issue: lsb: Files/directories were
>> installed but not shipped in any package:
>>   /bin
>>   /bin/lsb_release
>> Please set FILES such that these items are packaged. Alternatively
>> if they are unneeded, avoid installing them or delete them within do_install.
>> lsb: 2 installed and not shipped files. [installed-vs-shipped]
>>
>> Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
>> ---
>>  meta/recipes-extended/lsb/lsb_5.0.bb | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-extended/lsb/lsb_5.0.bb b/meta/recipes-extended/lsb/lsb_5.0.bb
>> index 746204b6ec..1657ba6f78 100644
>> --- a/meta/recipes-extended/lsb/lsb_5.0.bb
>> +++ b/meta/recipes-extended/lsb/lsb_5.0.bb
>> @@ -33,7 +33,7 @@ S = "${WORKDIR}/lsb-release-1.4"
>>  CLEANBROKEN = "1"
>>
>>  do_install() {
>> -       oe_runmake install prefix=${D}${base_prefix} mandir=${D}${datadir}/man/ DESTDIR=${D}
>> +       oe_runmake install prefix=${D}${base_bindir} mandir=${D}${datadir}/man/ DESTDIR=${D}
>>
>>         # these two dirs are needed by package lsb-dist-checker
>>         mkdir -p ${D}${sysconfdir}/opt
>> --
>> 2.18.0
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core