From: Khem Raj <raj.khem@gmail.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 09/13] icu: update to 58.1
Date: Wed, 2 Nov 2016 10:22:01 -0700 [thread overview]
Message-ID: <CD9B1D56-5BF3-4334-B0E7-B07BA2F4061F@gmail.com> (raw)
In-Reply-To: <CAJTo0Laf3ZkyWqz2qY8Evj2R3OB1swBzfWeAZ9D+y3hFXjSecg@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1890 bytes --]
> On Nov 2, 2016, at 5:16 AM, Burton, Ross <ross.burton@intel.com> wrote:
>
>
> On 1 November 2016 at 15:25, Alexander Kanavin <alexander.kanavin@linux.intel.com <mailto:alexander.kanavin@linux.intel.com>> wrote:
> The copyright for the software has been transferred to Unicode Inc from IBM,
> but the terms are same.
>
> libiculx and libicule are no longer produced as they depend on an external
> package icu-le-hb (previous versions had an option of using an internal
> implementation which now has been dropped). I have verified that icu
> dependencies in oe-core and meta-oe still build.
>
> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com <mailto:alexander.kanavin@linux.intel.com>>
>
> This breaks under musl:
>
> ../../icu/source/i18n/digitlst.cpp:67:24: fatal error: xlocale.h: No such file or directory
> # include <xlocale.h>
>
> musl doesn't have xlocale.h but does have a crippled strtod_l (doesn't actually support a passed in locale, which is the entire point of the _l functions).
>
> Upstreams such as pulseaudio have done https://bugs.freedesktop.org/attachment.cgi?id=118644 <https://bugs.freedesktop.org/attachment.cgi?id=118644> to guard the include, but I see that digitlist.cpp has an alternative branch where strtod_l isn't supported: as that function on musl is crippled maybe ICU should be told not to use it?
the _l functions were added as aliases for ABI compatibility reasons, however, it should work well and is compatible with glibc versions. however its not defined that
it should only come from xlocale.h so we should check for xlocale.h to be present on rootfs before using it.
>
> Ross
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
[-- Attachment #1.2: Type: text/html, Size: 3392 bytes --]
[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]
next prev parent reply other threads:[~2016-11-02 17:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-01 15:25 [PATCH 00/13] Version updates, and various fixes Alexander Kanavin
2016-11-01 15:25 ` [PATCH 01/13] btrfs-tools: update to 4.8.2 Alexander Kanavin
2016-11-01 15:25 ` [PATCH 02/13] ffmpeg: update to 3.2 Alexander Kanavin
2016-11-01 15:25 ` [PATCH 03/13] gnome-desktop3: fix dependencies Alexander Kanavin
2016-11-01 15:25 ` [PATCH 04/13] nspr: update to 4.13.1 Alexander Kanavin
2016-11-01 15:25 ` [PATCH 05/13] vala: update to 0.34.2 Alexander Kanavin
2016-11-01 15:25 ` [PATCH 06/13] webkitgtk: remove lib_package inherit as executables are now installed in libexecdir Alexander Kanavin
2016-11-01 15:25 ` [PATCH 07/13] epiphany: remove unnecessary libwnck3 dependency Alexander Kanavin
2016-11-01 15:25 ` [PATCH 08/13] libwnck3: remove the recipe Alexander Kanavin
2016-11-01 15:25 ` [PATCH 09/13] icu: update to 58.1 Alexander Kanavin
2016-11-02 12:16 ` Burton, Ross
2016-11-02 17:22 ` Khem Raj [this message]
2016-11-02 17:38 ` Burton, Ross
2016-11-08 14:48 ` Alexander Kanavin
2016-11-01 15:25 ` [PATCH 10/13] libarchive: update to 3.2.2 Alexander Kanavin
2016-11-01 15:25 ` [PATCH 11/13] valgrind: update to 3.12.0 Alexander Kanavin
2016-11-01 15:25 ` [PATCH 12/13] rt-tests: fix the recipe version to match upstream Alexander Kanavin
2016-11-01 15:25 ` [PATCH 13/13] boost: fix upstream version check Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CD9B1D56-5BF3-4334-B0E7-B07BA2F4061F@gmail.com \
--to=raj.khem@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox