Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides

["Hart, Darren" <darren.hart@intel.com>]

On 4/11/14, 10:05, "Kamble, Nitin A" <nitin.a.kamble@intel.com> wrote:

>From: Nitin A Kamble <nitin.a.kamble@intel.com>
>
>Use machine overrides for variables for this skeleton recipe so that
>people following skeleton do it right at the beginning.
>
>The machine overrides for the variables reduces pollution of name space
>and avoid unintentional influences on other layers.
>
>Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>---
> meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>index c329106..76457ca 100644
>--- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>+++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>@@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
> 
> # Override SRC_URI in a bbappend file to point at a different source
> # tree if you do not want to build from Linus' tree.
>-SRC_URI = 
>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol
>=git;nocheckout=1;name=machine"
>+SRC_URI_machine =
>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protocol
>=git;nocheckout=1;name=machine"
> 
>-LINUX_VERSION ?= "3.4"
>-LINUX_VERSION_EXTENSION ?= "-custom"
>+LINUX_VERSION_machine ?= "3.4"
>+LINUX_VERSION_EXTENSION_machine ?= "-custom"
> 
> # Override SRCREV to point to a different commit in a bbappend file to
> # build a different release of the Linux kernel.
>@@ -61,4 +61,4 @@ PV = "${LINUX_VERSION}+git${SRCPV}"
> 
> # Override COMPATIBLE_MACHINE to include your machine in a bbappend
> # file. Leaving it empty here ensures an early explicit build failure.
>-COMPATIBLE_MACHINE = "(^$)"
>+COMPATIBLE_MACHINE_machine = "(^$)"


Might as well change this to:

COMPATIBLE_MACHINE_machine = "machine"

And then add a comment at the top to remind people to replace "machine"
with their BSP name.

-- 
Darren Hart					Open Source Technology Center
darren.hart@intel.com				            Intel Corporation