Re: [PATCH 1/1] meta-skeleton: linux-yocto-custom.bb: use machine overrides

["Hart, Darren" <darren.hart@intel.com>]

On 4/15/14, 9:54, "Paul Eggleton" <paul.eggleton@linux.intel.com> wrote:

>On Friday 11 April 2014 10:53:17 Kamble, Nitin A wrote:
>> On 4/11/2014 10:48 AM, Bruce Ashfield wrote:
>> > On 14-04-11 01:05 PM, nitin.a.kamble@intel.com wrote:
>> >> From: Nitin A Kamble <nitin.a.kamble@intel.com>
>> >> 
>> >> Use machine overrides for variables for this skeleton recipe so that
>> >> people following skeleton do it right at the beginning.
>> >> 
>> >> The machine overrides for the variables reduces pollution of name
>>space
>> >> and avoid unintentional influences on other layers.
>> >> 
>> >> Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
>> >> ---
>> >> 
>> >>   meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb | 8
>>++++----
>> >>   1 file changed, 4 insertions(+), 4 deletions(-)
>> >> 
>> >> diff --git a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> index c329106..76457ca 100644
>> >> --- a/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> +++ b/meta-skeleton/recipes-kernel/linux/linux-yocto-custom.bb
>> >> @@ -46,10 +46,10 @@ require recipes-kernel/linux/linux-yocto.inc
>> >> 
>> >>   # Override SRC_URI in a bbappend file to point at a different
>>source
>> >>   # tree if you do not want to build from Linus' tree.
>> >> 
>> >> -SRC_URI =
>> >> 
>>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
>> >> l=git;nocheckout=1;name=machine" +SRC_URI_machine =
>> >> 
>>"git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git;protoco
>> >> l=git;nocheckout=1;name=machine"
>> >> 
>> >> -LINUX_VERSION ?= "3.4"
>> >> -LINUX_VERSION_EXTENSION ?= "-custom"
>> >> +LINUX_VERSION_machine ?= "3.4"
>> >> +LINUX_VERSION_EXTENSION_machine ?= "-custom"
>> > 
>> > For some reason, I thought you meant ${MACHINE} instead of _machine ..
>> > which is what I use for machine specific overrides.
>> 
>> I think macros can not used as overrides.
>
>Variable references can be used in overrides, provided the expansion
>happens 
>at the right time. However, it would not be appropriate to use ${MACHINE}
>here 
>because if it were used verbatim in the recipe, it would not have the
>desired 
>effect - the value of ${MACHINE} would change with whatever MACHINE was
>set to, 
>and since ${MACHINE} is always in OVERRIDES it would always be applied.
>
>Cheers,
>Paul
>
>-- 
>
>Paul Eggleton
>Intel Open Source Technology Centre
>

I think we should just drop the overrides. The overrides are needed with
linux-yocto bbappends so we don't pollute the namespace, but here there is
nothing to polute. This is the only recipe, you don't use bbappends with
it. It needs some documentation, but we should just drop all the overrides
in this recipe.

-- 
Darren Hart					Open Source Technology Center
darren.hart@intel.com				            Intel Corporation