Re: [OE-core] [PATCH] oeqa selftest: read qemu options from TEST_RUNQEMUPARAMS

["Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>]

On Tue Apr 22, 2025 at 4:41 PM CEST, Mikko Rapeli via lists.openembedded.org wrote:
> To support "slirp" userspace networking which works more easily
> on various build machines, also without root and sudo rights
> to setup loop interfaces.
>
> Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> ---

Hi Mikko,

Thanks for your patch.

> diff --git a/meta/lib/oeqa/selftest/cases/uboot.py b/meta/lib/oeqa/selftest/cases/uboot.py
> index 96da4efb06..de082fe266 100644
> --- a/meta/lib/oeqa/selftest/cases/uboot.py
> +++ b/meta/lib/oeqa/selftest/cases/uboot.py
> @@ -33,7 +33,8 @@ QEMU_USE_KVM = "False"
>  """)
>          bitbake("virtual/bootloader core-image-minimal")
>  
> -        with runqemu('core-image-minimal', ssh=False, runqemuparams='nographic',
> +        runqemu_params = get_bb_var('TEST_RUNQEMUPARAMS', "core-image-minimal") or ""

I believe you forgot to add import for get_bb_var:

2025-04-23 06:21:37,461 - oe-selftest - INFO - 0: 43/44 533/625 (104.54s) (0 failed) (uboot.UBootTest.test_boot_uboot)
2025-04-23 06:21:37,467 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/meta/lib/oeqa/selftest/cases/uboot.py", line 36, in test_boot_uboot
    runqemu_params = get_bb_var('TEST_RUNQEMUPARAMS', "core-image-minimal") or ""
                     ^^^^^^^^^^
NameError: name 'get_bb_var' is not defined

https://autobuilder.yoctoproject.org/valkyrie/#/builders/23/builds/1491

> +        with runqemu('core-image-minimal', ssh=False, runqemuparams='nographic %s' % runqemu_params,
>                       boot_patterns=uboot_boot_patterns) as qemu:
>  
>              # test if u-boot console works


-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com