Re: [OE-core] [PATCH] oeqa selftest: read qemu options from TEST_RUNQEMUPARAMS

[Mikko Rapeli <mikko.rapeli@linaro.org>]

Hi,

On Wed, Apr 23, 2025 at 10:20:59AM +0200, Mathieu Dubois-Briand wrote:
> On Tue Apr 22, 2025 at 4:41 PM CEST, Mikko Rapeli via lists.openembedded.org wrote:
> > To support "slirp" userspace networking which works more easily
> > on various build machines, also without root and sudo rights
> > to setup loop interfaces.
> >
> > Signed-off-by: Mikko Rapeli <mikko.rapeli@linaro.org>
> > ---
> 
> Hi Mikko,
> 
> Thanks for your patch.
> 
> > diff --git a/meta/lib/oeqa/selftest/cases/uboot.py b/meta/lib/oeqa/selftest/cases/uboot.py
> > index 96da4efb06..de082fe266 100644
> > --- a/meta/lib/oeqa/selftest/cases/uboot.py
> > +++ b/meta/lib/oeqa/selftest/cases/uboot.py
> > @@ -33,7 +33,8 @@ QEMU_USE_KVM = "False"
> >  """)
> >          bitbake("virtual/bootloader core-image-minimal")
> >  
> > -        with runqemu('core-image-minimal', ssh=False, runqemuparams='nographic',
> > +        runqemu_params = get_bb_var('TEST_RUNQEMUPARAMS', "core-image-minimal") or ""
> 
> I believe you forgot to add import for get_bb_var:

Yes, that has gone missing somewhere (git stash save?). I'll add in v2.

Cheers,

-Mikko