Re: [OE-core] [PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

Re: [OE-core] [PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

[Alexander Kanavin]

On Mon, 16 Jun 2025 at 13:56, Jimmy Ho via lists.openembedded.org
<jimmy.ho=sifive.com@lists.openembedded.org> wrote:
>  nfsrootfs_enabled() {
> -       if [ ${bootparam_root} != "/dev/nfs" ] || [ -z ${bootparam_nfsroot} ]; then
> +       if [ -z ${bootparam_root} ] || [ ${bootparam_root} != "/dev/nfs" ] || [ -z ${bootparam_nfsroot} ]; then
>                 return 1
>         fi
>         return 0

This needs a bit more explanation. What is the warning message, why
does it need to be disabled, and how does the above change achieve it?

Alex

Re: [OE-core] [PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

[Jimmy Ho]

[-- Attachment #1: Type: text/plain, Size: 977 bytes --]

hi Alexander:
in one of our use case, we don't define root in bootargs,
if [ ${bootparam_root} != "/dev/nfs" ] will output /init.d/85-nfsrootfs:
line 4: [: !=: unary operator expected
by checking   if [-z ${bootparam_root} ] can clear this warning message
thanks
best regards
jimmy ho

On Mon, Jun 16, 2025 at 9:52 PM Alexander Kanavin <alex.kanavin@gmail.com>
wrote:

> On Mon, 16 Jun 2025 at 13:56, Jimmy Ho via lists.openembedded.org
> <jimmy.ho=sifive.com@lists.openembedded.org> wrote:
> >  nfsrootfs_enabled() {
> > -       if [ ${bootparam_root} != "/dev/nfs" ] || [ -z
> ${bootparam_nfsroot} ]; then
> > +       if [ -z ${bootparam_root} ] || [ ${bootparam_root} != "/dev/nfs"
> ] || [ -z ${bootparam_nfsroot} ]; then
> >                 return 1
> >         fi
> >         return 0
>
> This needs a bit more explanation. What is the warning message, why
> does it need to be disabled, and how does the above change achieve it?
>
> Alex
>

[-- Attachment #2: Type: text/html, Size: 2046 bytes --]

Re: [OE-core] [PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

[Alexander Kanavin]

On Thu, 19 Jun 2025 at 08:12, Jimmy Ho <jimmy.ho@sifive.com> wrote:
>
> hi Alexander:
> in one of our use case, we don't define root in bootargs,
> if [ ${bootparam_root} != "/dev/nfs" ] will output /init.d/85-nfsrootfs: line 4: [: !=: unary operator expected
> by checking   if [-z ${bootparam_root} ] can clear this warning message

Thanks, makese sense. Can you resend the patch with this information
in the commit message?

Alex

[PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

[Jimmy Ho]

we have case that don't define root in bootargs,
if [ ${bootparam_root} != "/dev/nfs" ] will output warning "/init.d/85-nfsrootfs: line 4: [: !=: unary operator expected"
by checking  whether bootparam_root is defined can clear this warning message 

Signed-off-by: Jimmy Ho <jimmy.ho@sifive.com>
---
 meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs b/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
index e67ee4c25d..1e76258ce1 100644
--- a/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
+++ b/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
@@ -1,7 +1,7 @@
 #!/bin/sh
 
 nfsrootfs_enabled() {
-	if [ ${bootparam_root} != "/dev/nfs" ] || [ -z ${bootparam_nfsroot} ]; then
+	if [ -z ${bootparam_root} ] || [ ${bootparam_root} != "/dev/nfs" ] || [ -z ${bootparam_nfsroot} ]; then
 		return 1
 	fi
 	return 0
-- 
2.39.3

Re: [OE-core] [PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

[Antonin Godard]

On Thu Jun 19, 2025 at 10:29 AM CEST, Jimmy Ho via lists.openembedded.org wrote:
> we have case that don't define root in bootargs,
> if [ ${bootparam_root} != "/dev/nfs" ] will output warning "/init.d/85-nfsrootfs: line 4: [: !=: unary operator expected"
> by checking  whether bootparam_root is defined can clear this warning message 
>
> Signed-off-by: Jimmy Ho <jimmy.ho@sifive.com>
> ---
>  meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs b/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> index e67ee4c25d..1e76258ce1 100644
> --- a/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> +++ b/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> @@ -1,7 +1,7 @@
>  #!/bin/sh
>  
>  nfsrootfs_enabled() {
> -	if [ ${bootparam_root} != "/dev/nfs" ] || [ -z ${bootparam_nfsroot} ]; then
> +	if [ -z ${bootparam_root} ] || [ ${bootparam_root} != "/dev/nfs" ] || [ -z ${bootparam_nfsroot} ]; then

I think a better way of fixing this would be to replace

  [ ${bootparam_root} != "/dev/nfs" ]

by

  [ "${bootparam_root}" != "/dev/nfs" ]

instead of an extra condition.

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] nfsrootfs: disable warning message if bootargs root parameter have not been defined

[Jimmy Ho]

[-- Attachment #1: Type: text/plain, Size: 1640 bytes --]

Hi Antonin:
thanks for suggestion
i will resend the patch

On Thu, Jun 19, 2025 at 11:32 PM Antonin Godard <antonin.godard@bootlin.com>
wrote:

> On Thu Jun 19, 2025 at 10:29 AM CEST, Jimmy Ho via lists.openembedded.org
> wrote:
> > we have case that don't define root in bootargs,
> > if [ ${bootparam_root} != "/dev/nfs" ] will output warning
> "/init.d/85-nfsrootfs: line 4: [: !=: unary operator expected"
> > by checking  whether bootparam_root is defined can clear this warning
> message
> >
> > Signed-off-by: Jimmy Ho <jimmy.ho@sifive.com>
> > ---
> >  meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> b/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> > index e67ee4c25d..1e76258ce1 100644
> > --- a/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> > +++ b/meta/recipes-core/initrdscripts/initramfs-framework/nfsrootfs
> > @@ -1,7 +1,7 @@
> >  #!/bin/sh
> >
> >  nfsrootfs_enabled() {
> > -     if [ ${bootparam_root} != "/dev/nfs" ] || [ -z
> ${bootparam_nfsroot} ]; then
> > +     if [ -z ${bootparam_root} ] || [ ${bootparam_root} != "/dev/nfs" ]
> || [ -z ${bootparam_nfsroot} ]; then
>
> I think a better way of fixing this would be to replace
>
>   [ ${bootparam_root} != "/dev/nfs" ]
>
> by
>
>   [ "${bootparam_root}" != "/dev/nfs" ]
>
> instead of an extra condition.
>
> Antonin
>
> --
> Antonin Godard, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>

[-- Attachment #2: Type: text/html, Size: 2847 bytes --]