[PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Koen Kooi]

This recipe enabled an additional, non-standard policy for predictable
network names: the MAC policy. This is a deviation from upstream
policies and in cases where no MAC address is available, it makes it
actively worse by changing the name(s) every boot.

Change the logic to disable predictable naming when the DISTRO_FEATURE
isn't enabled and only use upstream logic with it *is* enabled.

For DISTROs that wish to use non-standard policies, a DISTRO layer is the correct place.
E.g. in DISTRO_LAYER/recipes-core/systemd/systemd_%.bbappend:

do_install:append:DISTRO() {
       if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then
               if ! grep -q '^NamePolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
                       sed -i '/^NamePolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
               fi
               if ! grep -q 'AlternativeNamesPolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
                       sed -i '/AlternativeNamesPolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
               fi
}

Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
---
 meta/recipes-core/systemd/systemd_257.8.bb | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/meta/recipes-core/systemd/systemd_257.8.bb b/meta/recipes-core/systemd/systemd_257.8.bb
index 174372be03..6399c57640 100644
--- a/meta/recipes-core/systemd/systemd_257.8.bb
+++ b/meta/recipes-core/systemd/systemd_257.8.bb
@@ -400,15 +400,8 @@ do_install() {
 			${D}/${sysconfdir}/systemd/system.conf
 	fi
 
-	if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then
-		if ! grep -q '^NamePolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
-			sed -i '/^NamePolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
-		fi
-		if ! grep -q 'AlternativeNamesPolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
-			sed -i '/AlternativeNamesPolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
-		fi
-	else
-		# Actively disable Predictable Network Interface Names
+	# Actively disable Predictable Network Interface Names
+	if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
 		sed -i 's/^NamePolicy=.*/NamePolicy=/;s/^AlternativeNamesPolicy=.*/AlternativeNamesPolicy=/' ${D}${nonarch_libdir}/systemd/network/99-default.link
 	fi
 }
-- 
2.34.1

Patchtest results for [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3261 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/systemd-stop-enabling-non-standard-MAC-policy-when-using-the-pni-names-DISTRO_FEATURE.patch

FAIL: test commit message user tags: Mbox includes one or more GitHub-style username tags. Ensure that any "@" symbols are stripped out of usernames (test_mbox.TestMbox.test_commit_message_user_tags)

PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Re: Patchtest results for [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Koen Kooi]

> Op 2 sep 2025, om 11:15 heeft patchtest@automation.yoctoproject.org het volgende geschreven:
> 
> Thank you for your submission. Patchtest identified one
> or more issues with the patch. Please see the log below for
> more information:
> 
> ---
> Testing patch /home/patchtest/share/mboxes/systemd-stop-enabling-non-standard-MAC-policy-when-using-the-pni-names-DISTRO_FEATURE.patch
> 
> FAIL: test commit message user tags: Mbox includes one or more GitHub-style username tags. Ensure that any "@" symbols are stripped out of usernames (test_mbox.TestMbox.test_commit_message_user_tags)
> 
> PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
> PASS: test author valid (test_mbox.TestMbox.test_author_valid)
> PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
> PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
> PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
> PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
> PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
> PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
> PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)
> 
> SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
> SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
> SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
> SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
> SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
> SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
> SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
> SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
> SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
> SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
> SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
> SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
> SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
> SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)
> 
> ---
> 
> Please address the issues identified and
> submit a new revision of the patch, or alternatively, reply to this
> email with an explanation of why the patch should be accepted.

Yeah, ' @bb.utils.contains' is not a github username, but valid usage of bitbake API


> If you
> believe these results are due to an error in patchtest, please submit a
> bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
> under 'Yocto Project Subprojects'). For more information on specific
> failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
> you!

Re: [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Ross Burton]

+1 from me, thanks Koen.

This will need documenting in the migration guide, copying Antonin.

Ross

> On 2 Sep 2025, at 10:09, Koen Kooi <koen.kooi@oss.qualcomm.com> wrote:
> 
> This recipe enabled an additional, non-standard policy for predictable
> network names: the MAC policy. This is a deviation from upstream
> policies and in cases where no MAC address is available, it makes it
> actively worse by changing the name(s) every boot.
> 
> Change the logic to disable predictable naming when the DISTRO_FEATURE
> isn't enabled and only use upstream logic with it *is* enabled.
> 
> For DISTROs that wish to use non-standard policies, a DISTRO layer is the correct place.
> E.g. in DISTRO_LAYER/recipes-core/systemd/systemd_%.bbappend:
> 
> do_install:append:DISTRO() {
>       if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then
>               if ! grep -q '^NamePolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
>                       sed -i '/^NamePolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
>               fi
>               if ! grep -q 'AlternativeNamesPolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
>                       sed -i '/AlternativeNamesPolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
>               fi
> }
> 
> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
> ---
> meta/recipes-core/systemd/systemd_257.8.bb | 11 ++---------
> 1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/meta/recipes-core/systemd/systemd_257.8.bb b/meta/recipes-core/systemd/systemd_257.8.bb
> index 174372be03..6399c57640 100644
> --- a/meta/recipes-core/systemd/systemd_257.8.bb
> +++ b/meta/recipes-core/systemd/systemd_257.8.bb
> @@ -400,15 +400,8 @@ do_install() {
> ${D}/${sysconfdir}/systemd/system.conf
> fi
> 
> - if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then
> - if ! grep -q '^NamePolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
> - sed -i '/^NamePolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
> - fi
> - if ! grep -q 'AlternativeNamesPolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
> - sed -i '/AlternativeNamesPolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
> - fi
> - else
> - # Actively disable Predictable Network Interface Names
> + # Actively disable Predictable Network Interface Names
> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
> sed -i 's/^NamePolicy=.*/NamePolicy=/;s/^AlternativeNamesPolicy=.*/AlternativeNamesPolicy=/' ${D}${nonarch_libdir}/systemd/network/99-default.link
> fi
> }
> -- 
> 2.34.1
> 

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Antonin Godard]

On Tue Sep 2, 2025 at 11:09 AM CEST, Koen Kooi via lists.openembedded.org wrote:
> This recipe enabled an additional, non-standard policy for predictable
> network names: the MAC policy. This is a deviation from upstream
> policies and in cases where no MAC address is available, it makes it
> actively worse by changing the name(s) every boot.
>
> Change the logic to disable predictable naming when the DISTRO_FEATURE
> isn't enabled and only use upstream logic with it *is* enabled.
>
> For DISTROs that wish to use non-standard policies, a DISTRO layer is the correct place.
> E.g. in DISTRO_LAYER/recipes-core/systemd/systemd_%.bbappend:
>
> do_install:append:DISTRO() {
>        if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then
>                if ! grep -q '^NamePolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
>                        sed -i '/^NamePolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
>                fi
>                if ! grep -q 'AlternativeNamesPolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
>                        sed -i '/AlternativeNamesPolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
>                fi
> }
>
> Signed-off-by: Koen Kooi <koen.kooi@oss.qualcomm.com>
> ---
>  meta/recipes-core/systemd/systemd_257.8.bb | 11 ++---------
>  1 file changed, 2 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-core/systemd/systemd_257.8.bb b/meta/recipes-core/systemd/systemd_257.8.bb
> index 174372be03..6399c57640 100644
> --- a/meta/recipes-core/systemd/systemd_257.8.bb
> +++ b/meta/recipes-core/systemd/systemd_257.8.bb
> @@ -400,15 +400,8 @@ do_install() {
>  			${D}/${sysconfdir}/systemd/system.conf
>  	fi
>  
> -	if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d)}; then
> -		if ! grep -q '^NamePolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
> -			sed -i '/^NamePolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
> -		fi
> -		if ! grep -q 'AlternativeNamesPolicy=.*mac' ${D}${nonarch_libdir}/systemd/network/99-default.link; then
> -			sed -i '/AlternativeNamesPolicy=/s/$/ mac/' ${D}${nonarch_libdir}/systemd/network/99-default.link
> -		fi
> -	else
> -		# Actively disable Predictable Network Interface Names
> +	# Actively disable Predictable Network Interface Names
> +	if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then

This could be simplified to 

if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then

no?

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Ross Burton]

On 5 Sep 2025, at 09:33, Antonin Godard <antonin.godard@bootlin.com> wrote:
>> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
> 
> This could be simplified to 
> 
> if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then
> 
> no?

I dislike contains() calls that return false,true because that subverts expectations, but this seems like a compromise to me:

  if not ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then

Ross

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Koen Kooi]

> Op 5 sep 2025, om 11:09 heeft Ross Burton <ross.burton@arm.com> het volgende geschreven:
> 
> On 5 Sep 2025, at 09:33, Antonin Godard <antonin.godard@bootlin.com> wrote:
>>> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
>> 
>> This could be simplified to 
>> 
>> if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then
>> 
>> no?
> 
> I dislike contains() calls that return false,true because that subverts expectations,

Same here, which is why I lifted this variant from an existing OE-core bbclass :) 

> but this seems like a compromise to me:
> 
>  if not ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then

I can rework it to that. If that works, a v2 will best sent!

regards,

Koen

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Koen Kooi]

> Op 5 sep 2025, om 14:02 heeft Koen Kooi via lists.openembedded.org <koen.kooi=oss.qualcomm.com@lists.openembedded.org> het volgende geschreven:
> 
> 
> 
>> Op 5 sep 2025, om 11:09 heeft Ross Burton <ross.burton@arm.com> het volgende geschreven:
>> 
>> On 5 Sep 2025, at 09:33, Antonin Godard <antonin.godard@bootlin.com> wrote:
>>>> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
>>> 
>>> This could be simplified to 
>>> 
>>> if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then
>>> 
>>> no?
>> 
>> I dislike contains() calls that return false,true because that subverts expectations,
> 
> Same here, which is why I lifted this variant from an existing OE-core bbclass :) 
> 
>> but this seems like a compromise to me:
>> 
>> if not ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then
> 
> I can rework it to that. If that works, a v2 will best sent!

So that *technically* works because 'not' is both not a bash builtin nor a command installed in the sysroot. This ends up giving us a 

not: not found 

in log.do_install. I don't think this is an improvement over the original patch. Thoughts?

regards,

Koen

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Antonin Godard]

On Fri Sep 5, 2025 at 3:09 PM CEST, Koen Kooi via lists.openembedded.org wrote:
>
>
>> Op 5 sep 2025, om 14:02 heeft Koen Kooi via lists.openembedded.org <koen.kooi=oss.qualcomm.com@lists.openembedded.org> het volgende geschreven:
>> 
>> 
>> 
>>> Op 5 sep 2025, om 11:09 heeft Ross Burton <ross.burton@arm.com> het volgende geschreven:
>>> 
>>> On 5 Sep 2025, at 09:33, Antonin Godard <antonin.godard@bootlin.com> wrote:
>>>>> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
>>>> 
>>>> This could be simplified to 
>>>> 
>>>> if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then
>>>> 
>>>> no?
>>> 
>>> I dislike contains() calls that return false,true because that subverts expectations,
>> 
>> Same here, which is why I lifted this variant from an existing OE-core bbclass :) 
>> 
>>> but this seems like a compromise to me:
>>> 
>>> if not ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then
>> 
>> I can rework it to that. If that works, a v2 will best sent!
>
> So that *technically* works because 'not' is both not a bash builtin nor a command installed in the sysroot. This ends up giving us a 
>
> not: not found 
>
> in log.do_install. I don't think this is an improvement over the original patch. Thoughts?

It should be 

if ! ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then

We mixed up python and shell syntax here :)

Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Ross Burton]

On 5 Sep 2025, at 14:15, Antonin Godard <antonin.godard@bootlin.com> wrote:
> 
> On Fri Sep 5, 2025 at 3:09 PM CEST, Koen Kooi via lists.openembedded.org wrote:
>> 
>> 
>>> Op 5 sep 2025, om 14:02 heeft Koen Kooi via lists.openembedded.org <koen.kooi=oss.qualcomm.com@lists.openembedded.org> het volgende geschreven:
>>> 
>>> 
>>> 
>>>> Op 5 sep 2025, om 11:09 heeft Ross Burton <ross.burton@arm.com> het volgende geschreven:
>>>> 
>>>> On 5 Sep 2025, at 09:33, Antonin Godard <antonin.godard@bootlin.com> wrote:
>>>>>> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
>>>>> 
>>>>> This could be simplified to 
>>>>> 
>>>>> if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then
>>>>> 
>>>>> no?
>>>> 
>>>> I dislike contains() calls that return false,true because that subverts expectations,
>>> 
>>> Same here, which is why I lifted this variant from an existing OE-core bbclass :) 
>>> 
>>>> but this seems like a compromise to me:
>>>> 
>>>> if not ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then
>>> 
>>> I can rework it to that. If that works, a v2 will best sent!
>> 
>> So that *technically* works because 'not' is both not a bash builtin nor a command installed in the sysroot. This ends up giving us a 
>> 
>> not: not found 
>> 
>> in log.do_install. I don't think this is an improvement over the original patch. Thoughts?
> 
> It should be 
> 
> if ! ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then
> 
> We mixed up python and shell syntax here :)

Yeah, sorry about that. I blame my codeine I’m currently on!

Ross

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Koen Kooi]

> Op 5 sep 2025, om 15:15 heeft Antonin Godard <antonin.godard@bootlin.com> het volgende geschreven:
> 
> On Fri Sep 5, 2025 at 3:09 PM CEST, Koen Kooi via lists.openembedded.org wrote:
>> 
>> 
>>> Op 5 sep 2025, om 14:02 heeft Koen Kooi via lists.openembedded.org <koen.kooi=oss.qualcomm.com@lists.openembedded.org> het volgende geschreven:
>>> 
>>> 
>>> 
>>>> Op 5 sep 2025, om 11:09 heeft Ross Burton <ross.burton@arm.com> het volgende geschreven:
>>>> 
>>>> On 5 Sep 2025, at 09:33, Antonin Godard <antonin.godard@bootlin.com> wrote:
>>>>>> + if ${@ 'true' if not bb.utils.contains('PACKAGECONFIG', 'pni-names', 'true', 'false', d) else 'false'}; then
>>>>> 
>>>>> This could be simplified to 
>>>>> 
>>>>> if ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', 'false', 'true', d)}; then
>>>>> 
>>>>> no?
>>>> 
>>>> I dislike contains() calls that return false,true because that subverts expectations,
>>> 
>>> Same here, which is why I lifted this variant from an existing OE-core bbclass :) 
>>> 
>>>> but this seems like a compromise to me:
>>>> 
>>>> if not ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then
>>> 
>>> I can rework it to that. If that works, a v2 will best sent!
>> 
>> So that *technically* works because 'not' is both not a bash builtin nor a command installed in the sysroot. This ends up giving us a 
>> 
>> not: not found 
>> 
>> in log.do_install. I don't think this is an improvement over the original patch. Thoughts?
> 
> It should be 
> 
> if ! ${@bb.utils.contains('PACKAGECONFIG', 'pni-names', ’true', ‘false', d)}; then
> 
> We mixed up python and shell syntax here :)

My original patch was applied, do you want a followup patch to switch to 'if !' or leave it as is?

regards,

Koen

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Ross Burton]

On 9 Sep 2025, at 10:40, Koen Kooi <koen.kooi@oss.qualcomm.com> wrote:
> My original patch was applied, do you want a followup patch to switch to 'if !' or leave it as is?

Personally I struggle to have a strong opinion either way, to be honest. Send one if you have a moment as it’s just neater but I’m not going to chase you down over it :)

Ross

Re: [OE-core] [PATCH] systemd: stop enabling non-standard MAC policy when using the 'pni-names' DISTRO_FEATURE

[Koen Kooi]

> Op 9 sep 2025, om 11:43 heeft Ross Burton via lists.openembedded.org <ross.burton=arm.com@lists.openembedded.org> het volgende geschreven:
> 
> On 9 Sep 2025, at 10:40, Koen Kooi <koen.kooi@oss.qualcomm.com> wrote:
>> My original patch was applied, do you want a followup patch to switch to 'if !' or leave it as is?
> 
> Personally I struggle to have a strong opinion either way, to be honest. Send one if you have a moment as it’s just neater but I’m not going to chase you down over it :)

No problem, patch incoming!

> 
> Ross
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#223096): https://lists.openembedded.org/g/openembedded-core/message/223096
> Mute This Topic: https://lists.openembedded.org/mt/115023020/9418801
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [koen.kooi@oss.qualcomm.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>