[PATCH] vulkan-samples: update to latest revision

[PATCH] vulkan-samples: update to latest revision

[Gyorgy Sarvari]

Dropped 0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch,
because the dependency it was patching (glslang submodule) has been
removed by the project, so it became obsolete.

Shortlog:
Unify vkb::PhysicalDevice and vkb::core::HPPPhysicalDevice into vkb::core::PhysicalDevice<bindingType>
Update Apple min deployment versions and iOS Simulator build config
Add example for dynamic_rendering_local_read
Add Slang and HLSL shaders to first set of samples
Fix use of --width and --height by setting extent earlier
Unify vkb::Instance and vkb::core::HPPInstance into vkb::core::Instance<bindingType>
Remove vkb::filesystem::init() from astc to fix memory leak and batch mode stability
Update VVL version to 1.4.321.0 for Android
Update NDK version to r28c for Android
Fix variable descriptor count info not used in descriptor set creation
Fix layer settings regression on Apple platforms for MoltenVK config
Update shader interfaces to match sample's vertex input description
Fix regression on iOS Simulator by including TargetConditionals.h in gui.h
Add CMAKE_OSX_DEPLOYMENT_TARGET to macOS build docs and CI script
Add possible Linux WSI options
Unify vkb::Gui and vkb::HPPGui into vkb::Gui<bindingType>
Remove submodule CTPL, replace its functionality by calls to std::async
fix: fix the surface resize logic when use wayland wsi
Implement simple cache for decoded ASTC textures
Unify vkb::Device and vkb::core::HPPDevice into vkb::core::Device<bindingType>
Port of latest changes in api sample hello_triangle to hpp_hello_triangle
Fix crash in sample on android
Improve and fix async compute sample
Fix MacOS cmake build instructions
Replace runtime shader compilation with offline compiled SPIR-V shaders
Transcoded version of api sample hello_triangle_1_3 based on Vulkan-Hpp
Unify vkb::RenderFrame and vkb::rendering::HPPRenderFrame into vkb::rendering::RenderFrame<bindingType>
Increase base version to Vulkan 1.1

Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
---
 ...uilder.h-add-missing-cstdint-include.patch | 28 -------------------
 .../vulkan/vulkan-samples_git.bb              |  6 ++--
 2 files changed, 2 insertions(+), 32 deletions(-)
 delete mode 100644 meta/recipes-graphics/vulkan/vulkan-samples/0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch

diff --git a/meta/recipes-graphics/vulkan/vulkan-samples/0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch b/meta/recipes-graphics/vulkan/vulkan-samples/0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch
deleted file mode 100644
index f50aa806da..0000000000
--- a/meta/recipes-graphics/vulkan/vulkan-samples/0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch
+++ /dev/null
@@ -1,28 +0,0 @@
-From e40c14a3e007fac0e4f2e4164fdf14d1712355bd Mon Sep 17 00:00:00 2001
-From: Sergei Trofimovich <slyich@gmail.com>
-Date: Fri, 2 Aug 2024 22:44:21 +0100
-Subject: [PATCH] SPIRV/SpvBuilder.h: add missing <cstdint> include
-
-Without the change `glslang` build fails on upcoming `gcc-15` as:
-
-    In file included from /build/source/SPIRV/GlslangToSpv.cpp:45:
-    SPIRV/SpvBuilder.h:248:30: error: 'uint32_t' has not been declared
-      248 |     Id makeDebugLexicalBlock(uint32_t line);
-          |                              ^~~~~~~~
-
-Upstream-Status: Backport [https://github.com/KhronosGroup/glslang/commit/e40c14a3e007fac0e4f2e4164fdf14d1712355bd]
-Signed-off-by: Khem Raj <raj.khem@gmail.com>
----
- SPIRV/SpvBuilder.h | 1 +
- 1 file changed, 1 insertion(+)
-
---- a/SPIRV/SpvBuilder.h
-+++ b/SPIRV/SpvBuilder.h
-@@ -56,6 +56,7 @@ namespace spv {
- }
- 
- #include <algorithm>
-+#include <cstdint>
- #include <map>
- #include <memory>
- #include <set>
diff --git a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
index b7c9ddd2fe..8011c3a81c 100644
--- a/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
+++ b/meta/recipes-graphics/vulkan/vulkan-samples_git.bb
@@ -5,12 +5,10 @@ LICENSE = "Apache-2.0"
 
 LIC_FILES_CHKSUM = "file://LICENSE;md5=48aa35cefb768436223a6e7f18dc2a2a"
 
-SRC_URI = "gitsm://github.com/KhronosGroup/Vulkan-Samples.git;branch=main;protocol=https;lfs=0 \
-           file://0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch;patchdir=third_party/glslang \
-           "
+SRC_URI = "gitsm://github.com/KhronosGroup/Vulkan-Samples.git;branch=main;protocol=https;lfs=0"
 
 UPSTREAM_CHECK_COMMITS = "1"
-SRCREV = "d27205d14d01ea7d33efc8ba2862478612370182"
+SRCREV = "b9961792604af2ede4c9d0868947de2a8eccd549"
 
 UPSTREAM_CHECK_GITTAGREGEX = "These are not the releases you're looking for"
 

Patchtest results for [PATCH] vulkan-samples: update to latest revision

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3003 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/vulkan-samples-update-to-latest-revision.patch

FAIL: test src uri left files: Patches not removed from tree. Remove them and amend the submitted mbox (test_metadata.TestMetadata.test_src_uri_left_files)

PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Re: [OE-core] [PATCH] vulkan-samples: update to latest revision

[Mathieu Dubois-Briand]

On Thu Sep 11, 2025 at 11:11 PM CEST, Gyorgy Sarvari via lists.openembedded.org wrote:
> Dropped 0001-SPIRV-SpvBuilder.h-add-missing-cstdint-include.patch,
> because the dependency it was patching (glslang submodule) has been
> removed by the project, so it became obsolete.
>
> Shortlog:
> Unify vkb::PhysicalDevice and vkb::core::HPPPhysicalDevice into vkb::core::PhysicalDevice<bindingType>
> Update Apple min deployment versions and iOS Simulator build config
> Add example for dynamic_rendering_local_read
> Add Slang and HLSL shaders to first set of samples
> Fix use of --width and --height by setting extent earlier
> Unify vkb::Instance and vkb::core::HPPInstance into vkb::core::Instance<bindingType>
> Remove vkb::filesystem::init() from astc to fix memory leak and batch mode stability
> Update VVL version to 1.4.321.0 for Android
> Update NDK version to r28c for Android
> Fix variable descriptor count info not used in descriptor set creation
> Fix layer settings regression on Apple platforms for MoltenVK config
> Update shader interfaces to match sample's vertex input description
> Fix regression on iOS Simulator by including TargetConditionals.h in gui.h
> Add CMAKE_OSX_DEPLOYMENT_TARGET to macOS build docs and CI script
> Add possible Linux WSI options
> Unify vkb::Gui and vkb::HPPGui into vkb::Gui<bindingType>
> Remove submodule CTPL, replace its functionality by calls to std::async
> fix: fix the surface resize logic when use wayland wsi
> Implement simple cache for decoded ASTC textures
> Unify vkb::Device and vkb::core::HPPDevice into vkb::core::Device<bindingType>
> Port of latest changes in api sample hello_triangle to hpp_hello_triangle
> Fix crash in sample on android
> Improve and fix async compute sample
> Fix MacOS cmake build instructions
> Replace runtime shader compilation with offline compiled SPIR-V shaders
> Transcoded version of api sample hello_triangle_1_3 based on Vulkan-Hpp
> Unify vkb::RenderFrame and vkb::rendering::HPPRenderFrame into vkb::rendering::RenderFrame<bindingType>
> Increase base version to Vulkan 1.1
>
> Signed-off-by: Gyorgy Sarvari <skandigraun@gmail.com>
> ---

Hi Gyorgy,

It looks like vulkan-samples is used by the test_devtool_git_submodules
selftest, so it results in some error after this update:

2025-09-12 06:53:10,870 - oe-selftest - INFO - devtool.DevtoolUpdateTests.test_devtool_git_submodules (subunit.RemotedTestCase)
2025-09-12 06:53:10,871 - oe-selftest - INFO -  ... FAIL
...
2025-09-12 06:53:10,872 - oe-selftest - INFO - testtools.testresult.real._StringException: Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/meta/lib/oeqa/selftest/cases/devtool.py", line 1729, in test_devtool_git_submodules
    self._check_repo_status(recipedir, expected_status)
  File "/srv/pokybuild/yocto-worker/oe-selftest-armhost/build/meta/lib/oeqa/selftest/cases/devtool.py", line 135, in _check_repo_status
    self.fail('Unexpected modified file in line: %s' % line)
  File "/usr/lib/python3.12/unittest/case.py", line 715, in fail
    raise self.failureException(msg)
AssertionError: Unexpected modified file in line: ?? meta/recipes-graphics/vulkan/vulkan-samples/

Can you have a look at what is going on there?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com