Openembedded Core Discussions
 help / color / mirror / Atom feed
* [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
@ 2025-09-18 21:48 rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 1/6] libx11: create tmpfile dir for x11 domain socket rs
                   ` (7 more replies)
  0 siblings, 8 replies; 23+ messages in thread
From: rs @ 2025-09-18 21:48 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

We've recently run into some issues with weston-init attempting to start Weston
prior to all drm devices being registered. There's not really a good, scriptable
mechanism to listen in to device registration events that works with the
existing weston-init package. Well, at least one that doesn't involve polling
files or introducing more dependency on the init system being used.

I also see there is also a lot of scripting around starting X11,
xserver-nodm-init, that (from my limited review) should experience the same
issue.

I'd like to introduce the following display manager for oe-core, emptty [1].
This display manager is, as described upstream, a "Dead simple CLI Display
Manager on TTY". It supports both x11 and wayland sessions, with togglable build
parameters to completely remove x11 and pam dependencies. It's licensed MIT,
which shouldn't be an issue for any users. (It is written in Go, if you have
opinions about that.)

With this, both weston-init and the xserver-nodm-init packages can be re-tuned
to leverage this display manager and simply add a user and emptty config for an
autologin session. This can resolve the current behavior across init systems
without additional scripting, and move some development out of this layer.

This lists myself as a maintainer of emptty as well as xserver-nodm-init and
xuser-account since these are currently unassigned and I've reworked them
significantly here.

Sorry for the delay on this series. I found a few bugs in emptty that I wanted
to address before submitting this officially.

[1] https://github.com/tvrzna/emptty

v2:
	- Address spelling issues in commit messages
	- Attempt to resolve some test related issues with weston
	- Add additional logs to X11 related tests
v3:
	- Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
	  under QEMU the first auth attempt almost always fails.
v4:
	- Add a tmpfile entry for the x11 domain socket directory.
	- Remove some scripts associated with weston-init that were being
	  shipped with weston
v5:
	- Move tmpfile data to individual files
	- Add explicit entries for these in the FILES variable
v6:
	- Do not attempt to ship a tmpfiles.d entry in libx11
v7:
	- Include a backported fix for go/runtime to address segfault issues
	  reported on x86 platforms in previous revisions
v8:
	- Sign-off backported patch
v9:
	- Resolve merge conflict in maintainers file

Randolph Sapp (6):
  libx11: create tmpfile dir for x11 domain socket
  go: fix sigaction usage on i386 platforms
  emptty: add version 0.14.0
  weston-init: convert to virtual-emptty-conf
  weston: remove deprecated weston-start scripts
  xserver-nodm-init: convert to virtual-emptty-conf

 .../conf/distro/include/default-providers.inc |   1 +
 meta/conf/distro/include/maintainers.inc      |   6 +-
 meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
 meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
 meta/recipes-graphics/emptty/emptty.inc       |  26 ++
 .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
 meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
 meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
 meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
 .../wayland/weston-init/emptty.conf           |  77 ++++
 .../recipes-graphics/wayland/weston-init/init |  54 ---
 .../wayland/weston-init/weston-autologin      |  11 -
 .../wayland/weston-init/weston-socket.sh      |  20 -
 .../wayland/weston-init/weston-start          |  76 ----
 .../wayland/weston-init/weston.env            |   0
 .../wayland/weston-init/weston.service        |  71 ----
 .../wayland/weston-init/weston.socket         |  14 -
 .../weston/systemd-notify.weston-start        |   9 -
 .../wayland/weston/xwayland.weston-start      |   6 -
 .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in          |  77 ++++
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
 .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 39 files changed, 581 insertions(+), 918 deletions(-)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

-- 
2.51.0



^ permalink raw reply	[flat|nested] 23+ messages in thread

* [oe-core][PATCHv9 1/6] libx11: create tmpfile dir for x11 domain socket
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
@ 2025-09-18 21:48 ` rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 2/6] go: fix sigaction usage on i386 platforms rs
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: rs @ 2025-09-18 21:48 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

Register a volatile directory entry for the x11 domain socket when not
using systemd. This will make sure the directory is always created with
the correct permissions. Systemd already provides their own tmpfile.d
entry for the same behavior.

Currently some x11 related applications will create this directory if it
doesn't already exist, but this is not true for everything. In addition,
if the application in question isn't started as root, it's possible this
directory can be owned by a non-root user. This isn't an issue by
itself, but it can potentially lead to problems in a multi-user
environment.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta/recipes-graphics/xorg-lib/libx11/99_x11    |  1 +
 meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb | 15 +++++++++++++--
 2 files changed, 14 insertions(+), 2 deletions(-)
 create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11

diff --git a/meta/recipes-graphics/xorg-lib/libx11/99_x11 b/meta/recipes-graphics/xorg-lib/libx11/99_x11
new file mode 100644
index 0000000000..53c5b49d10
--- /dev/null
+++ b/meta/recipes-graphics/xorg-lib/libx11/99_x11
@@ -0,0 +1 @@
+d root root 1777 /tmp/.X11-unix none
diff --git a/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb b/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb
index 580e44889d..78713f4ac5 100644
--- a/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb
+++ b/meta/recipes-graphics/xorg-lib/libx11_1.8.12.bb
@@ -21,7 +21,8 @@ PE = "1"
 
 XORG_PN = "libX11"
 
-SRC_URI += "file://disable_tests.patch"
+SRC_URI += "file://disable_tests.patch \
+            file://99_x11"
 
 SRC_URI[sha256sum] = "fa026f9bb0124f4d6c808f9aef4057aad65e7b35d8ff43951cef0abe06bb9a9a"
 
@@ -35,7 +36,17 @@ PACKAGECONFIG[xcms] = "--enable-xcms,--disable-xcms"
 
 PACKAGES =+ "${PN}-xcb"
 
-FILES:${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${datadir}/X11/Xcms.txt"
+do_install:append() {
+	# temporary directory required for x11 domain sockets
+        # systemd provides their own definition using tmpfiles.d
+	if ${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'systemd', 'false', 'true', d)}; then
+		install -d ${D}${sysconfdir}/default/volatiles
+		install -m 0644 ${UNPACKDIR}/99_x11 ${D}${sysconfdir}/default/volatiles/99_x11
+	fi
+}
+
+FILES:${PN} += "${datadir}/X11/XKeysymDB ${datadir}/X11/XErrorDB ${datadir}/X11/Xcms.txt \
+                ${libdir}/tmpfiles.d/x11.conf ${sysconfdir}/default/volatiles/99_x11"
 FILES:${PN}-xcb += "${libdir}/libX11-xcb.so.*"
 FILES:${PN}-locale += "${datadir}/X11/locale ${libdir}/X11/locale"
 
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [oe-core][PATCHv9 2/6] go: fix sigaction usage on i386 platforms
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 1/6] libx11: create tmpfile dir for x11 domain socket rs
@ 2025-09-18 21:48 ` rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 3/6] emptty: add version 0.14.0 rs
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: rs @ 2025-09-18 21:48 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

In upstream the following commit [1] was submitted to resolve issues
with sigaction being used in linked libraries with cgo applications.

runtime: when using cgo on 386, call C sigaction function

This should address the previously reported issues with pam
authentication of go applications on related x86 platforms.

[1] https://github.com/golang/go/commit/c5737dc21bbac9fbefc35ac9313e66291d66b382

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
 ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++++++++
 2 files changed, 249 insertions(+)
 create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch

diff --git a/meta/recipes-devtools/go/go-1.25.0.inc b/meta/recipes-devtools/go/go-1.25.0.inc
index f562fbb34b..1558b4623d 100644
--- a/meta/recipes-devtools/go/go-1.25.0.inc
+++ b/meta/recipes-devtools/go/go-1.25.0.inc
@@ -16,5 +16,6 @@ SRC_URI += "\
     file://0009-go-Filter-build-paths-on-staticly-linked-arches.patch \
     file://0010-cmd-go-clear-GOROOT-for-func-ldShared-when-trimpath-.patch \
     file://0011-cmd-link-stop-forcing-binutils-gold-dependency-on-aa.patch \
+    file://0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch \
 "
 SRC_URI[main.sha256sum] = "4bd01e91297207bfa450ea40d4d5a93b1b531a5e438473b2a06e18e077227225"
diff --git a/meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch b/meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
new file mode 100644
index 0000000000..33e3b033a1
--- /dev/null
+++ b/meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
@@ -0,0 +1,248 @@
+From c5737dc21bbac9fbefc35ac9313e66291d66b382 Mon Sep 17 00:00:00 2001
+From: Ian Lance Taylor <iant@golang.org>
+Date: Fri, 5 Sep 2025 22:24:37 -0700
+Subject: [PATCH] runtime: when using cgo on 386, call C sigaction function
+
+On 386 the C sigaction function assumes that the caller does not set
+the SA_RESTORER flag. It does not copy the C sa_restorer field to
+the kernel sa_restorer field. The effect is that the kernel sees
+the SA_RESTORER flag but a NULL sa_restorer field, and the program
+crashes when returning from a signal handler.
+
+On the other hand, the C sigaction function will return the SA_RESTORER
+flag and the sa_restorer field stored in the kernel.
+
+This means that if the Go runtime installs a signal handler,
+with SA_RESTORER as is required when calling the kernel,
+and the Go program calls C code that calls the C sigaction function
+to query the current signal handler, that C code will get a result
+that it can't pass back to sigaction.
+
+This CL fixes the problem by using the C sigaction function
+for 386 programs that use cgo. This reuses the functionality
+used on amd64 and other GOARCHs to support the race detector.
+
+See #75253, or runtime/testdata/testprogcgo/eintr.go, for sample
+code that used to fail on 386. No new test case is required,
+we just remove the skip we used to have for eintr.go.
+
+Fixes #75253
+
+Change-Id: I803059b1fb9e09e9fbb43f68eccb6a59a92c2991
+Reviewed-on: https://go-review.googlesource.com/c/go/+/701375
+LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
+Reviewed-by: Cherry Mui <cherryyz@google.com>
+Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
+Auto-Submit: Ian Lance Taylor <iant@golang.org>
+Upstream-Status: Backport [https://github.com/golang/go/commit/c5737dc21bbac9fbefc35ac9313e66291d66b382]
+Signed-off-by: Randolph Sapp <rs@ti.com>
+---
+ src/runtime/cgo/gcc_sigaction.c |  8 ++++----
+ src/runtime/cgo/sigaction.go    |  2 +-
+ src/runtime/cgo_sigaction.go    |  6 +++++-
+ src/runtime/crash_cgo_test.go   | 11 -----------
+ src/runtime/os_freebsd.go       |  6 ++++++
+ src/runtime/os_linux.go         | 18 +++++++++++++++++-
+ src/runtime/sigaction.go        |  2 +-
+ src/runtime/sys_linux_386.s     | 19 +++++++++++++++++++
+ 8 files changed, 53 insertions(+), 19 deletions(-)
+
+diff --git a/src/runtime/cgo/gcc_sigaction.c b/src/runtime/cgo/gcc_sigaction.c
+index 7cbef7db11..ad48a88dc1 100644
+--- a/src/runtime/cgo/gcc_sigaction.c
++++ b/src/runtime/cgo/gcc_sigaction.c
+@@ -2,7 +2,7 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
+-//go:build linux && (amd64 || arm64 || loong64 || ppc64le)
++//go:build linux && (386 || amd64 || arm64 || loong64 || ppc64le)
+ 
+ #include <errno.h>
+ #include <stddef.h>
+@@ -17,7 +17,7 @@
+ // to and from struct sigaction — are specific to ${goos}/${goarch}.
+ typedef struct {
+ 	uintptr_t handler;
+-	uint64_t flags;
++	unsigned long flags;
+ #ifdef __loongarch__
+ 	uint64_t mask;
+ 	uintptr_t restorer;
+@@ -57,7 +57,7 @@ x_cgo_sigaction(intptr_t signum, const go_sigaction_t *goact, go_sigaction_t *ol
+ 				sigaddset(&act.sa_mask, (int)(i+1));
+ 			}
+ 		}
+-		act.sa_flags = (int)(goact->flags & ~(uint64_t)SA_RESTORER);
++		act.sa_flags = (int)(goact->flags & ~(unsigned long)SA_RESTORER);
+ 	}
+ 
+ 	ret = sigaction((int)signum, goact ? &act : NULL, oldgoact ? &oldact : NULL);
+@@ -79,7 +79,7 @@ x_cgo_sigaction(intptr_t signum, const go_sigaction_t *goact, go_sigaction_t *ol
+ 				oldgoact->mask |= (uint64_t)(1)<<i;
+ 			}
+ 		}
+-		oldgoact->flags = (uint64_t)oldact.sa_flags;
++		oldgoact->flags = (unsigned long)oldact.sa_flags;
+ 	}
+ 
+ 	_cgo_tsan_release();
+diff --git a/src/runtime/cgo/sigaction.go b/src/runtime/cgo/sigaction.go
+index dc3f5fd255..90034bad32 100644
+--- a/src/runtime/cgo/sigaction.go
++++ b/src/runtime/cgo/sigaction.go
+@@ -2,7 +2,7 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
+-//go:build (linux && (amd64 || arm64 || loong64 || ppc64le)) || (freebsd && amd64)
++//go:build (linux && (386 || amd64 || arm64 || loong64 || ppc64le)) || (freebsd && amd64)
+ 
+ package cgo
+ 
+diff --git a/src/runtime/cgo_sigaction.go b/src/runtime/cgo_sigaction.go
+index 5c644587f0..f725dbef4d 100644
+--- a/src/runtime/cgo_sigaction.go
++++ b/src/runtime/cgo_sigaction.go
+@@ -3,8 +3,10 @@
+ // license that can be found in the LICENSE file.
+ 
+ // Support for sanitizers. See runtime/cgo/sigaction.go.
++// Also used on linux/386 to clear the SA_RESTORER flag
++// when using cgo; see issue #75253.
+ 
+-//go:build (linux && (amd64 || arm64 || loong64 || ppc64le)) || (freebsd && amd64)
++//go:build (linux && (386 || amd64 || arm64 || loong64 || ppc64le)) || (freebsd && amd64)
+ 
+ package runtime
+ 
+@@ -42,6 +44,8 @@ func sigaction(sig uint32, new, old *sigactiont) {
+ 
+ 		var ret int32
+ 
++		fixSigactionForCgo(new)
++
+ 		var g *g
+ 		if mainStarted {
+ 			g = getg()
+diff --git a/src/runtime/crash_cgo_test.go b/src/runtime/crash_cgo_test.go
+index c5d7303261..b77ff8dafd 100644
+--- a/src/runtime/crash_cgo_test.go
++++ b/src/runtime/crash_cgo_test.go
+@@ -842,17 +842,6 @@ func TestEINTR(t *testing.T) {
+ 	switch runtime.GOOS {
+ 	case "plan9", "windows":
+ 		t.Skipf("no EINTR on %s", runtime.GOOS)
+-	case "linux":
+-		if runtime.GOARCH == "386" {
+-			// On linux-386 the Go signal handler sets
+-			// a restorer function that is not preserved
+-			// by the C sigaction call in the test,
+-			// causing the signal handler to crash when
+-			// returning the normal code. The test is not
+-			// architecture-specific, so just skip on 386
+-			// rather than doing a complicated workaround.
+-			t.Skip("skipping on linux-386; C sigaction does not preserve Go restorer")
+-		}
+ 	}
+ 	if runtime.GOOS == "freebsd" && race.Enabled {
+ 		t.Skipf("race + cgo freebsd not supported. See https://go.dev/issue/73788.")
+diff --git a/src/runtime/os_freebsd.go b/src/runtime/os_freebsd.go
+index ab859cfb47..68d895b95d 100644
+--- a/src/runtime/os_freebsd.go
++++ b/src/runtime/os_freebsd.go
+@@ -457,6 +457,12 @@ func sysSigaction(sig uint32, new, old *sigactiont) {
+ 	}
+ }
+ 
++// fixSigactionForCgo is needed for Linux.
++//
++//go:nosplit
++func fixSigactionForCgo(new *sigactiont) {
++}
++
+ // asmSigaction is implemented in assembly.
+ //
+ //go:noescape
+diff --git a/src/runtime/os_linux.go b/src/runtime/os_linux.go
+index c9d25a5be8..f9fe1b5f33 100644
+--- a/src/runtime/os_linux.go
++++ b/src/runtime/os_linux.go
+@@ -486,7 +486,8 @@ func setsig(i uint32, fn uintptr) {
+ 	sigfillset(&sa.sa_mask)
+ 	// Although Linux manpage says "sa_restorer element is obsolete and
+ 	// should not be used". x86_64 kernel requires it. Only use it on
+-	// x86.
++	// x86. Note that on 386 this is cleared when using the C sigaction
++	// function via cgo; see fixSigactionForCgo.
+ 	if GOARCH == "386" || GOARCH == "amd64" {
+ 		sa.sa_restorer = abi.FuncPCABI0(sigreturn__sigaction)
+ 	}
+@@ -562,6 +563,21 @@ func sysSigaction(sig uint32, new, old *sigactiont) {
+ //go:noescape
+ func rt_sigaction(sig uintptr, new, old *sigactiont, size uintptr) int32
+ 
++// fixSigactionForCgo is called when we are using cgo to call the
++// C sigaction function. On 386 the C function does not expect the
++// SA_RESTORER flag to be set, and in some cases will fail if it is set:
++// it will pass the SA_RESTORER flag to the kernel without passing
++// the sa_restorer field. Since the C function will handle SA_RESTORER
++// for us, we need not pass it. See issue #75253.
++//
++//go:nosplit
++func fixSigactionForCgo(new *sigactiont) {
++	if GOARCH == "386" && new != nil {
++		new.sa_flags &^= _SA_RESTORER
++		new.sa_restorer = 0
++	}
++}
++
+ func getpid() int
+ func tgkill(tgid, tid, sig int)
+ 
+diff --git a/src/runtime/sigaction.go b/src/runtime/sigaction.go
+index 2027ae80bf..1a99f7f3ec 100644
+--- a/src/runtime/sigaction.go
++++ b/src/runtime/sigaction.go
+@@ -2,7 +2,7 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
+-//go:build (linux && !amd64 && !arm64 && !loong64 && !ppc64le) || (freebsd && !amd64)
++//go:build (linux && !386 && !amd64 && !arm64 && !loong64 && !ppc64le) || (freebsd && !amd64)
+ 
+ package runtime
+ 
+diff --git a/src/runtime/sys_linux_386.s b/src/runtime/sys_linux_386.s
+index d53be243fe..8e832687e0 100644
+--- a/src/runtime/sys_linux_386.s
++++ b/src/runtime/sys_linux_386.s
+@@ -410,6 +410,25 @@ TEXT runtime·rt_sigaction(SB),NOSPLIT,$0
+ 	MOVL	AX, ret+16(FP)
+ 	RET
+ 
++// Call the function stored in _cgo_sigaction using the GCC calling convention.
++TEXT runtime·callCgoSigaction(SB),NOSPLIT,$0-16
++	MOVL	_cgo_sigaction(SB), AX
++	MOVL	sig+0(FP), BX
++	MOVL	new+4(FP), CX
++	MOVL	old+8(FP), DX
++	MOVL	SP, SI // align stack to call C function
++	SUBL	$32, SP
++	ANDL	$~15, SP
++	MOVL	BX, 0(SP)
++	MOVL	CX, 4(SP)
++	MOVL	DX, 8(SP)
++	MOVL	SI, 12(SP)
++	CALL	AX
++	MOVL	12(SP), BX
++	MOVL	BX, SP
++	MOVL	AX, ret+12(FP)
++	RET
++
+ TEXT runtime·sigfwd(SB),NOSPLIT,$12-16
+ 	MOVL	fn+0(FP), AX
+ 	MOVL	sig+4(FP), BX
+-- 
+2.51.0
+
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [oe-core][PATCHv9 3/6] emptty: add version 0.14.0
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 1/6] libx11: create tmpfile dir for x11 domain socket rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 2/6] go: fix sigaction usage on i386 platforms rs
@ 2025-09-18 21:48 ` rs
  2025-09-18 21:48 ` [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf rs
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: rs @ 2025-09-18 21:48 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

Add emptty, a "Dead simple CLI Display Manager on TTY". This is a
relatively lightweight display manager that supports x11 as well as
wayland through both a CLI and an automatic login mechanism.

This can effectively replace the custom init scripts for both x11
(xserver-nodm-init) and wayland (weston-init) with a single tool with
more verbose logging capabilities.

This is split into two recipes. The emptty package provides the binary
and various agnostic configs while the emptty-conf package provides the
default configuration for the application itself. This RPROVIDES
virtual-emptty-conf, allowing other recipes to provide their own
configurations to override the default behavior.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../conf/distro/include/default-providers.inc |  1 +
 meta/conf/distro/include/maintainers.inc      |  2 +
 meta/recipes-graphics/emptty/emptty-conf.bb   | 14 +++++
 meta/recipes-graphics/emptty/emptty.inc       | 26 +++++++++
 .../recipes-graphics/emptty/emptty/emptty.tab |  1 +
 meta/recipes-graphics/emptty/emptty/pamconf   | 10 ++++
 meta/recipes-graphics/emptty/emptty_0.14.0.bb | 53 +++++++++++++++++++
 7 files changed, 107 insertions(+)
 create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
 create mode 100644 meta/recipes-graphics/emptty/emptty.inc
 create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
 create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
 create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb

diff --git a/meta/conf/distro/include/default-providers.inc b/meta/conf/distro/include/default-providers.inc
index 3f113543cd..820a5d1342 100644
--- a/meta/conf/distro/include/default-providers.inc
+++ b/meta/conf/distro/include/default-providers.inc
@@ -69,3 +69,4 @@ PREFERRED_PROVIDER_virtual/nativesdk-libsdl2 ?= "nativesdk-libsdl2"
 PREFERRED_RPROVIDER_virtual-libegl-icd ?= "mesa"
 PREFERRED_RPROVIDER_virtual-libglx-icd ?= "mesa"
 PREFERRED_RPROVIDER_virtual-x-terminal-emulator ?= "rxvt-unicode"
+PREFERRED_RPROVIDER_virtual-emptty-conf ?= "emptty-conf"
diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index e80959749e..db5e2fa9c9 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -171,6 +171,8 @@ RECIPE_MAINTAINER:pn-efivar = "Ross Burton <ross.burton@arm.com>"
 RECIPE_MAINTAINER:pn-efibootmgr = "Ross Burton <ross.burton@arm.com>"
 RECIPE_MAINTAINER:pn-elfutils = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-ell = "Unassigned <unassigned@yoctoproject.org>"
+RECIPE_MAINTAINER:pn-emptty = "Randolph Sapp <rs@ti.com>"
+RECIPE_MAINTAINER:pn-emptty-conf = "Randolph Sapp <rs@ti.com>"
 RECIPE_MAINTAINER:pn-enchant2 = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-encodings = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-epiphany = "Unassigned <unassigned@yoctoproject.org>"
diff --git a/meta/recipes-graphics/emptty/emptty-conf.bb b/meta/recipes-graphics/emptty/emptty-conf.bb
new file mode 100644
index 0000000000..0aacb086cd
--- /dev/null
+++ b/meta/recipes-graphics/emptty/emptty-conf.bb
@@ -0,0 +1,14 @@
+require emptty.inc
+
+SUMMARY += " (Default config)"
+
+do_configure[noexec] = "1"
+do_compile[noexec] = "1"
+
+do_install () {
+    oe_runmake -C ${S}/src/${GO_IMPORT} DESTDIR=${D} install-config
+}
+
+FILES:${PN}-conf = "${sysconfdir}/emptty/conf"
+CONFFILES:${PN}-conf = "${sysconfdir}/emptty/conf"
+RPROVIDES:${PN}-conf += "virtual-emptty-conf"
diff --git a/meta/recipes-graphics/emptty/emptty.inc b/meta/recipes-graphics/emptty/emptty.inc
new file mode 100644
index 0000000000..11d5770f3a
--- /dev/null
+++ b/meta/recipes-graphics/emptty/emptty.inc
@@ -0,0 +1,26 @@
+SUMMARY = "Dead simple CLI Display Manager on TTY"
+DESCRIPTION = "Emptty is a simple display manager with a command line greeter \
+It supports both X11 and Wayland sessions, exporting required variables and \
+creating user paths as necessary."
+
+HOMEPAGE = "https://github.com/tvrzna/emptty"
+BUGTRACKER = "https://github.com/tvrzna/emptty/issues"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://src/${GO_IMPORT}/LICENSE;md5=d1e4d12c7d1d17367ba5668706a405ba"
+
+S = "${UNPACKDIR}"
+
+FILESEXTRAPATHS:append = ":${THISDIR}/emptty"
+
+GO_IMPORT = "github.com/tvrzna/emptty"
+GO_IMPORT_pam = "github.com/msteinert/pam"
+SRC_URI = "\
+    git://${GO_IMPORT}.git;protocol=https;branch=master;destsuffix=src/${GO_IMPORT} \
+    git://${GO_IMPORT_pam}.git;protocol=https;branch=master;name=pam;destsuffix=src/${GO_IMPORT_pam} \
+    file://pamconf \
+    file://emptty.tab \
+    "
+SRCREV = "d162bef75fadc8ae1d8e33dbb3de5e2795a196e0"
+SRCREV_pam = "50ded1b0e7864b9bf75005eb945a8ec826bcf69d"
+
+SRCREV_FORMAT .= "_pam"
diff --git a/meta/recipes-graphics/emptty/emptty/emptty.tab b/meta/recipes-graphics/emptty/emptty/emptty.tab
new file mode 100644
index 0000000000..6359c7224d
--- /dev/null
+++ b/meta/recipes-graphics/emptty/emptty/emptty.tab
@@ -0,0 +1 @@
+7:5:respawn:/usr/bin/emptty -t 7 -d
diff --git a/meta/recipes-graphics/emptty/emptty/pamconf b/meta/recipes-graphics/emptty/emptty/pamconf
new file mode 100644
index 0000000000..9cbfd6c4a5
--- /dev/null
+++ b/meta/recipes-graphics/emptty/emptty/pamconf
@@ -0,0 +1,10 @@
+#%PAM-1.0
+auth            sufficient      pam_succeed_if.so user ingroup nopasswdlogin
+auth            include         common-auth
+-auth           optional        pam_gnome_keyring.so
+-auth           optional        pam_kwallet5.so
+account         include         common-account
+session         include         common-session
+-session        optional        pam_gnome_keyring.so auto_start
+-session        optional        pam_kwallet5.so auto_start force_run
+password        include         common-password
diff --git a/meta/recipes-graphics/emptty/emptty_0.14.0.bb b/meta/recipes-graphics/emptty/emptty_0.14.0.bb
new file mode 100644
index 0000000000..11d306a56d
--- /dev/null
+++ b/meta/recipes-graphics/emptty/emptty_0.14.0.bb
@@ -0,0 +1,53 @@
+require emptty.inc
+
+PACKAGECONFIG ?= "${@bb.utils.filter('DISTRO_FEATURES', 'pam x11', d)}"
+PACKAGECONFIG[pam] = ",,libpam,pam-plugin-succeed-if"
+PACKAGECONFIG[x11] = ",,virtual/libx11"
+
+DEPENDS += "${@bb.utils.contains('PACKAGECONFIG', 'pam', '', 'virtual/crypt', d)}"
+
+GO_TAGS = ""
+GO_TAGS:append = "${@bb.utils.contains('PACKAGECONFIG', 'pam', '', ',nopam', d)}"
+GO_TAGS:append = "${@bb.utils.contains('PACKAGECONFIG', 'x11', '', ',noxlib', d)}"
+
+GOBUILDFLAGS:append = " -tags=${GO_TAGS}"
+
+export GO111MODULE = "off"
+
+inherit go
+
+DEPENDS += "gzip"
+
+do_install () {
+    # general collateral
+    install -Dm755 ${B}/${GO_BUILD_BINDIR}/emptty ${D}${bindir}/emptty
+    install -d ${D}${mandir}/man1
+    gzip -cn ${S}/src/${GO_IMPORT}/res/emptty.1 > ${D}${mandir}/man1/emptty.1.gz
+
+    # pam config
+    if "${@bb.utils.contains('PACKAGECONFIG','pam','true','false',d)}"
+    then
+        install -Dm644 ${S}/pamconf ${D}${sysconfdir}/pam.d/emptty
+    fi
+
+    # init services
+    if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}
+    then
+        oe_runmake -C ${S}/src/${GO_IMPORT} DESTDIR=${D} install-systemd
+    else
+        install -Dm644 ${S}/emptty.tab ${D}${sysconfdir}/inittab.d/emptty.tab
+    fi
+}
+
+FILES:${PN} = "\
+    ${systemd_system_unitdir}/emptty.service \
+    ${sysconfdir}/inittab.d/emptty.tab \
+    ${bindir}/emptty \
+    ${mandir}/man1/emptty.1.gz \
+    ${sysconfdir}/pam.d/emptty \
+"
+
+RDEPENDS:${PN} += "virtual-emptty-conf"
+SYSTEMD_SERVICE:${PN} = "emptty.service"
+
+inherit systemd
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
                   ` (2 preceding siblings ...)
  2025-09-18 21:48 ` [oe-core][PATCHv9 3/6] emptty: add version 0.14.0 rs
@ 2025-09-18 21:48 ` rs
  2025-09-18 22:03   ` Patchtest results for " patchtest
  2025-09-18 21:49 ` [oe-core][PATCHv9 5/6] weston: remove deprecated weston-start scripts rs
                   ` (3 subsequent siblings)
  7 siblings, 1 reply; 23+ messages in thread
From: rs @ 2025-09-18 21:48 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

Convert this script package into a simple config for emptty using the
same weston user but leveraging the nopasswdlogin session provided by
emptty. Runtime provide virtual-emptty-conf as we need to set parameters
for the default session.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta/lib/oeqa/runtime/cases/weston.py         | 18 +++--
 meta/recipes-graphics/wayland/weston-init.bb  | 61 +++------------
 .../wayland/weston-init/emptty.conf           | 77 +++++++++++++++++++
 .../recipes-graphics/wayland/weston-init/init | 54 -------------
 .../wayland/weston-init/weston-autologin      | 11 ---
 .../wayland/weston-init/weston-socket.sh      | 20 -----
 .../wayland/weston-init/weston-start          | 76 ------------------
 .../wayland/weston-init/weston.env            |  0
 .../wayland/weston-init/weston.service        | 71 -----------------
 .../wayland/weston-init/weston.socket         | 14 ----
 10 files changed, 101 insertions(+), 301 deletions(-)
 create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
 delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
 delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket

diff --git a/meta/lib/oeqa/runtime/cases/weston.py b/meta/lib/oeqa/runtime/cases/weston.py
index ee4d336482..69be1f65e3 100644
--- a/meta/lib/oeqa/runtime/cases/weston.py
+++ b/meta/lib/oeqa/runtime/cases/weston.py
@@ -37,7 +37,7 @@ class WestonTest(OERuntimeTestCase):
 
     def run_weston_init(self):
         if 'systemd' in self.tc.td['VIRTUAL-RUNTIME_init_manager']:
-            self.target.run('systemd-run --collect --unit=weston-ptest.service --uid=0 -p PAMName=login -p TTYPath=/dev/tty6 -E XDG_RUNTIME_DIR=/tmp -E WAYLAND_DISPLAY=wayland-0 /usr/bin/weston --socket=wayland-1 --log=%s' % self.weston_log_file)
+            self.target.run(self.get_weston_command('systemd-run --collect --unit=weston-ptest.service --uid=0 -p PAMName=login -p TTYPath=/dev/tty6 -E XDG_RUNTIME_DIR -E WAYLAND_DISPLAY /usr/bin/weston --socket=wayland-2 --log=%s' % self.weston_log_file))
         else:
             self.target.run(self.get_weston_command('openvt -- weston --socket=wayland-2 --log=%s' % self.weston_log_file))
 
@@ -55,12 +55,18 @@ class WestonTest(OERuntimeTestCase):
 
     @OEHasPackage(['wayland-utils'])
     def test_wayland_info(self):
-        if 'systemd' in self.tc.td['VIRTUAL-RUNTIME_init_manager']:
-            command = 'XDG_RUNTIME_DIR=/run wayland-info'
-        else:
-            command = self.get_weston_command('wayland-info')
+        command = self.get_weston_command('wayland-info')
         status, output = self.target.run(command)
-        self.assertEqual(status, 0, msg='wayland-info error: %s' % output)
+        msg = 'wayland-info error: %s' % output
+
+        # dump last 20 lines of emptty log in case of failure
+        log_cmd = 'tail -n 20 /var/log/emptty/7.log'
+        msg += '\n\n===== start: snippet =====\n\n'
+        msg += 'file: /var/log/emptty/7.log\n\n'
+        msg += '\n\n%s\n\n' % self.target.run(log_cmd)[1]
+        msg += '\n\n===== end: snippet =====\n\n'
+
+        self.assertEqual(status, 0, msg=msg)
 
     @OEHasPackage(['weston'])
     def test_weston_can_initialize_new_wayland_compositor(self):
diff --git a/meta/recipes-graphics/wayland/weston-init.bb b/meta/recipes-graphics/wayland/weston-init.bb
index fc817d113f..6caf2a0387 100644
--- a/meta/recipes-graphics/wayland/weston-init.bb
+++ b/meta/recipes-graphics/wayland/weston-init.bb
@@ -1,17 +1,13 @@
-SUMMARY = "Startup script and systemd unit file for the Weston Wayland compositor"
+SUMMARY = "Autologin package for the Weston Wayland compositor"
 LICENSE = "MIT"
 LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-SRC_URI = "file://init \
-           file://weston.env \
+SRC_URI = "\
            file://weston.ini \
-           file://weston.service \
-           file://weston.socket \
-           file://weston-socket.sh \
-           file://weston-autologin \
-           file://weston-start"
+           file://emptty.conf \
+"
 
 S = "${UNPACKDIR}"
 
@@ -27,32 +23,8 @@ DEFAULTBACKEND ??= ""
 DEFAULTBACKEND:qemuall ?= "drm"
 
 do_install() {
-	# Install weston-start script
-	if [ "${VIRTUAL-RUNTIME_init_manager}" != "systemd" ]; then
-		install -Dm755 ${S}/weston-start ${D}${bindir}/weston-start
-		sed -i 's,@DATADIR@,${datadir},g' ${D}${bindir}/weston-start
-		sed -i 's,@LOCALSTATEDIR@,${localstatedir},g' ${D}${bindir}/weston-start
-		install -Dm755 ${S}/init ${D}/${sysconfdir}/init.d/weston
-		sed -i 's#ROOTHOME#${ROOT_HOME}#' ${D}/${sysconfdir}/init.d/weston
-	fi
-
-	# Install Weston systemd service
-	if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
-		install -D -p -m0644 ${S}/weston.service ${D}${systemd_system_unitdir}/weston.service
-		install -D -p -m0644 ${S}/weston.socket ${D}${systemd_system_unitdir}/weston.socket
-		install -D -p -m0644 ${S}/weston-socket.sh ${D}${sysconfdir}/profile.d/weston-socket.sh
-		sed -i -e s:/etc:${sysconfdir}:g \
-			-e s:/usr/bin:${bindir}:g \
-			-e s:/var:${localstatedir}:g \
-			${D}${systemd_system_unitdir}/weston.service
-	fi
-
-	if [ "${@bb.utils.filter('DISTRO_FEATURES', 'pam', d)}" ]; then
-		install -D -p -m0644 ${S}/weston-autologin ${D}${sysconfdir}/pam.d/weston-autologin
-	fi
-
 	install -D -p -m0644 ${S}/weston.ini ${D}${sysconfdir}/xdg/weston/weston.ini
-	install -Dm644 ${S}/weston.env ${D}${sysconfdir}/default/weston
+	install -D -p -m0644 ${S}/emptty.conf ${D}${sysconfdir}/emptty/conf
 
 	if [ -n "${DEFAULTBACKEND}" ]; then
 		sed -i -e "/^\[core\]/a backend=${DEFAULTBACKEND}-backend.so" ${D}${sysconfdir}/xdg/weston/weston.ini
@@ -73,9 +45,7 @@ do_install() {
 	install -dm 755 -o weston -g weston ${D}/home/weston
 }
 
-INHIBIT_UPDATERCD_BBCLASS = "${@oe.utils.conditional('VIRTUAL-RUNTIME_init_manager', 'systemd', '1', '', d)}"
-
-inherit update-rc.d systemd useradd
+inherit useradd
 
 USERADD_PACKAGES = "${PN}"
 
@@ -83,23 +53,16 @@ USERADD_PACKAGES = "${PN}"
 #
 require ${THISDIR}/required-distro-features.inc
 
-RDEPENDS:${PN} = "weston kbd ${@bb.utils.contains('PACKAGECONFIG', 'xwayland', 'weston-xwayland', '', d)}"
-
-INITSCRIPT_NAME = "weston"
-INITSCRIPT_PARAMS = "start 9 5 2 . stop 20 0 1 6 ."
+RDEPENDS:${PN} = "emptty weston kbd ${@bb.utils.contains('PACKAGECONFIG', 'xwayland', 'weston-xwayland', '', d)}"
 
 FILES:${PN} += "\
     ${sysconfdir}/xdg/weston/weston.ini \
-    ${sysconfdir}/profile.d/weston-socket.sh \
-    ${systemd_system_unitdir}/weston.service \
-    ${systemd_system_unitdir}/weston.socket \
-    ${sysconfdir}/default/weston \
-    ${sysconfdir}/pam.d/ \
+    ${sysconfdir}/emptty/conf \
     /home/weston \
     "
 
-CONFFILES:${PN} += "${sysconfdir}/xdg/weston/weston.ini ${sysconfdir}/default/weston"
+CONFFILES:${PN} += "${sysconfdir}/xdg/weston/weston.ini ${sysconfdir}/emptty/conf"
+RPROVIDES:${PN} += "virtual-emptty-conf"
 
-SYSTEMD_SERVICE:${PN} = "weston.service weston.socket"
-USERADD_PARAM:${PN} = "--home /home/weston --shell /bin/sh --user-group -G video,input,render,seat,wayland weston"
-GROUPADD_PARAM:${PN} = "-r wayland; -r render; -r seat"
+USERADD_PARAM:${PN} = "--home /home/weston --shell /bin/sh --user-group -G video,input,render,seat,nopasswdlogin weston"
+GROUPADD_PARAM:${PN} = "-r nopasswdlogin; -r render; -r seat"
diff --git a/meta/recipes-graphics/wayland/weston-init/emptty.conf b/meta/recipes-graphics/wayland/weston-init/emptty.conf
new file mode 100644
index 0000000000..1918cc02a7
--- /dev/null
+++ b/meta/recipes-graphics/wayland/weston-init/emptty.conf
@@ -0,0 +1,77 @@
+# TTY, where emptty will start.
+TTY_NUMBER=7
+
+# Enables switching to defined TTY number.
+SWITCH_TTY=true
+
+# Enables printing of /etc/issue in daemon mode.
+PRINT_ISSUE=true
+
+# Enables printing of default motd, /etc/emptty/motd or /etc/emptty/motd-gen.sh.
+PRINT_MOTD=true
+
+# Preselected user, if AUTOLOGIN is enabled, this user is logged in.
+DEFAULT_USER=weston
+
+# Enables Autologin, if DEFAULT_USER is defined and part of nopasswdlogin group. Possible values are "true" or "false".
+AUTOLOGIN=true
+
+# The default session used, if Autologin is enabled. If session is not found in list of session, it proceeds to manual selection.
+AUTOLOGIN_SESSION=Weston
+
+# If Autologin is enabled and session does not start correctly, the number of retries in short period is kept to eventually stop the infinite loop of restarts. -1 is for infinite retries, 0 is for no retry.
+# AUTOLOGIN_MAX_RETRY=2
+
+# Default LANG, if user does not have set own in init script.
+#LANG=en_US.UTF-8
+
+# Starts desktop with calling "dbus-launch".
+DBUS_LAUNCH=true
+
+# Starts Xorg desktop with calling "~/.xinitrc" script, if is true, file exists and selected WM/DE is Xorg session, it overrides DBUS_LAUNCH.
+XINITRC_LAUNCH=false
+
+# Prints available WM/DE each on new line instead of printing on single line.
+VERTICAL_SELECTION=false
+
+# Defines the way, how is logging handled. Possible values are "rotate", "appending" or "disabled".
+#LOGGING=rotate
+
+# Overrides path of log file
+#LOGGING_FILE=/var/log/emptty/[TTY_NUMBER].log
+
+# Arguments passed to Xorg server.
+#XORG_ARGS=
+
+# Allows to use dynamic motd script to generate custom MOTD.
+#DYNAMIC_MOTD=false
+
+# Allows to override default path to dynamic motd.
+#DYNAMIC_MOTD_PATH=/etc/emptty/motd-gen.sh
+
+# Allows to override default path to static motd.
+#MOTD_PATH=/etc/emptty/motd
+
+# Foreground color, available only in daemon mode.
+#FG_COLOR=LIGHT_BLACK
+
+# Background color, available only in daemon mode.
+#BG_COLOR=BLACK
+
+# Enables numlock in daemon mode. Possible values are "true" or "false".
+#ENABLE_NUMLOCK=false
+
+# Defines the way, how is logging of session errors handled. Possible values are "rotate", "appending" or "disabled".
+SESSION_ERROR_LOGGING=rotate
+
+# Overrides path of session errors log file
+#SESSION_ERROR_LOGGING_FILE=/var/log/emptty/session-errors.[TTY_NUMBER].log
+
+# If set true, it will not use `.emptty-xauth` file, but the standard `~/.Xauthority` file. This allows to handle xauth issues.
+#DEFAULT_XAUTHORITY=false
+
+#If set true, Xorg will be started as rootless, if system allows and emptty is running in daemon mode.
+#ROOTLESS_XORG=false
+
+#If set true, environmental groups are printed to differ Xorg/Wayland/Custom/UserCustom desktops.
+IDENTIFY_ENVS=false
diff --git a/meta/recipes-graphics/wayland/weston-init/init b/meta/recipes-graphics/wayland/weston-init/init
deleted file mode 100644
index a5c54e001e..0000000000
--- a/meta/recipes-graphics/wayland/weston-init/init
+++ /dev/null
@@ -1,54 +0,0 @@
-#!/bin/sh
-#
-### BEGIN INIT INFO
-# Provides: weston
-# Required-Start: $local_fs $remote_fs
-# Required-Stop: $local_fs $remote_fs
-# Default-Start:     2 3 4 5
-# Default-Stop:      0 1 6
-### END INIT INFO
-
-if test -e /etc/default/weston ; then
-        . /etc/default/weston
-fi
-
-killproc() {
-        pid=`/bin/pidof $1`
-        [ "$pid" != "" ] && kill $pid
-}
-
-read CMDLINE < /proc/cmdline
-for x in $CMDLINE; do
-        case $x in
-        weston=false)
-		echo "Weston disabled"
-		exit 0;
-                ;;
-        esac
-done
-
-case "$1" in
-  start)
-        . /etc/profile
-	      export HOME=ROOTHOME
-
-        WESTON_USER=weston weston-start $OPTARGS &
-  ;;
-
-  stop)
-        echo "Stopping Weston"
-        killproc weston
-  ;;
-
-  restart)
-	$0 stop
-        sleep 1
-        $0 start
-  ;;
-
-  *)
-        echo "usage: $0 { start | stop | restart }"
-  ;;
-esac
-
-exit 0
diff --git a/meta/recipes-graphics/wayland/weston-init/weston-autologin b/meta/recipes-graphics/wayland/weston-init/weston-autologin
deleted file mode 100644
index f6e6d106de..0000000000
--- a/meta/recipes-graphics/wayland/weston-init/weston-autologin
+++ /dev/null
@@ -1,11 +0,0 @@
-auth      required  pam_nologin.so
-auth      required  pam_unix.so     try_first_pass nullok
-
-account   required  pam_nologin.so
-account   required  pam_unix.so
-
-session   required  pam_env.so
-session   required  pam_unix.so
--session  optional  pam_systemd.so type=wayland class=user desktop=weston
--session  optional  pam_loginuid.so
-
diff --git a/meta/recipes-graphics/wayland/weston-init/weston-socket.sh b/meta/recipes-graphics/wayland/weston-init/weston-socket.sh
deleted file mode 100755
index 86389d63a3..0000000000
--- a/meta/recipes-graphics/wayland/weston-init/weston-socket.sh
+++ /dev/null
@@ -1,20 +0,0 @@
-#!/bin/sh
-
-# set weston variables for use with global weston socket
-global_socket="/run/wayland-0"
-if [ -e "$global_socket" ]; then
-	weston_group=$(stat -c "%G" "$global_socket")
-	if [ "$(id -u)" = "0" ]; then
-		export WAYLAND_DISPLAY="$global_socket"
-	else
-		case "$(groups "$USER")" in
-			*"$weston_group"*)
-				export WAYLAND_DISPLAY="$global_socket"
-				;;
-			*)
-				;;
-		esac
-	fi
-	unset weston_group
-fi
-unset global_socket
diff --git a/meta/recipes-graphics/wayland/weston-init/weston-start b/meta/recipes-graphics/wayland/weston-init/weston-start
deleted file mode 100755
index 3b13a0047a..0000000000
--- a/meta/recipes-graphics/wayland/weston-init/weston-start
+++ /dev/null
@@ -1,76 +0,0 @@
-#!/bin/sh
-# Copyright (C) 2016 O.S. Systems Software LTDA.
-# Copyright (C) 2016 Freescale Semiconductor
-
-export PATH="/sbin:/usr/sbin:/bin:/usr/bin"
-
-usage() {
-	cat <<EOF
-	$0 [<weston options>]
-EOF
-}
-
-## Module support
-modules_dir=@DATADIR@/weston-start
-
-# Add weston extra argument
-add_weston_argument() {
-	weston_args="$weston_args $1"
-}
-
-## Add module to --modules argument
-add_weston_module() {
-	if [[ "x${weston_modules}" == "x" ]]; then
-		weston_modules="--modules "
-	fi;
-	weston_modules+="${1},"
-}
-
-if [ -n "$WAYLAND_DISPLAY" ]; then
-	echo "ERROR: A Wayland compositor is already running, nested Weston instance is not supported yet."
-	exit 1
-fi
-
-if [ -n "$WESTON_USER" ]; then
-	if [ -z "$WESTON_GROUP" ]; then
-		# no explicit WESTON_GROUP given, therefore use WESTON_USER
-		export WESTON_GROUP="${WESTON_USER}"
-	fi
-fi
-
-weston_args=$*
-
-# Load and run modules
-if [ -d "$modules_dir" ]; then
-	for m in "$modules_dir"/*; do
-		# Skip backup files
-		if [ "`echo $m | sed -e 's/\~$//'`" != "$m" ]; then
-			continue
-		fi
-
-		# process module
-		. $m
-		if [[ x"{$weston_modules}" != "x" ]]; then
-			add_weston_argument "${weston_modules}"
-		fi;
-	done
-fi
-
-if test -z "$XDG_RUNTIME_DIR"; then
-	export XDG_RUNTIME_DIR=/run/user/`id -u ${WESTON_USER}`
-	if test -d "$XDG_RUNTIME_DIR"; then
-	    # Check permissions on existing directory
-	    if [ "$(stat -c %u-%a "$XDG_RUNTIME_DIR")" != "$(id -u ${WESTON_USER})-700" ]; then
-			echo "ERROR: $XDG_RUNTIME_DIR has incorrect permissions"
-			exit 1
-		fi
-	else
-		mkdir --mode 0700 --parents $XDG_RUNTIME_DIR
-		if [ -n "$WESTON_USER" ]
-		then
-			chown $WESTON_USER:$WESTON_GROUP $XDG_RUNTIME_DIR
-		fi
-	fi
-fi
-
-su -c "XDG_RUNTIME_DIR=$XDG_RUNTIME_DIR weston $weston_args --log=/tmp/weston.log" $WESTON_USER
diff --git a/meta/recipes-graphics/wayland/weston-init/weston.env b/meta/recipes-graphics/wayland/weston-init/weston.env
deleted file mode 100644
index e69de29bb2..0000000000
diff --git a/meta/recipes-graphics/wayland/weston-init/weston.service b/meta/recipes-graphics/wayland/weston-init/weston.service
deleted file mode 100644
index 80745998ed..0000000000
--- a/meta/recipes-graphics/wayland/weston-init/weston.service
+++ /dev/null
@@ -1,71 +0,0 @@
-# This is a system unit for launching Weston with auto-login as the
-# user configured here.
-#
-# Weston must be built with systemd support, and your weston.ini must load
-# the plugin systemd-notify.so.
-[Unit]
-Description=Weston, a Wayland compositor, as a system service
-Documentation=man:weston(1) man:weston.ini(5)
-Documentation=http://wayland.freedesktop.org/
-
-# Make sure we are started after logins are permitted.
-Requires=systemd-user-sessions.service
-After=systemd-user-sessions.service
-
-# If Plymouth is used, we want to start when it is on its way out.
-After=plymouth-quit-wait.service
-
-# D-Bus is necessary for contacting logind. Logind is required.
-Wants=dbus.socket
-After=dbus.socket
-
-# Ensure the socket is present
-Requires=weston.socket
-
-# Since we are part of the graphical session, make sure we are started before
-# it is complete.
-Before=graphical.target
-
-# Prevent starting on systems without virtual consoles, Weston requires one
-# for now.
-ConditionPathExists=/dev/tty0
-
-[Service]
-# Requires systemd-notify.so Weston plugin.
-Type=notify
-EnvironmentFile=/etc/default/weston
-ExecStart=/usr/bin/weston --modules=systemd-notify.so
-
-# Optional watchdog setup
-#TimeoutStartSec=60
-#WatchdogSec=20
-
-# The user to run Weston as.
-User=weston
-Group=weston
-
-# Make sure the working directory is the users home directory
-WorkingDirectory=/home/weston
-
-# Set up a full user session for the user, required by Weston.
-PAMName=weston-autologin
-
-# A virtual terminal is needed.
-TTYPath=/dev/tty7
-TTYReset=yes
-TTYVHangup=yes
-TTYVTDisallocate=yes
-
-# Fail to start if not controlling the tty.
-StandardInput=tty-fail
-StandardOutput=journal
-StandardError=journal
-
-# Log this user with utmp, letting it show up with commands 'w' and 'who'.
-UtmpIdentifier=tty7
-UtmpMode=user
-
-[Install]
-# Note: If you only want weston to start on-demand, remove this line with a
-# service drop file
-WantedBy=graphical.target
diff --git a/meta/recipes-graphics/wayland/weston-init/weston.socket b/meta/recipes-graphics/wayland/weston-init/weston.socket
deleted file mode 100644
index c1bdc83c05..0000000000
--- a/meta/recipes-graphics/wayland/weston-init/weston.socket
+++ /dev/null
@@ -1,14 +0,0 @@
-[Unit]
-Description=Weston socket
-RequiresMountsFor=/run
-
-[Socket]
-ListenStream=/run/wayland-0
-SocketMode=0775
-SocketUser=weston
-SocketGroup=wayland
-RemoveOnStop=yes
-
-[Install]
-WantedBy=sockets.target
-
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [oe-core][PATCHv9 5/6] weston: remove deprecated weston-start scripts
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
                   ` (3 preceding siblings ...)
  2025-09-18 21:48 ` [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf rs
@ 2025-09-18 21:49 ` rs
  2025-09-18 21:49 ` [oe-core][PATCHv9 6/6] xserver-nodm-init: convert to virtual-emptty-conf rs
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 23+ messages in thread
From: rs @ 2025-09-18 21:49 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

The weston-start scripts are not parsed unless using the old version of
weston-init. These files are no longer required since weston-init moved
to a virtual-emptty-conf.

Signed-off-by: Randolph Sapp <rs@ti.com>
---
 .../wayland/weston/systemd-notify.weston-start         |  9 ---------
 .../wayland/weston/xwayland.weston-start               |  6 ------
 meta/recipes-graphics/wayland/weston_14.0.2.bb         | 10 ----------
 3 files changed, 25 deletions(-)
 delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
 delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start

diff --git a/meta/recipes-graphics/wayland/weston/systemd-notify.weston-start b/meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
deleted file mode 100644
index a97e7b38d9..0000000000
--- a/meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
+++ /dev/null
@@ -1,9 +0,0 @@
-#!/bin/sh
-  
-# SPDX-FileCopyrightText: Huawei Inc.
-# SPDX-License-Identifier: Apache-2.0
-
-
-if [[ -x "/usr/lib/weston/systemd-notify.so" ]]; then
-        add_weston_module "systemd-notify.so"
-fi
diff --git a/meta/recipes-graphics/wayland/weston/xwayland.weston-start b/meta/recipes-graphics/wayland/weston/xwayland.weston-start
deleted file mode 100644
index 342ac8d129..0000000000
--- a/meta/recipes-graphics/wayland/weston/xwayland.weston-start
+++ /dev/null
@@ -1,6 +0,0 @@
-#!/bin/sh
-
-if type Xwayland  >/dev/null 2>/dev/null; then
-	mkdir -m 775 -p /tmp/.X11-unix
-	chown root:video /tmp/.X11-unix
-fi
diff --git a/meta/recipes-graphics/wayland/weston_14.0.2.bb b/meta/recipes-graphics/wayland/weston_14.0.2.bb
index 451fb961a1..7a9d7f63f0 100644
--- a/meta/recipes-graphics/wayland/weston_14.0.2.bb
+++ b/meta/recipes-graphics/wayland/weston_14.0.2.bb
@@ -9,8 +9,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=d79ee9e66bb0f95d3386a7acae780b70 \
 SRC_URI = "https://gitlab.freedesktop.org/wayland/weston/-/releases/${PV}/downloads/${BPN}-${PV}.tar.xz \
            file://weston.png \
            file://weston.desktop \
-           file://xwayland.weston-start \
-           file://systemd-notify.weston-start \
            "
 
 SRC_URI[sha256sum] = "b47216b3530da76d02a3a1acbf1846a9cd41d24caa86448f9c46f78f20b6e0ac"
@@ -107,14 +105,6 @@ do_install:append() {
 		install ${UNPACKDIR}/weston.png ${D}${datadir}/icons/hicolor/48x48/apps
 	fi
 
-	if [ "${@bb.utils.contains('PACKAGECONFIG', 'xwayland', 'yes', 'no', d)}" = "yes" ]; then
-		install -Dm 644 ${UNPACKDIR}/xwayland.weston-start ${D}${datadir}/weston-start/xwayland
-	fi
-
-	if [ "${@bb.utils.contains('PACKAGECONFIG', 'systemd', 'yes', 'no', d)}" = "yes" ]; then
-		install -Dm 644 ${UNPACKDIR}/systemd-notify.weston-start ${D}${datadir}/weston-start/systemd-notify
-	fi
-
 	if [ "${@bb.utils.contains('PACKAGECONFIG', 'launch', 'yes', 'no', d)}" = "yes" ]; then
 		chmod u+s ${D}${bindir}/weston-launch
 	fi
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* [oe-core][PATCHv9 6/6] xserver-nodm-init: convert to virtual-emptty-conf
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
                   ` (4 preceding siblings ...)
  2025-09-18 21:49 ` [oe-core][PATCHv9 5/6] weston: remove deprecated weston-start scripts rs
@ 2025-09-18 21:49 ` rs
  2025-09-18 22:25 ` [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland Joshua Watt
  2025-09-21 12:25 ` Mathieu Dubois-Briand
  7 siblings, 0 replies; 23+ messages in thread
From: rs @ 2025-09-18 21:49 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

From: Randolph Sapp <rs@ti.com>

Convert this script package into a simple config for emptty. This is
capable of using either the root user or the underprivileged xuser
account based on the same ROOTLESS_X variable. The xuser will leverage
the nopasswdlogin session provided by emptty for automatic logins.
Runtime provide virtual-emptty-conf as we need to set parameters for the
default session.

This also gets rid of the xuser security/capability override since
emptty sets up required components as root before decending into the
specified user. This does not currently handle loading of autostart
applications in "/etc/xdg/autostart".

License-Update: GPLv2 scripts were replaced with MIT based config files
Signed-off-by: Randolph Sapp <rs@ti.com>
---
 meta/conf/distro/include/maintainers.inc      |   4 +-
 meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
 .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
 .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
 .../X11/Xsession.d/89xdgautostart.sh          |   7 -
 .../X11/Xsession.d/90XWindowManager.sh        |   7 -
 .../x11-common/xserver-nodm-init/Xserver      |  25 --
 .../xserver-nodm-init/capability.conf         |   2 -
 .../xserver-nodm-init/default.desktop         |   5 +
 .../xserver-nodm-init/emptty.conf.in}         |   8 +-
 .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
 .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
 .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
 .../xserver-nodm-init/xserver-nodm.service.in |  11 -
 .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
 .../user-creation/xuser-account_0.1.bb        |   3 +-
 16 files changed, 37 insertions(+), 594 deletions(-)
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
 create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
 copy meta/recipes-graphics/{wayland/weston-init/emptty.conf => x11-common/xserver-nodm-init/emptty.conf.in} (95%)
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
 delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
 delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in

diff --git a/meta/conf/distro/include/maintainers.inc b/meta/conf/distro/include/maintainers.inc
index db5e2fa9c9..621bf32066 100644
--- a/meta/conf/distro/include/maintainers.inc
+++ b/meta/conf/distro/include/maintainers.inc
@@ -926,12 +926,12 @@ RECIPE_MAINTAINER:pn-xorgproto = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xprop = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xrandr = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xrestop = "Unassigned <unassigned@yoctoproject.org>"
-RECIPE_MAINTAINER:pn-xserver-nodm-init = "Unassigned <unassigned@yoctoproject.org>"
+RECIPE_MAINTAINER:pn-xserver-nodm-init = "Randolph Sapp <rs@ti.com>"
 RECIPE_MAINTAINER:pn-xserver-xf86-config = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xserver-xorg = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xset = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xtrans = "Unassigned <unassigned@yoctoproject.org>"
-RECIPE_MAINTAINER:pn-xuser-account = "Unassigned <unassigned@yoctoproject.org>"
+RECIPE_MAINTAINER:pn-xuser-account = "Randolph Sapp <rs@ti.com>"
 RECIPE_MAINTAINER:pn-xvinfo = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xwayland = "Unassigned <unassigned@yoctoproject.org>"
 RECIPE_MAINTAINER:pn-xwininfo = "Unassigned <unassigned@yoctoproject.org>"
diff --git a/meta/lib/oeqa/runtime/cases/xorg.py b/meta/lib/oeqa/runtime/cases/xorg.py
index 09afb1e3d1..8593be5b77 100644
--- a/meta/lib/oeqa/runtime/cases/xorg.py
+++ b/meta/lib/oeqa/runtime/cases/xorg.py
@@ -20,4 +20,12 @@ class XorgTest(OERuntimeTestCase):
         status, output = self.target.run(cmd)
         msg = ('Xorg does not appear to be running %s' %
               self.target.run(self.tc.target_cmds['ps'])[1])
+
+        # dump last 20 lines of emptty log in case of failure
+        log_cmd = 'tail -n 20 /var/log/emptty/7.log'
+        msg += '\n\n===== start: snippet =====\n\n'
+        msg += 'file: /var/log/emptty/7.log\n\n'
+        msg += '\n\n%s\n\n' % self.target.run(log_cmd)[1]
+        msg += '\n\n===== end: snippet =====\n\n'
+
         self.assertEqual(status, 0, msg=msg)
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession b/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
deleted file mode 100644
index 0b73127ae1..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
+++ /dev/null
@@ -1,38 +0,0 @@
-#!/bin/sh
-
-if [ -x /usr/bin/dbus-launch ]; then
-    # As this is the X session script, always start a new DBus session.
-    eval `dbus-launch --sh-syntax --exit-with-session </dev/null`
-    echo "D-BUS per-session daemon address is: $DBUS_SESSION_BUS_ADDRESS"
-fi
-
-. /etc/profile
-
-if [ -f $HOME/.profile ]; then
-    . $HOME/.profile
-fi
-
-SYSSESSIONDIR=/etc/X11/Xsession.d
-
-export CLUTTER_DISABLE_MIPMAPPED_TEXT=1
-
-for SESSIONFILE in $SYSSESSIONDIR/*; do
-    set +e
-    case "$SESSIONFILE" in
-        *.sh)
-            . "$SESSIONFILE"
-            ;;
-        *.shbg)
-            "$SESSIONFILE" &
-            ;;
-        *~)
-            # Ignore backup files
-            ;;
-        *)
-            "$SESSIONFILE"
-            ;;
-    esac
-    set -e
-done
-
-exit 0
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh b/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
deleted file mode 100644
index 912f79761c..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
+++ /dev/null
@@ -1,19 +0,0 @@
-# Minimal/stub implementation of the XDG Base Directory specification.
-# http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html
-
-# If the runtime directory hasn't been set already (for example by systemd,
-# elogind, or pam) create a directory in TMPDIR.
-if [ -z "$XDG_RUNTIME_DIR" ]; then
-    XDG_RUNTIME_DIR=/run/user/$(id -u)
-    export XDG_RUNTIME_DIR
-fi
-
-if [ -d "$XDG_RUNTIME_DIR" ]; then
-    # If the directory exists, check the permissions and ownership
-    if [ "$(stat -c %u-%a "$XDG_RUNTIME_DIR")" != "$(id -u)-700" ]; then
-        echo "ERROR: $XDG_RUNTIME_DIR has incorrect permissions"
-        exit 1
-    fi
-else
-    mkdir --mode 0700 --parents "${XDG_RUNTIME_DIR}"
-fi
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh b/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
deleted file mode 100644
index 3d7008ca45..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
+++ /dev/null
@@ -1,7 +0,0 @@
-XDGAUTOSTART=/etc/xdg/autostart
-if [ -d $XDGAUTOSTART ]; then
-    for SCRIPT in $XDGAUTOSTART/*; do
-        CMD=`grep ^Exec= $SCRIPT | cut -d '=' -f 2`
-        $CMD &
-    done
-fi
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh b/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
deleted file mode 100644
index b936dedf3b..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
+++ /dev/null
@@ -1,7 +0,0 @@
-if [ -x $HOME/.Xsession ]; then
-    exec $HOME/.Xsession
-elif [ -x /usr/bin/x-session-manager ]; then
-    exec /usr/bin/x-session-manager
-else
-    exec /usr/bin/x-window-manager
-fi
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver b/meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
deleted file mode 100644
index 0edbfbfc20..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
+++ /dev/null
@@ -1,25 +0,0 @@
-#!/bin/sh
-
-# This script is only needed to make sure /etc/X11/xserver-common
-# can affect XSERVER, ARGS & DPI: otherwise systemd could just use
-# /etc/default/xserver-nodm as EnvironmentFile and sysvinit could just
-# source the same file
-
-. /etc/profile
-
-# load default values for XSERVER, ARGS, DISPLAY...
-. /etc/default/xserver-nodm
-
-# Allow xserver-common to override ARGS, XSERVER, DPI
-if [ -e /etc/X11/xserver-common ] ; then
-    . /etc/X11/xserver-common
-    if [ ! -e $XSERVER ] ; then
-        XSERVER=$(which $XSERVER)
-    fi
-fi
-
-if [ -n "$DPI" ] ; then
-    ARGS="$ARGS -dpi $DPI"
-fi
-
-exec xinit /etc/X11/Xsession -- $XSERVER $DISPLAY $ARGS $*
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf b/meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
deleted file mode 100644
index 7ab7460816..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
+++ /dev/null
@@ -1,2 +0,0 @@
-cap_sys_admin	@USER@
-none	*
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop b/meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
new file mode 100644
index 0000000000..3357cd9a7f
--- /dev/null
+++ b/meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
@@ -0,0 +1,5 @@
+[Desktop Entry]
+Encoding=UTF-8
+Type=Application
+Name=Default X11 Desktop
+Exec=x-session-manager
diff --git a/meta/recipes-graphics/wayland/weston-init/emptty.conf b/meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
similarity index 95%
copy from meta/recipes-graphics/wayland/weston-init/emptty.conf
copy to meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
index 1918cc02a7..406a6d1249 100644
--- a/meta/recipes-graphics/wayland/weston-init/emptty.conf
+++ b/meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
@@ -11,13 +11,13 @@ PRINT_ISSUE=true
 PRINT_MOTD=true
 
 # Preselected user, if AUTOLOGIN is enabled, this user is logged in.
-DEFAULT_USER=weston
+DEFAULT_USER=@USER@
 
 # Enables Autologin, if DEFAULT_USER is defined and part of nopasswdlogin group. Possible values are "true" or "false".
 AUTOLOGIN=true
 
 # The default session used, if Autologin is enabled. If session is not found in list of session, it proceeds to manual selection.
-AUTOLOGIN_SESSION=Weston
+AUTOLOGIN_SESSION=Default X11 Desktop
 
 # If Autologin is enabled and session does not start correctly, the number of retries in short period is kept to eventually stop the infinite loop of restarts. -1 is for infinite retries, 0 is for no retry.
 # AUTOLOGIN_MAX_RETRY=2
@@ -41,7 +41,7 @@ VERTICAL_SELECTION=false
 #LOGGING_FILE=/var/log/emptty/[TTY_NUMBER].log
 
 # Arguments passed to Xorg server.
-#XORG_ARGS=
+XORG_ARGS=@NO_CURSOR_ARG@ @BLANK_ARGS@
 
 # Allows to use dynamic motd script to generate custom MOTD.
 #DYNAMIC_MOTD=false
@@ -71,7 +71,7 @@ SESSION_ERROR_LOGGING=rotate
 #DEFAULT_XAUTHORITY=false
 
 #If set true, Xorg will be started as rootless, if system allows and emptty is running in daemon mode.
-#ROOTLESS_XORG=false
+ROOTLESS_XORG=@ROOTLESS_X_ARG@
 
 #If set true, environmental groups are printed to differ Xorg/Wayland/Custom/UserCustom desktops.
 IDENTIFY_ENVS=false
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch b/meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
deleted file mode 100644
index eff975e341..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
+++ /dev/null
@@ -1,355 +0,0 @@
-COPYING: add GPLv2 license file
-
-this is a local file recipe and the license file is missing.In order
-to pass the license checksum checking, the license file is needed. So
-this patch add the GPLv2 license file.
-
-Upstream-Status: Inappropriate [licensing]
-
-Signed-off-by: Yu Ke <ke.yu@intel.com>
-
-diff --git a/COPYING b/COPYING
-new file mode 100644
-index 0000000..d511905
---- /dev/null
-+++ b/COPYING
-@@ -0,0 +1,339 @@
-+		    GNU GENERAL PUBLIC LICENSE
-+		       Version 2, June 1991
-+
-+ Copyright (C) 1989, 1991 Free Software Foundation, Inc.,
-+ 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
-+ Everyone is permitted to copy and distribute verbatim copies
-+ of this license document, but changing it is not allowed.
-+
-+			    Preamble
-+
-+  The licenses for most software are designed to take away your
-+freedom to share and change it.  By contrast, the GNU General Public
-+License is intended to guarantee your freedom to share and change free
-+software--to make sure the software is free for all its users.  This
-+General Public License applies to most of the Free Software
-+Foundation's software and to any other program whose authors commit to
-+using it.  (Some other Free Software Foundation software is covered by
-+the GNU Lesser General Public License instead.)  You can apply it to
-+your programs, too.
-+
-+  When we speak of free software, we are referring to freedom, not
-+price.  Our General Public Licenses are designed to make sure that you
-+have the freedom to distribute copies of free software (and charge for
-+this service if you wish), that you receive source code or can get it
-+if you want it, that you can change the software or use pieces of it
-+in new free programs; and that you know you can do these things.
-+
-+  To protect your rights, we need to make restrictions that forbid
-+anyone to deny you these rights or to ask you to surrender the rights.
-+These restrictions translate to certain responsibilities for you if you
-+distribute copies of the software, or if you modify it.
-+
-+  For example, if you distribute copies of such a program, whether
-+gratis or for a fee, you must give the recipients all the rights that
-+you have.  You must make sure that they, too, receive or can get the
-+source code.  And you must show them these terms so they know their
-+rights.
-+
-+  We protect your rights with two steps: (1) copyright the software, and
-+(2) offer you this license which gives you legal permission to copy,
-+distribute and/or modify the software.
-+
-+  Also, for each author's protection and ours, we want to make certain
-+that everyone understands that there is no warranty for this free
-+software.  If the software is modified by someone else and passed on, we
-+want its recipients to know that what they have is not the original, so
-+that any problems introduced by others will not reflect on the original
-+authors' reputations.
-+
-+  Finally, any free program is threatened constantly by software
-+patents.  We wish to avoid the danger that redistributors of a free
-+program will individually obtain patent licenses, in effect making the
-+program proprietary.  To prevent this, we have made it clear that any
-+patent must be licensed for everyone's free use or not licensed at all.
-+
-+  The precise terms and conditions for copying, distribution and
-+modification follow.
-+
-+		    GNU GENERAL PUBLIC LICENSE
-+   TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION
-+
-+  0. This License applies to any program or other work which contains
-+a notice placed by the copyright holder saying it may be distributed
-+under the terms of this General Public License.  The "Program", below,
-+refers to any such program or work, and a "work based on the Program"
-+means either the Program or any derivative work under copyright law:
-+that is to say, a work containing the Program or a portion of it,
-+either verbatim or with modifications and/or translated into another
-+language.  (Hereinafter, translation is included without limitation in
-+the term "modification".)  Each licensee is addressed as "you".
-+
-+Activities other than copying, distribution and modification are not
-+covered by this License; they are outside its scope.  The act of
-+running the Program is not restricted, and the output from the Program
-+is covered only if its contents constitute a work based on the
-+Program (independent of having been made by running the Program).
-+Whether that is true depends on what the Program does.
-+
-+  1. You may copy and distribute verbatim copies of the Program's
-+source code as you receive it, in any medium, provided that you
-+conspicuously and appropriately publish on each copy an appropriate
-+copyright notice and disclaimer of warranty; keep intact all the
-+notices that refer to this License and to the absence of any warranty;
-+and give any other recipients of the Program a copy of this License
-+along with the Program.
-+
-+You may charge a fee for the physical act of transferring a copy, and
-+you may at your option offer warranty protection in exchange for a fee.
-+
-+  2. You may modify your copy or copies of the Program or any portion
-+of it, thus forming a work based on the Program, and copy and
-+distribute such modifications or work under the terms of Section 1
-+above, provided that you also meet all of these conditions:
-+
-+    a) You must cause the modified files to carry prominent notices
-+    stating that you changed the files and the date of any change.
-+
-+    b) You must cause any work that you distribute or publish, that in
-+    whole or in part contains or is derived from the Program or any
-+    part thereof, to be licensed as a whole at no charge to all third
-+    parties under the terms of this License.
-+
-+    c) If the modified program normally reads commands interactively
-+    when run, you must cause it, when started running for such
-+    interactive use in the most ordinary way, to print or display an
-+    announcement including an appropriate copyright notice and a
-+    notice that there is no warranty (or else, saying that you provide
-+    a warranty) and that users may redistribute the program under
-+    these conditions, and telling the user how to view a copy of this
-+    License.  (Exception: if the Program itself is interactive but
-+    does not normally print such an announcement, your work based on
-+    the Program is not required to print an announcement.)
-+
-+These requirements apply to the modified work as a whole.  If
-+identifiable sections of that work are not derived from the Program,
-+and can be reasonably considered independent and separate works in
-+themselves, then this License, and its terms, do not apply to those
-+sections when you distribute them as separate works.  But when you
-+distribute the same sections as part of a whole which is a work based
-+on the Program, the distribution of the whole must be on the terms of
-+this License, whose permissions for other licensees extend to the
-+entire whole, and thus to each and every part regardless of who wrote it.
-+
-+Thus, it is not the intent of this section to claim rights or contest
-+your rights to work written entirely by you; rather, the intent is to
-+exercise the right to control the distribution of derivative or
-+collective works based on the Program.
-+
-+In addition, mere aggregation of another work not based on the Program
-+with the Program (or with a work based on the Program) on a volume of
-+a storage or distribution medium does not bring the other work under
-+the scope of this License.
-+
-+  3. You may copy and distribute the Program (or a work based on it,
-+under Section 2) in object code or executable form under the terms of
-+Sections 1 and 2 above provided that you also do one of the following:
-+
-+    a) Accompany it with the complete corresponding machine-readable
-+    source code, which must be distributed under the terms of Sections
-+    1 and 2 above on a medium customarily used for software interchange; or,
-+
-+    b) Accompany it with a written offer, valid for at least three
-+    years, to give any third party, for a charge no more than your
-+    cost of physically performing source distribution, a complete
-+    machine-readable copy of the corresponding source code, to be
-+    distributed under the terms of Sections 1 and 2 above on a medium
-+    customarily used for software interchange; or,
-+
-+    c) Accompany it with the information you received as to the offer
-+    to distribute corresponding source code.  (This alternative is
-+    allowed only for noncommercial distribution and only if you
-+    received the program in object code or executable form with such
-+    an offer, in accord with Subsection b above.)
-+
-+The source code for a work means the preferred form of the work for
-+making modifications to it.  For an executable work, complete source
-+code means all the source code for all modules it contains, plus any
-+associated interface definition files, plus the scripts used to
-+control compilation and installation of the executable.  However, as a
-+special exception, the source code distributed need not include
-+anything that is normally distributed (in either source or binary
-+form) with the major components (compiler, kernel, and so on) of the
-+operating system on which the executable runs, unless that component
-+itself accompanies the executable.
-+
-+If distribution of executable or object code is made by offering
-+access to copy from a designated place, then offering equivalent
-+access to copy the source code from the same place counts as
-+distribution of the source code, even though third parties are not
-+compelled to copy the source along with the object code.
-+
-+  4. You may not copy, modify, sublicense, or distribute the Program
-+except as expressly provided under this License.  Any attempt
-+otherwise to copy, modify, sublicense or distribute the Program is
-+void, and will automatically terminate your rights under this License.
-+However, parties who have received copies, or rights, from you under
-+this License will not have their licenses terminated so long as such
-+parties remain in full compliance.
-+
-+  5. You are not required to accept this License, since you have not
-+signed it.  However, nothing else grants you permission to modify or
-+distribute the Program or its derivative works.  These actions are
-+prohibited by law if you do not accept this License.  Therefore, by
-+modifying or distributing the Program (or any work based on the
-+Program), you indicate your acceptance of this License to do so, and
-+all its terms and conditions for copying, distributing or modifying
-+the Program or works based on it.
-+
-+  6. Each time you redistribute the Program (or any work based on the
-+Program), the recipient automatically receives a license from the
-+original licensor to copy, distribute or modify the Program subject to
-+these terms and conditions.  You may not impose any further
-+restrictions on the recipients' exercise of the rights granted herein.
-+You are not responsible for enforcing compliance by third parties to
-+this License.
-+
-+  7. If, as a consequence of a court judgment or allegation of patent
-+infringement or for any other reason (not limited to patent issues),
-+conditions are imposed on you (whether by court order, agreement or
-+otherwise) that contradict the conditions of this License, they do not
-+excuse you from the conditions of this License.  If you cannot
-+distribute so as to satisfy simultaneously your obligations under this
-+License and any other pertinent obligations, then as a consequence you
-+may not distribute the Program at all.  For example, if a patent
-+license would not permit royalty-free redistribution of the Program by
-+all those who receive copies directly or indirectly through you, then
-+the only way you could satisfy both it and this License would be to
-+refrain entirely from distribution of the Program.
-+
-+If any portion of this section is held invalid or unenforceable under
-+any particular circumstance, the balance of the section is intended to
-+apply and the section as a whole is intended to apply in other
-+circumstances.
-+
-+It is not the purpose of this section to induce you to infringe any
-+patents or other property right claims or to contest validity of any
-+such claims; this section has the sole purpose of protecting the
-+integrity of the free software distribution system, which is
-+implemented by public license practices.  Many people have made
-+generous contributions to the wide range of software distributed
-+through that system in reliance on consistent application of that
-+system; it is up to the author/donor to decide if he or she is willing
-+to distribute software through any other system and a licensee cannot
-+impose that choice.
-+
-+This section is intended to make thoroughly clear what is believed to
-+be a consequence of the rest of this License.
-+
-+  8. If the distribution and/or use of the Program is restricted in
-+certain countries either by patents or by copyrighted interfaces, the
-+original copyright holder who places the Program under this License
-+may add an explicit geographical distribution limitation excluding
-+those countries, so that distribution is permitted only in or among
-+countries not thus excluded.  In such case, this License incorporates
-+the limitation as if written in the body of this License.
-+
-+  9. The Free Software Foundation may publish revised and/or new versions
-+of the General Public License from time to time.  Such new versions will
-+be similar in spirit to the present version, but may differ in detail to
-+address new problems or concerns.
-+
-+Each version is given a distinguishing version number.  If the Program
-+specifies a version number of this License which applies to it and "any
-+later version", you have the option of following the terms and conditions
-+either of that version or of any later version published by the Free
-+Software Foundation.  If the Program does not specify a version number of
-+this License, you may choose any version ever published by the Free Software
-+Foundation.
-+
-+  10. If you wish to incorporate parts of the Program into other free
-+programs whose distribution conditions are different, write to the author
-+to ask for permission.  For software which is copyrighted by the Free
-+Software Foundation, write to the Free Software Foundation; we sometimes
-+make exceptions for this.  Our decision will be guided by the two goals
-+of preserving the free status of all derivatives of our free software and
-+of promoting the sharing and reuse of software generally.
-+
-+			    NO WARRANTY
-+
-+  11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY
-+FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW.  EXCEPT WHEN
-+OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES
-+PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED
-+OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
-+MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.  THE ENTIRE RISK AS
-+TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU.  SHOULD THE
-+PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING,
-+REPAIR OR CORRECTION.
-+
-+  12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING
-+WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR
-+REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES,
-+INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING
-+OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED
-+TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY
-+YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER
-+PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE
-+POSSIBILITY OF SUCH DAMAGES.
-+
-+		     END OF TERMS AND CONDITIONS
-+
-+	    How to Apply These Terms to Your New Programs
-+
-+  If you develop a new program, and you want it to be of the greatest
-+possible use to the public, the best way to achieve this is to make it
-+free software which everyone can redistribute and change under these terms.
-+
-+  To do so, attach the following notices to the program.  It is safest
-+to attach them to the start of each source file to most effectively
-+convey the exclusion of warranty; and each file should have at least
-+the "copyright" line and a pointer to where the full notice is found.
-+
-+    <one line to give the program's name and a brief idea of what it does.>
-+    Copyright (C) <year>  <name of author>
-+
-+    This program is free software; you can redistribute it and/or modify
-+    it under the terms of the GNU General Public License as published by
-+    the Free Software Foundation; either version 2 of the License, or
-+    (at your option) any later version.
-+
-+    This program is distributed in the hope that it will be useful,
-+    but WITHOUT ANY WARRANTY; without even the implied warranty of
-+    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-+    GNU General Public License for more details.
-+
-+    You should have received a copy of the GNU General Public License along
-+    with this program; if not, write to the Free Software Foundation, Inc.,
-+    51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
-+
-+Also add information on how to contact you by electronic and paper mail.
-+
-+If the program is interactive, make it output a short notice like this
-+when it starts in an interactive mode:
-+
-+    Gnomovision version 69, Copyright (C) year name of author
-+    Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'.
-+    This is free software, and you are welcome to redistribute it
-+    under certain conditions; type `show c' for details.
-+
-+The hypothetical commands `show w' and `show c' should show the appropriate
-+parts of the General Public License.  Of course, the commands you use may
-+be called something other than `show w' and `show c'; they could even be
-+mouse-clicks or menu items--whatever suits your program.
-+
-+You should also get your employer (if you work as a programmer) or your
-+school, if any, to sign a "copyright disclaimer" for the program, if
-+necessary.  Here is a sample; alter the names:
-+
-+  Yoyodyne, Inc., hereby disclaims all copyright interest in the program
-+  `Gnomovision' (which makes passes at compilers) written by James Hacker.
-+
-+  <signature of Ty Coon>, 1 April 1989
-+  Ty Coon, President of Vice
-+
-+This General Public License does not permit incorporating your program into
-+proprietary programs.  If your program is a subroutine library, you may
-+consider it more useful to permit linking proprietary applications with the
-+library.  If this is what you want to do, use the GNU Lesser General
-+Public License instead of this License.
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
deleted file mode 100755
index 116bb278bc..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
+++ /dev/null
@@ -1,75 +0,0 @@
-#!/bin/sh
-#
-### BEGIN INIT INFO
-# Provides: xserver
-# Required-Start: $local_fs $remote_fs dbus
-# Required-Stop: $local_fs $remote_fs
-# Default-Start:     5
-# Default-Stop:      0 1 2 3 6
-### END INIT INFO
-
-killproc() {            # kill the named process(es)
-        pid=`/bin/pidof $1`
-        [ "$pid" != "" ] && kill $pid
-}
-
-read CMDLINE < /proc/cmdline
-for x in $CMDLINE; do
-        case $x in
-        x11=false)
-		echo "X Server disabled" 
-		exit 0;
-                ;;
-        esac
-done
-
-case "$1" in
-  start)
-       . /etc/profile
-
-       #default for USER
-       . /etc/default/xserver-nodm
-       echo "Starting Xserver"
-       if [ "$USER" != "root" ]; then
-           # setting for rootless X
-           chmod o+w /var/log
-           chmod g+r /dev/tty[0-3]
-           # hidraw device is probably needed
-           if [ -e /dev/hidraw0 ]; then
-               chmod o+rw /dev/hidraw*
-           fi
-           # Make sure that the Xorg has the cap_sys_admin capability which is
-           # needed for setting the drm master
-           if ! grep -q "^auth.*pam_cap\.so" /etc/pam.d/su; then
-               echo "auth	optional	pam_cap.so" >>/etc/pam.d/su
-           fi
-           if ! /usr/sbin/getcap $XSERVER |  grep -q cap_sys_admin; then
-               /usr/sbin/setcap cap_sys_admin+eip $XSERVER
-           fi
-       fi
-
-       # Using su rather than sudo as latest 1.8.1 cause failure [YOCTO #1211]
-       su -l -c '/etc/xserver-nodm/Xserver &' $USER
-       # Wait for the desktop to say its finished loading
-       # before loading the rest of the system
-       # dbus-wait org.matchbox_project.desktop Loaded
-  ;;
-
-  stop)
-        echo "Stopping XServer"
-        killproc xinit
-        sleep 1
-        chvt 1 &
-  ;;
-
-  restart)
-	$0 stop
-        $0 start
-  ;;
-
-  *)
-        echo "usage: $0 { start | stop | restart }"
-  ;;
-esac
-
-exit 0
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
deleted file mode 100644
index 4a9670d8d2..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
+++ /dev/null
@@ -1,7 +0,0 @@
-# common environment file for sysvinit and systemd
-
-XSERVER=/usr/bin/Xorg
-DISPLAY=:0
-ARGS=" -br -pn @BLANK_ARGS@ @NO_CURSOR_ARG@ "
-HOME=@HOME@
-USER=@USER@
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in b/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
deleted file mode 100644
index 87dc4f8fcd..0000000000
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
+++ /dev/null
@@ -1,11 +0,0 @@
-[Unit]
-Description=Xserver startup without a display manager
-
-[Service]
-EnvironmentFile=/etc/default/xserver-nodm
-User=@USER@
-ExecStart=/etc/xserver-nodm/Xserver
-Restart=always
-
-[Install]
-Alias=display-manager.service
diff --git a/meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb b/meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb
index 169269eefb..ea3a90db7c 100644
--- a/meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb
+++ b/meta/recipes-graphics/x11-common/xserver-nodm-init_3.0.bb
@@ -1,23 +1,17 @@
 SUMMARY = "Simple Xserver Init Script (no dm)"
-LICENSE = "GPL-2.0-only"
-LIC_FILES_CHKSUM = "file://COPYING;md5=751419260aa954499f7abaabaa882bbe"
+LICENSE = "MIT"
+LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
 SECTION = "x11"
 
-SRC_URI = "file://xserver-nodm \
-           file://Xserver \
-           file://X11 \
-           file://gplv2-license.patch \
-           file://xserver-nodm.service.in \
-           file://xserver-nodm.conf.in \
-           file://capability.conf \
-"
+SRC_URI = "file://emptty.conf.in \
+           file://default.desktop"
 
 S = "${UNPACKDIR}"
 
 # Since we refer to ROOTLESS_X which is normally enabled per-machine
 PACKAGE_ARCH = "${MACHINE_ARCH}"
 
-inherit update-rc.d systemd features_check
+inherit features_check
 
 REQUIRED_DISTRO_FEATURES = "x11 ${@oe.utils.conditional('ROOTLESS_X', '1', 'pam', '', d)}"
 
@@ -27,45 +21,26 @@ PACKAGECONFIG[blank] = ""
 PACKAGECONFIG[nocursor] = ""
 
 do_install() {
-    install -d ${D}${sysconfdir}/default
-    install xserver-nodm.conf.in ${D}${sysconfdir}/default/xserver-nodm
-    install -d ${D}${sysconfdir}/xserver-nodm
-    install Xserver ${D}${sysconfdir}/xserver-nodm/Xserver
-    install -d ${D}${sysconfdir}/X11/Xsession.d
-    install X11/Xsession.d/* ${D}${sysconfdir}/X11/Xsession.d/
-    install X11/Xsession ${D}${sysconfdir}/X11/
+    install -D -p -m0644 ${S}/emptty.conf.in ${D}${sysconfdir}/emptty/conf
+    install -D -p -m0644 ${S}/default.desktop ${D}${datadir}/xsessions/default.desktop
 
     BLANK_ARGS="${@bb.utils.contains('PACKAGECONFIG', 'blank', '', '-s 0 -dpms', d)}"
     NO_CURSOR_ARG="${@bb.utils.contains('PACKAGECONFIG', 'nocursor', '-nocursor', '', d)}"
+    ROOTLESS_X_ARG="${@oe.utils.conditional('ROOTLESS_X', '1', 'true', 'false', d)}"
     if [ "${ROOTLESS_X}" = "1" ] ; then
-        XUSER_HOME="/home/xuser"
         XUSER="xuser"
-        install -D capability.conf ${D}${sysconfdir}/security/capability.conf
-        sed -i "s:@USER@:${XUSER}:" ${D}${sysconfdir}/security/capability.conf
     else
-        XUSER_HOME=${ROOT_HOME}
         XUSER="root"
     fi
-    sed -i "s:@HOME@:${XUSER_HOME}:; s:@USER@:${XUSER}:; s:@BLANK_ARGS@:${BLANK_ARGS}:" \
-        ${D}${sysconfdir}/default/xserver-nodm
-    sed -i "s:@NO_CURSOR_ARG@:${NO_CURSOR_ARG}:" ${D}${sysconfdir}/default/xserver-nodm
-
-    if ${@bb.utils.contains('DISTRO_FEATURES','systemd','true','false',d)}; then
-        install -d ${D}${systemd_system_unitdir}
-        install -m 0644 ${S}/xserver-nodm.service.in ${D}${systemd_system_unitdir}/xserver-nodm.service
-        sed -i "s:@USER@:${XUSER}:" ${D}${systemd_system_unitdir}/xserver-nodm.service
-    fi
-
-    if ${@bb.utils.contains('DISTRO_FEATURES','sysvinit','true','false',d)}; then
-        install -d ${D}${sysconfdir}/init.d
-        install xserver-nodm ${D}${sysconfdir}/init.d
-    fi
+    sed -i "s:@USER@:${XUSER}:" ${D}${sysconfdir}/emptty/conf
+    sed -i "s:@NO_CURSOR_ARG@:${NO_CURSOR_ARG}:" ${D}${sysconfdir}/emptty/conf
+    sed -i "s:@BLANK_ARGS@:${BLANK_ARGS}:" ${D}${sysconfdir}/emptty/conf
+    sed -i "s:@ROOTLESS_X_ARG@:${ROOTLESS_X_ARG}:" ${D}${sysconfdir}/emptty/conf
 }
 
-RDEPENDS:${PN} = "xinit ${@oe.utils.conditional('ROOTLESS_X', '1', 'xuser-account libcap libcap-bin', '', d)}"
-
-INITSCRIPT_NAME = "xserver-nodm"
-INITSCRIPT_PARAMS = "start 9 5 . stop 20 0 1 2 3 6 ."
-SYSTEMD_SERVICE:${PN} = "xserver-nodm.service"
+FILES:${PN} = "${sysconfdir}/emptty/conf \
+               ${datadir}/xsessions/default.desktop"
 
+RDEPENDS:${PN} = "emptty xinit ${@oe.utils.conditional('ROOTLESS_X', '1', 'xuser-account libcap libcap-bin', '', d)}"
+RPROVIDES:${PN} += "virtual-emptty-conf"
 RCONFLICTS:${PN} = "xserver-common (< 1.34-r9) x11-common"
diff --git a/meta/recipes-support/user-creation/xuser-account_0.1.bb b/meta/recipes-support/user-creation/xuser-account_0.1.bb
index 04f506e7a3..f1e4cb674f 100644
--- a/meta/recipes-support/user-creation/xuser-account_0.1.bb
+++ b/meta/recipes-support/user-creation/xuser-account_0.1.bb
@@ -24,7 +24,8 @@ FILES:${PN} = "${sysconfdir}/dbus-1/system.d/system-xuser.conf"
 
 USERADD_PACKAGES = "${PN}"
 USERADD_PARAM:${PN} = "--create-home \
-                       --groups video,tty,audio,input,shutdown,disk \
+                       --groups video,tty,audio,input,shutdown,disk,nopasswdlogin \
                        --user-group xuser"
+GROUPADD_PARAM:${PN} = "-r nopasswdlogin"
 
 ALLOW_EMPTY:${PN} = "1"
-- 
2.51.0



^ permalink raw reply related	[flat|nested] 23+ messages in thread

* Patchtest results for [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf
  2025-09-18 21:48 ` [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf rs
@ 2025-09-18 22:03   ` patchtest
  0 siblings, 0 replies; 23+ messages in thread
From: patchtest @ 2025-09-18 22:03 UTC (permalink / raw)
  To: rs; +Cc: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 2918 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/PATCHv9-4-6-weston-init-convert-to-virtual-emptty-conf.patch

FAIL: test max line length: Patch line too long (current length 256, maximum is 200) (test_metadata.TestMetadata.test_max_line_length)

PASS: pretest pylint (test_python_pylint.PyLint.pretest_pylint)
PASS: pretest src uri left files (test_metadata.TestMetadata.pretest_src_uri_left_files)
PASS: test CVE check ignore (test_metadata.TestMetadata.test_cve_check_ignore)
PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test lic files chksum modified not mentioned (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test pylint (test_python_pylint.PyLint.test_pylint)
PASS: test shortlog format (test_mbox.TestMbox.test_shortlog_format)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test src uri left files (test_metadata.TestMetadata.test_src_uri_left_files)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
                   ` (5 preceding siblings ...)
  2025-09-18 21:49 ` [oe-core][PATCHv9 6/6] xserver-nodm-init: convert to virtual-emptty-conf rs
@ 2025-09-18 22:25 ` Joshua Watt
  2025-09-18 22:31   ` Randolph Sapp
  2025-09-21 12:25 ` Mathieu Dubois-Briand
  7 siblings, 1 reply; 23+ messages in thread
From: Joshua Watt @ 2025-09-18 22:25 UTC (permalink / raw)
  To: rs
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>
> From: Randolph Sapp <rs@ti.com>
>
> We've recently run into some issues with weston-init attempting to start Weston
> prior to all drm devices being registered. There's not really a good, scriptable
> mechanism to listen in to device registration events that works with the
> existing weston-init package. Well, at least one that doesn't involve polling
> files or introducing more dependency on the init system being used.

It's not clear how switching to emptty actually solves that problem; I
don't see anything in my (brief) look at the emptty code that would
lead me to believe it actually cares about any drm devices being
present or handles devices showing up dynamically. Can you maybe
elaborate more on this?

>
> I also see there is also a lot of scripting around starting X11,
> xserver-nodm-init, that (from my limited review) should experience the same
> issue.
>
> I'd like to introduce the following display manager for oe-core, emptty [1].
> This display manager is, as described upstream, a "Dead simple CLI Display
> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
> which shouldn't be an issue for any users. (It is written in Go, if you have
> opinions about that.)
>
> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
> to leverage this display manager and simply add a user and emptty config for an
> autologin session. This can resolve the current behavior across init systems
> without additional scripting, and move some development out of this layer.
>
> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
> xuser-account since these are currently unassigned and I've reworked them
> significantly here.
>
> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
> to address before submitting this officially.
>
> [1] https://github.com/tvrzna/emptty
>
> v2:
>         - Address spelling issues in commit messages
>         - Attempt to resolve some test related issues with weston
>         - Add additional logs to X11 related tests
> v3:
>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
>           under QEMU the first auth attempt almost always fails.
> v4:
>         - Add a tmpfile entry for the x11 domain socket directory.
>         - Remove some scripts associated with weston-init that were being
>           shipped with weston
> v5:
>         - Move tmpfile data to individual files
>         - Add explicit entries for these in the FILES variable
> v6:
>         - Do not attempt to ship a tmpfiles.d entry in libx11
> v7:
>         - Include a backported fix for go/runtime to address segfault issues
>           reported on x86 platforms in previous revisions
> v8:
>         - Sign-off backported patch
> v9:
>         - Resolve merge conflict in maintainers file
>
> Randolph Sapp (6):
>   libx11: create tmpfile dir for x11 domain socket
>   go: fix sigaction usage on i386 platforms
>   emptty: add version 0.14.0
>   weston-init: convert to virtual-emptty-conf
>   weston: remove deprecated weston-start scripts
>   xserver-nodm-init: convert to virtual-emptty-conf
>
>  .../conf/distro/include/default-providers.inc |   1 +
>  meta/conf/distro/include/maintainers.inc      |   6 +-
>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
>  .../wayland/weston-init/emptty.conf           |  77 ++++
>  .../recipes-graphics/wayland/weston-init/init |  54 ---
>  .../wayland/weston-init/weston-autologin      |  11 -
>  .../wayland/weston-init/weston-socket.sh      |  20 -
>  .../wayland/weston-init/weston-start          |  76 ----
>  .../wayland/weston-init/weston.env            |   0
>  .../wayland/weston-init/weston.service        |  71 ----
>  .../wayland/weston-init/weston.socket         |  14 -
>  .../weston/systemd-notify.weston-start        |   9 -
>  .../wayland/weston/xwayland.weston-start      |   6 -
>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
>  .../xserver-nodm-init/capability.conf         |   2 -
>  .../xserver-nodm-init/default.desktop         |   5 +
>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
>  .../user-creation/xuser-account_0.1.bb        |   3 +-
>  39 files changed, 581 insertions(+), 918 deletions(-)
>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
>
> --
> 2.51.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
> Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [JPEWhacker@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 22:25 ` [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland Joshua Watt
@ 2025-09-18 22:31   ` Randolph Sapp
  2025-09-18 22:35     ` Joshua Watt
  0 siblings, 1 reply; 23+ messages in thread
From: Randolph Sapp @ 2025-09-18 22:31 UTC (permalink / raw)
  To: Joshua Watt
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu Sep 18, 2025 at 5:25 PM CDT, Joshua Watt wrote:
> On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
> lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>>
>> From: Randolph Sapp <rs@ti.com>
>>
>> We've recently run into some issues with weston-init attempting to start Weston
>> prior to all drm devices being registered. There's not really a good, scriptable
>> mechanism to listen in to device registration events that works with the
>> existing weston-init package. Well, at least one that doesn't involve polling
>> files or introducing more dependency on the init system being used.
>
> It's not clear how switching to emptty actually solves that problem; I
> don't see anything in my (brief) look at the emptty code that would
> lead me to believe it actually cares about any drm devices being
> present or handles devices showing up dynamically. Can you maybe
> elaborate more on this?

It doesn't currently have any tests to wait for the DRM device. I still need to
look into adding that, but what it currently does is add a retry event counter
and a small delay between retries that is better than the current console
implementations. Especially considering authentication is handled separately
from this retry process.

By centralizing display manager specific code, common checks and fallback logic
can be more easily implemented in the future. I'm hoping this lays the
groundwork to let me address some other issues I've seen in multi-card
environments as well.

>> I also see there is also a lot of scripting around starting X11,
>> xserver-nodm-init, that (from my limited review) should experience the same
>> issue.
>>
>> I'd like to introduce the following display manager for oe-core, emptty [1].
>> This display manager is, as described upstream, a "Dead simple CLI Display
>> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>> which shouldn't be an issue for any users. (It is written in Go, if you have
>> opinions about that.)
>>
>> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>> to leverage this display manager and simply add a user and emptty config for an
>> autologin session. This can resolve the current behavior across init systems
>> without additional scripting, and move some development out of this layer.
>>
>> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>> xuser-account since these are currently unassigned and I've reworked them
>> significantly here.
>>
>> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>> to address before submitting this officially.
>>
>> [1] https://github.com/tvrzna/emptty
>>
>> v2:
>>         - Address spelling issues in commit messages
>>         - Attempt to resolve some test related issues with weston
>>         - Add additional logs to X11 related tests
>> v3:
>>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
>>           under QEMU the first auth attempt almost always fails.
>> v4:
>>         - Add a tmpfile entry for the x11 domain socket directory.
>>         - Remove some scripts associated with weston-init that were being
>>           shipped with weston
>> v5:
>>         - Move tmpfile data to individual files
>>         - Add explicit entries for these in the FILES variable
>> v6:
>>         - Do not attempt to ship a tmpfiles.d entry in libx11
>> v7:
>>         - Include a backported fix for go/runtime to address segfault issues
>>           reported on x86 platforms in previous revisions
>> v8:
>>         - Sign-off backported patch
>> v9:
>>         - Resolve merge conflict in maintainers file
>>
>> Randolph Sapp (6):
>>   libx11: create tmpfile dir for x11 domain socket
>>   go: fix sigaction usage on i386 platforms
>>   emptty: add version 0.14.0
>>   weston-init: convert to virtual-emptty-conf
>>   weston: remove deprecated weston-start scripts
>>   xserver-nodm-init: convert to virtual-emptty-conf
>>
>>  .../conf/distro/include/default-providers.inc |   1 +
>>  meta/conf/distro/include/maintainers.inc      |   6 +-
>>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
>>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
>>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
>>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
>>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
>>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
>>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
>>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
>>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
>>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
>>  .../wayland/weston-init/emptty.conf           |  77 ++++
>>  .../recipes-graphics/wayland/weston-init/init |  54 ---
>>  .../wayland/weston-init/weston-autologin      |  11 -
>>  .../wayland/weston-init/weston-socket.sh      |  20 -
>>  .../wayland/weston-init/weston-start          |  76 ----
>>  .../wayland/weston-init/weston.env            |   0
>>  .../wayland/weston-init/weston.service        |  71 ----
>>  .../wayland/weston-init/weston.socket         |  14 -
>>  .../weston/systemd-notify.weston-start        |   9 -
>>  .../wayland/weston/xwayland.weston-start      |   6 -
>>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
>>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
>>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
>>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
>>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
>>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
>>  .../xserver-nodm-init/capability.conf         |   2 -
>>  .../xserver-nodm-init/default.desktop         |   5 +
>>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
>>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
>>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
>>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
>>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
>>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
>>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
>>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
>>  .../user-creation/xuser-account_0.1.bb        |   3 +-
>>  39 files changed, 581 insertions(+), 918 deletions(-)
>>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
>>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
>>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
>>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
>>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
>>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
>>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
>>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
>>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
>>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
>>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
>>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
>>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
>>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
>>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
>>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
>>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
>>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
>>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
>>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
>>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
>>
>> --
>> 2.51.0
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
>> Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [JPEWhacker@gmail.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 22:31   ` Randolph Sapp
@ 2025-09-18 22:35     ` Joshua Watt
  2025-09-18 22:39       ` Randolph Sapp
       [not found]       ` <186681957172BF4C.23626@lists.openembedded.org>
  0 siblings, 2 replies; 23+ messages in thread
From: Joshua Watt @ 2025-09-18 22:35 UTC (permalink / raw)
  To: Randolph Sapp
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu, Sep 18, 2025 at 4:31 PM Randolph Sapp <rs@ti.com> wrote:
>
> On Thu Sep 18, 2025 at 5:25 PM CDT, Joshua Watt wrote:
> > On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
> > lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
> >>
> >> From: Randolph Sapp <rs@ti.com>
> >>
> >> We've recently run into some issues with weston-init attempting to start Weston
> >> prior to all drm devices being registered. There's not really a good, scriptable
> >> mechanism to listen in to device registration events that works with the
> >> existing weston-init package. Well, at least one that doesn't involve polling
> >> files or introducing more dependency on the init system being used.
> >
> > It's not clear how switching to emptty actually solves that problem; I
> > don't see anything in my (brief) look at the emptty code that would
> > lead me to believe it actually cares about any drm devices being
> > present or handles devices showing up dynamically. Can you maybe
> > elaborate more on this?
>
> It doesn't currently have any tests to wait for the DRM device. I still need to
> look into adding that, but what it currently does is add a retry event counter
> and a small delay between retries that is better than the current console
> implementations. Especially considering authentication is handled separately
> from this retry process.
>
> By centralizing display manager specific code, common checks and fallback logic
> can be more easily implemented in the future. I'm hoping this lays the
> groundwork to let me address some other issues I've seen in multi-card
> environments as well.

For the systemd parts, is it also possible to solve this with e.g.

Requires=dev-dri-card0.device
After=dev-dri-card0.device

(or similar) ? Seems like anything emptty would be doing would be a
reimplementation of the logic that already exists in systemd to do
that.



>
> >> I also see there is also a lot of scripting around starting X11,
> >> xserver-nodm-init, that (from my limited review) should experience the same
> >> issue.
> >>
> >> I'd like to introduce the following display manager for oe-core, emptty [1].
> >> This display manager is, as described upstream, a "Dead simple CLI Display
> >> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
> >> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
> >> which shouldn't be an issue for any users. (It is written in Go, if you have
> >> opinions about that.)
> >>
> >> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
> >> to leverage this display manager and simply add a user and emptty config for an
> >> autologin session. This can resolve the current behavior across init systems
> >> without additional scripting, and move some development out of this layer.
> >>
> >> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
> >> xuser-account since these are currently unassigned and I've reworked them
> >> significantly here.
> >>
> >> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
> >> to address before submitting this officially.
> >>
> >> [1] https://github.com/tvrzna/emptty
> >>
> >> v2:
> >>         - Address spelling issues in commit messages
> >>         - Attempt to resolve some test related issues with weston
> >>         - Add additional logs to X11 related tests
> >> v3:
> >>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
> >>           under QEMU the first auth attempt almost always fails.
> >> v4:
> >>         - Add a tmpfile entry for the x11 domain socket directory.
> >>         - Remove some scripts associated with weston-init that were being
> >>           shipped with weston
> >> v5:
> >>         - Move tmpfile data to individual files
> >>         - Add explicit entries for these in the FILES variable
> >> v6:
> >>         - Do not attempt to ship a tmpfiles.d entry in libx11
> >> v7:
> >>         - Include a backported fix for go/runtime to address segfault issues
> >>           reported on x86 platforms in previous revisions
> >> v8:
> >>         - Sign-off backported patch
> >> v9:
> >>         - Resolve merge conflict in maintainers file
> >>
> >> Randolph Sapp (6):
> >>   libx11: create tmpfile dir for x11 domain socket
> >>   go: fix sigaction usage on i386 platforms
> >>   emptty: add version 0.14.0
> >>   weston-init: convert to virtual-emptty-conf
> >>   weston: remove deprecated weston-start scripts
> >>   xserver-nodm-init: convert to virtual-emptty-conf
> >>
> >>  .../conf/distro/include/default-providers.inc |   1 +
> >>  meta/conf/distro/include/maintainers.inc      |   6 +-
> >>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
> >>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
> >>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
> >>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
> >>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
> >>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
> >>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
> >>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
> >>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
> >>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
> >>  .../wayland/weston-init/emptty.conf           |  77 ++++
> >>  .../recipes-graphics/wayland/weston-init/init |  54 ---
> >>  .../wayland/weston-init/weston-autologin      |  11 -
> >>  .../wayland/weston-init/weston-socket.sh      |  20 -
> >>  .../wayland/weston-init/weston-start          |  76 ----
> >>  .../wayland/weston-init/weston.env            |   0
> >>  .../wayland/weston-init/weston.service        |  71 ----
> >>  .../wayland/weston-init/weston.socket         |  14 -
> >>  .../weston/systemd-notify.weston-start        |   9 -
> >>  .../wayland/weston/xwayland.weston-start      |   6 -
> >>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
> >>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
> >>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
> >>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
> >>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
> >>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
> >>  .../xserver-nodm-init/capability.conf         |   2 -
> >>  .../xserver-nodm-init/default.desktop         |   5 +
> >>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
> >>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
> >>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
> >>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
> >>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
> >>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
> >>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
> >>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
> >>  .../user-creation/xuser-account_0.1.bb        |   3 +-
> >>  39 files changed, 581 insertions(+), 918 deletions(-)
> >>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
> >>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
> >>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
> >>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
> >>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
> >>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
> >>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
> >>
> >> --
> >> 2.51.0
> >>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
> >> Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
> >> Group Owner: openembedded-core+owner@lists.openembedded.org
> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [JPEWhacker@gmail.com]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>
>


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 22:35     ` Joshua Watt
@ 2025-09-18 22:39       ` Randolph Sapp
       [not found]       ` <186681957172BF4C.23626@lists.openembedded.org>
  1 sibling, 0 replies; 23+ messages in thread
From: Randolph Sapp @ 2025-09-18 22:39 UTC (permalink / raw)
  To: Joshua Watt
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu Sep 18, 2025 at 5:35 PM CDT, Joshua Watt wrote:
> On Thu, Sep 18, 2025 at 4:31 PM Randolph Sapp <rs@ti.com> wrote:
>>
>> On Thu Sep 18, 2025 at 5:25 PM CDT, Joshua Watt wrote:
>> > On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
>> > lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>> >>
>> >> From: Randolph Sapp <rs@ti.com>
>> >>
>> >> We've recently run into some issues with weston-init attempting to start Weston
>> >> prior to all drm devices being registered. There's not really a good, scriptable
>> >> mechanism to listen in to device registration events that works with the
>> >> existing weston-init package. Well, at least one that doesn't involve polling
>> >> files or introducing more dependency on the init system being used.
>> >
>> > It's not clear how switching to emptty actually solves that problem; I
>> > don't see anything in my (brief) look at the emptty code that would
>> > lead me to believe it actually cares about any drm devices being
>> > present or handles devices showing up dynamically. Can you maybe
>> > elaborate more on this?
>>
>> It doesn't currently have any tests to wait for the DRM device. I still need to
>> look into adding that, but what it currently does is add a retry event counter
>> and a small delay between retries that is better than the current console
>> implementations. Especially considering authentication is handled separately
>> from this retry process.
>>
>> By centralizing display manager specific code, common checks and fallback logic
>> can be more easily implemented in the future. I'm hoping this lays the
>> groundwork to let me address some other issues I've seen in multi-card
>> environments as well.
>
> For the systemd parts, is it also possible to solve this with e.g.
>
> Requires=dev-dri-card0.device
> After=dev-dri-card0.device
>
> (or similar) ? Seems like anything emptty would be doing would be a
> reimplementation of the logic that already exists in systemd to do
> that.

It gets messy. A udev rule needs to be made to make systemd track that device.
In a multi-card environment a device without an actual display may be picked.
Systemd cannot directly solve the issue on it's own.

>> >> I also see there is also a lot of scripting around starting X11,
>> >> xserver-nodm-init, that (from my limited review) should experience the same
>> >> issue.
>> >>
>> >> I'd like to introduce the following display manager for oe-core, emptty [1].
>> >> This display manager is, as described upstream, a "Dead simple CLI Display
>> >> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>> >> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>> >> which shouldn't be an issue for any users. (It is written in Go, if you have
>> >> opinions about that.)
>> >>
>> >> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>> >> to leverage this display manager and simply add a user and emptty config for an
>> >> autologin session. This can resolve the current behavior across init systems
>> >> without additional scripting, and move some development out of this layer.
>> >>
>> >> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>> >> xuser-account since these are currently unassigned and I've reworked them
>> >> significantly here.
>> >>
>> >> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>> >> to address before submitting this officially.
>> >>
>> >> [1] https://github.com/tvrzna/emptty
>> >>
>> >> v2:
>> >>         - Address spelling issues in commit messages
>> >>         - Attempt to resolve some test related issues with weston
>> >>         - Add additional logs to X11 related tests
>> >> v3:
>> >>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
>> >>           under QEMU the first auth attempt almost always fails.
>> >> v4:
>> >>         - Add a tmpfile entry for the x11 domain socket directory.
>> >>         - Remove some scripts associated with weston-init that were being
>> >>           shipped with weston
>> >> v5:
>> >>         - Move tmpfile data to individual files
>> >>         - Add explicit entries for these in the FILES variable
>> >> v6:
>> >>         - Do not attempt to ship a tmpfiles.d entry in libx11
>> >> v7:
>> >>         - Include a backported fix for go/runtime to address segfault issues
>> >>           reported on x86 platforms in previous revisions
>> >> v8:
>> >>         - Sign-off backported patch
>> >> v9:
>> >>         - Resolve merge conflict in maintainers file
>> >>
>> >> Randolph Sapp (6):
>> >>   libx11: create tmpfile dir for x11 domain socket
>> >>   go: fix sigaction usage on i386 platforms
>> >>   emptty: add version 0.14.0
>> >>   weston-init: convert to virtual-emptty-conf
>> >>   weston: remove deprecated weston-start scripts
>> >>   xserver-nodm-init: convert to virtual-emptty-conf
>> >>
>> >>  .../conf/distro/include/default-providers.inc |   1 +
>> >>  meta/conf/distro/include/maintainers.inc      |   6 +-
>> >>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
>> >>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
>> >>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
>> >>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
>> >>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
>> >>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
>> >>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
>> >>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
>> >>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
>> >>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
>> >>  .../wayland/weston-init/emptty.conf           |  77 ++++
>> >>  .../recipes-graphics/wayland/weston-init/init |  54 ---
>> >>  .../wayland/weston-init/weston-autologin      |  11 -
>> >>  .../wayland/weston-init/weston-socket.sh      |  20 -
>> >>  .../wayland/weston-init/weston-start          |  76 ----
>> >>  .../wayland/weston-init/weston.env            |   0
>> >>  .../wayland/weston-init/weston.service        |  71 ----
>> >>  .../wayland/weston-init/weston.socket         |  14 -
>> >>  .../weston/systemd-notify.weston-start        |   9 -
>> >>  .../wayland/weston/xwayland.weston-start      |   6 -
>> >>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
>> >>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
>> >>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
>> >>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
>> >>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
>> >>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
>> >>  .../xserver-nodm-init/capability.conf         |   2 -
>> >>  .../xserver-nodm-init/default.desktop         |   5 +
>> >>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
>> >>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
>> >>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
>> >>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
>> >>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
>> >>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
>> >>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
>> >>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
>> >>  .../user-creation/xuser-account_0.1.bb        |   3 +-
>> >>  39 files changed, 581 insertions(+), 918 deletions(-)
>> >>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
>> >>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
>> >>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
>> >>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
>> >>
>> >> --
>> >> 2.51.0
>> >>
>> >>
>> >> -=-=-=-=-=-=-=-=-=-=-=-
>> >> Links: You receive all messages sent to this group.
>> >> View/Reply Online (#223699): https://lists.openembedded.org/g/openembedded-core/message/223699
>> >> Mute This Topic: https://lists.openembedded.org/mt/115318655/3616693
>> >> Group Owner: openembedded-core+owner@lists.openembedded.org
>> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [JPEWhacker@gmail.com]
>> >> -=-=-=-=-=-=-=-=-=-=-=-
>> >>
>>



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
       [not found]       ` <186681957172BF4C.23626@lists.openembedded.org>
@ 2025-09-18 22:42         ` Randolph Sapp
  2025-09-18 23:03           ` Joshua Watt
  0 siblings, 1 reply; 23+ messages in thread
From: Randolph Sapp @ 2025-09-18 22:42 UTC (permalink / raw)
  To: rs, Joshua Watt
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu Sep 18, 2025 at 5:39 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> On Thu Sep 18, 2025 at 5:35 PM CDT, Joshua Watt wrote:
>> On Thu, Sep 18, 2025 at 4:31 PM Randolph Sapp <rs@ti.com> wrote:
>>>
>>> On Thu Sep 18, 2025 at 5:25 PM CDT, Joshua Watt wrote:
>>> > On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
>>> > lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>>> >>
>>> >> From: Randolph Sapp <rs@ti.com>
>>> >>
>>> >> We've recently run into some issues with weston-init attempting to start Weston
>>> >> prior to all drm devices being registered. There's not really a good, scriptable
>>> >> mechanism to listen in to device registration events that works with the
>>> >> existing weston-init package. Well, at least one that doesn't involve polling
>>> >> files or introducing more dependency on the init system being used.
>>> >
>>> > It's not clear how switching to emptty actually solves that problem; I
>>> > don't see anything in my (brief) look at the emptty code that would
>>> > lead me to believe it actually cares about any drm devices being
>>> > present or handles devices showing up dynamically. Can you maybe
>>> > elaborate more on this?
>>>
>>> It doesn't currently have any tests to wait for the DRM device. I still need to
>>> look into adding that, but what it currently does is add a retry event counter
>>> and a small delay between retries that is better than the current console
>>> implementations. Especially considering authentication is handled separately
>>> from this retry process.
>>>
>>> By centralizing display manager specific code, common checks and fallback logic
>>> can be more easily implemented in the future. I'm hoping this lays the
>>> groundwork to let me address some other issues I've seen in multi-card
>>> environments as well.
>>
>> For the systemd parts, is it also possible to solve this with e.g.
>>
>> Requires=dev-dri-card0.device
>> After=dev-dri-card0.device
>>
>> (or similar) ? Seems like anything emptty would be doing would be a
>> reimplementation of the logic that already exists in systemd to do
>> that.
>
> It gets messy. A udev rule needs to be made to make systemd track that device.
> In a multi-card environment a device without an actual display may be picked.
> Systemd cannot directly solve the issue on it's own.

Additionally, there are more init systems supported here than just systemd...

>>> >> I also see there is also a lot of scripting around starting X11,
>>> >> xserver-nodm-init, that (from my limited review) should experience the same
>>> >> issue.
>>> >>
>>> >> I'd like to introduce the following display manager for oe-core, emptty [1].
>>> >> This display manager is, as described upstream, a "Dead simple CLI Display
>>> >> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>>> >> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>>> >> which shouldn't be an issue for any users. (It is written in Go, if you have
>>> >> opinions about that.)
>>> >>
>>> >> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>>> >> to leverage this display manager and simply add a user and emptty config for an
>>> >> autologin session. This can resolve the current behavior across init systems
>>> >> without additional scripting, and move some development out of this layer.
>>> >>
>>> >> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>>> >> xuser-account since these are currently unassigned and I've reworked them
>>> >> significantly here.
>>> >>
>>> >> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>>> >> to address before submitting this officially.
>>> >>
>>> >> [1] https://github.com/tvrzna/emptty
>>> >>
>>> >> v2:
>>> >>         - Address spelling issues in commit messages
>>> >>         - Attempt to resolve some test related issues with weston
>>> >>         - Add additional logs to X11 related tests
>>> >> v3:
>>> >>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
>>> >>           under QEMU the first auth attempt almost always fails.
>>> >> v4:
>>> >>         - Add a tmpfile entry for the x11 domain socket directory.
>>> >>         - Remove some scripts associated with weston-init that were being
>>> >>           shipped with weston
>>> >> v5:
>>> >>         - Move tmpfile data to individual files
>>> >>         - Add explicit entries for these in the FILES variable
>>> >> v6:
>>> >>         - Do not attempt to ship a tmpfiles.d entry in libx11
>>> >> v7:
>>> >>         - Include a backported fix for go/runtime to address segfault issues
>>> >>           reported on x86 platforms in previous revisions
>>> >> v8:
>>> >>         - Sign-off backported patch
>>> >> v9:
>>> >>         - Resolve merge conflict in maintainers file
>>> >>
>>> >> Randolph Sapp (6):
>>> >>   libx11: create tmpfile dir for x11 domain socket
>>> >>   go: fix sigaction usage on i386 platforms
>>> >>   emptty: add version 0.14.0
>>> >>   weston-init: convert to virtual-emptty-conf
>>> >>   weston: remove deprecated weston-start scripts
>>> >>   xserver-nodm-init: convert to virtual-emptty-conf
>>> >>
>>> >>  .../conf/distro/include/default-providers.inc |   1 +
>>> >>  meta/conf/distro/include/maintainers.inc      |   6 +-
>>> >>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
>>> >>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
>>> >>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
>>> >>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
>>> >>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
>>> >>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
>>> >>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
>>> >>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
>>> >>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
>>> >>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
>>> >>  .../wayland/weston-init/emptty.conf           |  77 ++++
>>> >>  .../recipes-graphics/wayland/weston-init/init |  54 ---
>>> >>  .../wayland/weston-init/weston-autologin      |  11 -
>>> >>  .../wayland/weston-init/weston-socket.sh      |  20 -
>>> >>  .../wayland/weston-init/weston-start          |  76 ----
>>> >>  .../wayland/weston-init/weston.env            |   0
>>> >>  .../wayland/weston-init/weston.service        |  71 ----
>>> >>  .../wayland/weston-init/weston.socket         |  14 -
>>> >>  .../weston/systemd-notify.weston-start        |   9 -
>>> >>  .../wayland/weston/xwayland.weston-start      |   6 -
>>> >>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
>>> >>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
>>> >>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
>>> >>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
>>> >>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
>>> >>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
>>> >>  .../xserver-nodm-init/capability.conf         |   2 -
>>> >>  .../xserver-nodm-init/default.desktop         |   5 +
>>> >>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
>>> >>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
>>> >>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
>>> >>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
>>> >>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
>>> >>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
>>> >>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
>>> >>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
>>> >>  .../user-creation/xuser-account_0.1.bb        |   3 +-
>>> >>  39 files changed, 581 insertions(+), 918 deletions(-)
>>> >>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
>>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
>>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
>>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
>>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
>>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
>>> >>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
>>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
>>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
>>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
>>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
>>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
>>> >>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
>>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
>>> >>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
>>> >>
>>> >> --
>>> >> 2.51.0
>>> >>
>>> >>
>>> >> 
>>> >>
>>>



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 22:42         ` Randolph Sapp
@ 2025-09-18 23:03           ` Joshua Watt
  2025-09-18 23:13             ` Randolph Sapp
  0 siblings, 1 reply; 23+ messages in thread
From: Joshua Watt @ 2025-09-18 23:03 UTC (permalink / raw)
  To: Randolph Sapp
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu, Sep 18, 2025 at 4:42 PM Randolph Sapp <rs@ti.com> wrote:
>
> On Thu Sep 18, 2025 at 5:39 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> > On Thu Sep 18, 2025 at 5:35 PM CDT, Joshua Watt wrote:
> >> On Thu, Sep 18, 2025 at 4:31 PM Randolph Sapp <rs@ti.com> wrote:
> >>>
> >>> On Thu Sep 18, 2025 at 5:25 PM CDT, Joshua Watt wrote:
> >>> > On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
> >>> > lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
> >>> >>
> >>> >> From: Randolph Sapp <rs@ti.com>
> >>> >>
> >>> >> We've recently run into some issues with weston-init attempting to start Weston
> >>> >> prior to all drm devices being registered. There's not really a good, scriptable
> >>> >> mechanism to listen in to device registration events that works with the
> >>> >> existing weston-init package. Well, at least one that doesn't involve polling
> >>> >> files or introducing more dependency on the init system being used.
> >>> >
> >>> > It's not clear how switching to emptty actually solves that problem; I
> >>> > don't see anything in my (brief) look at the emptty code that would
> >>> > lead me to believe it actually cares about any drm devices being
> >>> > present or handles devices showing up dynamically. Can you maybe
> >>> > elaborate more on this?
> >>>
> >>> It doesn't currently have any tests to wait for the DRM device. I still need to
> >>> look into adding that, but what it currently does is add a retry event counter
> >>> and a small delay between retries that is better than the current console
> >>> implementations. Especially considering authentication is handled separately
> >>> from this retry process.
> >>>
> >>> By centralizing display manager specific code, common checks and fallback logic
> >>> can be more easily implemented in the future. I'm hoping this lays the
> >>> groundwork to let me address some other issues I've seen in multi-card
> >>> environments as well.
> >>
> >> For the systemd parts, is it also possible to solve this with e.g.
> >>
> >> Requires=dev-dri-card0.device
> >> After=dev-dri-card0.device
> >>
> >> (or similar) ? Seems like anything emptty would be doing would be a
> >> reimplementation of the logic that already exists in systemd to do
> >> that.
> >
> > It gets messy. A udev rule needs to be made to make systemd track that device.

Ya, that's pretty normal.

> > In a multi-card environment a device without an actual display may be picked.
> > Systemd cannot directly solve the issue on it's own.

Sure, but isn't that what udev is for? I don't think adding selection
of a drm device makes sense in emptty. Regardless of init system, it
really feels like selection of the correct device to use for display
should be a udev problem.

>
> Additionally, there are more init systems supported here than just systemd...
>
> >>> >> I also see there is also a lot of scripting around starting X11,
> >>> >> xserver-nodm-init, that (from my limited review) should experience the same
> >>> >> issue.
> >>> >>
> >>> >> I'd like to introduce the following display manager for oe-core, emptty [1].
> >>> >> This display manager is, as described upstream, a "Dead simple CLI Display
> >>> >> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
> >>> >> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
> >>> >> which shouldn't be an issue for any users. (It is written in Go, if you have
> >>> >> opinions about that.)
> >>> >>
> >>> >> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
> >>> >> to leverage this display manager and simply add a user and emptty config for an
> >>> >> autologin session. This can resolve the current behavior across init systems
> >>> >> without additional scripting, and move some development out of this layer.
> >>> >>
> >>> >> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
> >>> >> xuser-account since these are currently unassigned and I've reworked them
> >>> >> significantly here.
> >>> >>
> >>> >> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
> >>> >> to address before submitting this officially.
> >>> >>
> >>> >> [1] https://github.com/tvrzna/emptty
> >>> >>
> >>> >> v2:
> >>> >>         - Address spelling issues in commit messages
> >>> >>         - Attempt to resolve some test related issues with weston
> >>> >>         - Add additional logs to X11 related tests
> >>> >> v3:
> >>> >>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
> >>> >>           under QEMU the first auth attempt almost always fails.
> >>> >> v4:
> >>> >>         - Add a tmpfile entry for the x11 domain socket directory.
> >>> >>         - Remove some scripts associated with weston-init that were being
> >>> >>           shipped with weston
> >>> >> v5:
> >>> >>         - Move tmpfile data to individual files
> >>> >>         - Add explicit entries for these in the FILES variable
> >>> >> v6:
> >>> >>         - Do not attempt to ship a tmpfiles.d entry in libx11
> >>> >> v7:
> >>> >>         - Include a backported fix for go/runtime to address segfault issues
> >>> >>           reported on x86 platforms in previous revisions
> >>> >> v8:
> >>> >>         - Sign-off backported patch
> >>> >> v9:
> >>> >>         - Resolve merge conflict in maintainers file
> >>> >>
> >>> >> Randolph Sapp (6):
> >>> >>   libx11: create tmpfile dir for x11 domain socket
> >>> >>   go: fix sigaction usage on i386 platforms
> >>> >>   emptty: add version 0.14.0
> >>> >>   weston-init: convert to virtual-emptty-conf
> >>> >>   weston: remove deprecated weston-start scripts
> >>> >>   xserver-nodm-init: convert to virtual-emptty-conf
> >>> >>
> >>> >>  .../conf/distro/include/default-providers.inc |   1 +
> >>> >>  meta/conf/distro/include/maintainers.inc      |   6 +-
> >>> >>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
> >>> >>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
> >>> >>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
> >>> >>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
> >>> >>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
> >>> >>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
> >>> >>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
> >>> >>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
> >>> >>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
> >>> >>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
> >>> >>  .../wayland/weston-init/emptty.conf           |  77 ++++
> >>> >>  .../recipes-graphics/wayland/weston-init/init |  54 ---
> >>> >>  .../wayland/weston-init/weston-autologin      |  11 -
> >>> >>  .../wayland/weston-init/weston-socket.sh      |  20 -
> >>> >>  .../wayland/weston-init/weston-start          |  76 ----
> >>> >>  .../wayland/weston-init/weston.env            |   0
> >>> >>  .../wayland/weston-init/weston.service        |  71 ----
> >>> >>  .../wayland/weston-init/weston.socket         |  14 -
> >>> >>  .../weston/systemd-notify.weston-start        |   9 -
> >>> >>  .../wayland/weston/xwayland.weston-start      |   6 -
> >>> >>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
> >>> >>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
> >>> >>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
> >>> >>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
> >>> >>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
> >>> >>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
> >>> >>  .../xserver-nodm-init/capability.conf         |   2 -
> >>> >>  .../xserver-nodm-init/default.desktop         |   5 +
> >>> >>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
> >>> >>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
> >>> >>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
> >>> >>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
> >>> >>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
> >>> >>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
> >>> >>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
> >>> >>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
> >>> >>  .../user-creation/xuser-account_0.1.bb        |   3 +-
> >>> >>  39 files changed, 581 insertions(+), 918 deletions(-)
> >>> >>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
> >>> >>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
> >>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
> >>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
> >>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
> >>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
> >>> >>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
> >>> >>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
> >>> >>
> >>> >> --
> >>> >> 2.51.0
> >>> >>
> >>> >>
> >>> >>
> >>> >>
> >>>
>


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 23:03           ` Joshua Watt
@ 2025-09-18 23:13             ` Randolph Sapp
  0 siblings, 0 replies; 23+ messages in thread
From: Randolph Sapp @ 2025-09-18 23:13 UTC (permalink / raw)
  To: Joshua Watt, Randolph Sapp
  Cc: Mathieu Dubois-Briand, richard.purdie, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon, openembedded-core,
	vijayp

On Thu Sep 18, 2025 at 6:03 PM CDT, Joshua Watt wrote:
> On Thu, Sep 18, 2025 at 4:42 PM Randolph Sapp <rs@ti.com> wrote:
>>
>> On Thu Sep 18, 2025 at 5:39 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
>> > On Thu Sep 18, 2025 at 5:35 PM CDT, Joshua Watt wrote:
>> >> On Thu, Sep 18, 2025 at 4:31 PM Randolph Sapp <rs@ti.com> wrote:
>> >>>
>> >>> On Thu Sep 18, 2025 at 5:25 PM CDT, Joshua Watt wrote:
>> >>> > On Thu, Sep 18, 2025 at 3:49 PM Randolph Sapp via
>> >>> > lists.openembedded.org <rs=ti.com@lists.openembedded.org> wrote:
>> >>> >>
>> >>> >> From: Randolph Sapp <rs@ti.com>
>> >>> >>
>> >>> >> We've recently run into some issues with weston-init attempting to start Weston
>> >>> >> prior to all drm devices being registered. There's not really a good, scriptable
>> >>> >> mechanism to listen in to device registration events that works with the
>> >>> >> existing weston-init package. Well, at least one that doesn't involve polling
>> >>> >> files or introducing more dependency on the init system being used.
>> >>> >
>> >>> > It's not clear how switching to emptty actually solves that problem; I
>> >>> > don't see anything in my (brief) look at the emptty code that would
>> >>> > lead me to believe it actually cares about any drm devices being
>> >>> > present or handles devices showing up dynamically. Can you maybe
>> >>> > elaborate more on this?
>> >>>
>> >>> It doesn't currently have any tests to wait for the DRM device. I still need to
>> >>> look into adding that, but what it currently does is add a retry event counter
>> >>> and a small delay between retries that is better than the current console
>> >>> implementations. Especially considering authentication is handled separately
>> >>> from this retry process.
>> >>>
>> >>> By centralizing display manager specific code, common checks and fallback logic
>> >>> can be more easily implemented in the future. I'm hoping this lays the
>> >>> groundwork to let me address some other issues I've seen in multi-card
>> >>> environments as well.
>> >>
>> >> For the systemd parts, is it also possible to solve this with e.g.
>> >>
>> >> Requires=dev-dri-card0.device
>> >> After=dev-dri-card0.device
>> >>
>> >> (or similar) ? Seems like anything emptty would be doing would be a
>> >> reimplementation of the logic that already exists in systemd to do
>> >> that.
>> >
>> > It gets messy. A udev rule needs to be made to make systemd track that device.
>
> Ya, that's pretty normal.

Udev is dependent on systemd. Eudev exists, but why would we pull that in simply
to manage displays. It's not necessary for anything else at the moment.

>> > In a multi-card environment a device without an actual display may be picked.
>> > Systemd cannot directly solve the issue on it's own.
>
> Sure, but isn't that what udev is for? I don't think adding selection
> of a drm device makes sense in emptty. Regardless of init system, it
> really feels like selection of the correct device to use for display
> should be a udev problem.

Udev can track events but it does not report existing states. If a display is
already plugged in during boot then we won't know. We can catch the plug event
and operate on it, but otherwise it's a guess to see what we can do at boot.

For quite some time there has been a service to *manage displays* prior to
starting the desktop environment. GDM is a good example of that. Greetd is
another. Lightdm is another. Emptty is just an example of a useful all-rounder
with a permissive license I thought people would appreciate.

>> Additionally, there are more init systems supported here than just systemd...
>>
>> >>> >> I also see there is also a lot of scripting around starting X11,
>> >>> >> xserver-nodm-init, that (from my limited review) should experience the same
>> >>> >> issue.
>> >>> >>
>> >>> >> I'd like to introduce the following display manager for oe-core, emptty [1].
>> >>> >> This display manager is, as described upstream, a "Dead simple CLI Display
>> >>> >> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>> >>> >> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>> >>> >> which shouldn't be an issue for any users. (It is written in Go, if you have
>> >>> >> opinions about that.)
>> >>> >>
>> >>> >> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>> >>> >> to leverage this display manager and simply add a user and emptty config for an
>> >>> >> autologin session. This can resolve the current behavior across init systems
>> >>> >> without additional scripting, and move some development out of this layer.
>> >>> >>
>> >>> >> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>> >>> >> xuser-account since these are currently unassigned and I've reworked them
>> >>> >> significantly here.
>> >>> >>
>> >>> >> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>> >>> >> to address before submitting this officially.
>> >>> >>
>> >>> >> [1] https://github.com/tvrzna/emptty
>> >>> >>
>> >>> >> v2:
>> >>> >>         - Address spelling issues in commit messages
>> >>> >>         - Attempt to resolve some test related issues with weston
>> >>> >>         - Add additional logs to X11 related tests
>> >>> >> v3:
>> >>> >>         - Reset AUTOLOGIN_MAX_RETRY to the default value of 2. When running
>> >>> >>           under QEMU the first auth attempt almost always fails.
>> >>> >> v4:
>> >>> >>         - Add a tmpfile entry for the x11 domain socket directory.
>> >>> >>         - Remove some scripts associated with weston-init that were being
>> >>> >>           shipped with weston
>> >>> >> v5:
>> >>> >>         - Move tmpfile data to individual files
>> >>> >>         - Add explicit entries for these in the FILES variable
>> >>> >> v6:
>> >>> >>         - Do not attempt to ship a tmpfiles.d entry in libx11
>> >>> >> v7:
>> >>> >>         - Include a backported fix for go/runtime to address segfault issues
>> >>> >>           reported on x86 platforms in previous revisions
>> >>> >> v8:
>> >>> >>         - Sign-off backported patch
>> >>> >> v9:
>> >>> >>         - Resolve merge conflict in maintainers file
>> >>> >>
>> >>> >> Randolph Sapp (6):
>> >>> >>   libx11: create tmpfile dir for x11 domain socket
>> >>> >>   go: fix sigaction usage on i386 platforms
>> >>> >>   emptty: add version 0.14.0
>> >>> >>   weston-init: convert to virtual-emptty-conf
>> >>> >>   weston: remove deprecated weston-start scripts
>> >>> >>   xserver-nodm-init: convert to virtual-emptty-conf
>> >>> >>
>> >>> >>  .../conf/distro/include/default-providers.inc |   1 +
>> >>> >>  meta/conf/distro/include/maintainers.inc      |   6 +-
>> >>> >>  meta/lib/oeqa/runtime/cases/weston.py         |  18 +-
>> >>> >>  meta/lib/oeqa/runtime/cases/xorg.py           |   8 +
>> >>> >>  meta/recipes-devtools/go/go-1.25.0.inc        |   1 +
>> >>> >>  ...ng-cgo-on-386-call-C-sigaction-funct.patch | 248 ++++++++++++
>> >>> >>  meta/recipes-graphics/emptty/emptty-conf.bb   |  14 +
>> >>> >>  meta/recipes-graphics/emptty/emptty.inc       |  26 ++
>> >>> >>  .../recipes-graphics/emptty/emptty/emptty.tab |   1 +
>> >>> >>  meta/recipes-graphics/emptty/emptty/pamconf   |  10 +
>> >>> >>  meta/recipes-graphics/emptty/emptty_0.14.0.bb |  53 +++
>> >>> >>  meta/recipes-graphics/wayland/weston-init.bb  |  61 +--
>> >>> >>  .../wayland/weston-init/emptty.conf           |  77 ++++
>> >>> >>  .../recipes-graphics/wayland/weston-init/init |  54 ---
>> >>> >>  .../wayland/weston-init/weston-autologin      |  11 -
>> >>> >>  .../wayland/weston-init/weston-socket.sh      |  20 -
>> >>> >>  .../wayland/weston-init/weston-start          |  76 ----
>> >>> >>  .../wayland/weston-init/weston.env            |   0
>> >>> >>  .../wayland/weston-init/weston.service        |  71 ----
>> >>> >>  .../wayland/weston-init/weston.socket         |  14 -
>> >>> >>  .../weston/systemd-notify.weston-start        |   9 -
>> >>> >>  .../wayland/weston/xwayland.weston-start      |   6 -
>> >>> >>  .../recipes-graphics/wayland/weston_14.0.2.bb |  10 -
>> >>> >>  .../x11-common/xserver-nodm-init/X11/Xsession |  38 --
>> >>> >>  .../X11/Xsession.d/13xdgbasedirs.sh           |  19 -
>> >>> >>  .../X11/Xsession.d/89xdgautostart.sh          |   7 -
>> >>> >>  .../X11/Xsession.d/90XWindowManager.sh        |   7 -
>> >>> >>  .../x11-common/xserver-nodm-init/Xserver      |  25 --
>> >>> >>  .../xserver-nodm-init/capability.conf         |   2 -
>> >>> >>  .../xserver-nodm-init/default.desktop         |   5 +
>> >>> >>  .../xserver-nodm-init/emptty.conf.in          |  77 ++++
>> >>> >>  .../xserver-nodm-init/gplv2-license.patch     | 355 ------------------
>> >>> >>  .../x11-common/xserver-nodm-init/xserver-nodm |  75 ----
>> >>> >>  .../xserver-nodm-init/xserver-nodm.conf.in    |   7 -
>> >>> >>  .../xserver-nodm-init/xserver-nodm.service.in |  11 -
>> >>> >>  .../x11-common/xserver-nodm-init_3.0.bb       |  57 +--
>> >>> >>  meta/recipes-graphics/xorg-lib/libx11/99_x11  |   1 +
>> >>> >>  .../xorg-lib/libx11_1.8.12.bb                 |  15 +-
>> >>> >>  .../user-creation/xuser-account_0.1.bb        |   3 +-
>> >>> >>  39 files changed, 581 insertions(+), 918 deletions(-)
>> >>> >>  create mode 100644 meta/recipes-devtools/go/go/0001-runtime-when-using-cgo-on-386-call-C-sigaction-funct.patch
>> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty-conf.bb
>> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty.inc
>> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/emptty.tab
>> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty/pamconf
>> >>> >>  create mode 100644 meta/recipes-graphics/emptty/emptty_0.14.0.bb
>> >>> >>  create mode 100644 meta/recipes-graphics/wayland/weston-init/emptty.conf
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/init
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston-autologin
>> >>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-socket.sh
>> >>> >>  delete mode 100755 meta/recipes-graphics/wayland/weston-init/weston-start
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.env
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.service
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston-init/weston.socket
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/systemd-notify.weston-start
>> >>> >>  delete mode 100644 meta/recipes-graphics/wayland/weston/xwayland.weston-start
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/13xdgbasedirs.sh
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/89xdgautostart.sh
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/X11/Xsession.d/90XWindowManager.sh
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/Xserver
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/capability.conf
>> >>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/default.desktop
>> >>> >>  create mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/emptty.conf.in
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/gplv2-license.patch
>> >>> >>  delete mode 100755 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.conf.in
>> >>> >>  delete mode 100644 meta/recipes-graphics/x11-common/xserver-nodm-init/xserver-nodm.service.in
>> >>> >>  create mode 100644 meta/recipes-graphics/xorg-lib/libx11/99_x11
>> >>> >>
>> >>> >> --
>> >>> >> 2.51.0
>> >>> >>
>> >>> >>
>> >>> >>
>> >>> >>
>> >>>
>>



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
                   ` (6 preceding siblings ...)
  2025-09-18 22:25 ` [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland Joshua Watt
@ 2025-09-21 12:25 ` Mathieu Dubois-Briand
  2025-09-22 21:51   ` Randolph Sapp
       [not found]   ` <1867B951D10D3F9C.23856@lists.openembedded.org>
  7 siblings, 2 replies; 23+ messages in thread
From: Mathieu Dubois-Briand @ 2025-09-21 12:25 UTC (permalink / raw)
  To: rs, richard.purdie, ross.burton, alex, otavio, kexin.hao, afd,
	detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
> From: Randolph Sapp <rs@ti.com>
>
> We've recently run into some issues with weston-init attempting to start Weston
> prior to all drm devices being registered. There's not really a good, scriptable
> mechanism to listen in to device registration events that works with the
> existing weston-init package. Well, at least one that doesn't involve polling
> files or introducing more dependency on the init system being used.
>
> I also see there is also a lot of scripting around starting X11,
> xserver-nodm-init, that (from my limited review) should experience the same
> issue.
>
> I'd like to introduce the following display manager for oe-core, emptty [1].
> This display manager is, as described upstream, a "Dead simple CLI Display
> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
> which shouldn't be an issue for any users. (It is written in Go, if you have
> opinions about that.)
>
> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
> to leverage this display manager and simply add a user and emptty config for an
> autologin session. This can resolve the current behavior across init systems
> without additional scripting, and move some development out of this layer.
>
> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
> xuser-account since these are currently unassigned and I've reworked them
> significantly here.
>
> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
> to address before submitting this officially.
>

Hi Randolph,

Thanks for your patch.

I took this series, but it looks like we have a build issue, maybe only
with altcfg distro:

Traceback (most recent call last):
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
    return func(*args, **kwargs)
  File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
    self.assertEqual(status, 0, msg=msg)
AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
...
2025/09/21 11:59:34 Closing PAM auth
2025/09/21 11:59:34 Failure setting user credentials
2025/09/21 11:59:34 Authentication failure
...
RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)

https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407

Can you have a look at it please?

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-21 12:25 ` Mathieu Dubois-Briand
@ 2025-09-22 21:51   ` Randolph Sapp
       [not found]   ` <1867B951D10D3F9C.23856@lists.openembedded.org>
  1 sibling, 0 replies; 23+ messages in thread
From: Randolph Sapp @ 2025-09-22 21:51 UTC (permalink / raw)
  To: Mathieu Dubois-Briand, rs, richard.purdie, ross.burton, alex,
	otavio, kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand wrote:
> On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
>> From: Randolph Sapp <rs@ti.com>
>>
>> We've recently run into some issues with weston-init attempting to start Weston
>> prior to all drm devices being registered. There's not really a good, scriptable
>> mechanism to listen in to device registration events that works with the
>> existing weston-init package. Well, at least one that doesn't involve polling
>> files or introducing more dependency on the init system being used.
>>
>> I also see there is also a lot of scripting around starting X11,
>> xserver-nodm-init, that (from my limited review) should experience the same
>> issue.
>>
>> I'd like to introduce the following display manager for oe-core, emptty [1].
>> This display manager is, as described upstream, a "Dead simple CLI Display
>> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>> which shouldn't be an issue for any users. (It is written in Go, if you have
>> opinions about that.)
>>
>> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>> to leverage this display manager and simply add a user and emptty config for an
>> autologin session. This can resolve the current behavior across init systems
>> without additional scripting, and move some development out of this layer.
>>
>> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>> xuser-account since these are currently unassigned and I've reworked them
>> significantly here.
>>
>> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>> to address before submitting this officially.
>>
>
> Hi Randolph,
>
> Thanks for your patch.
>
> I took this series, but it looks like we have a build issue, maybe only
> with altcfg distro:
>
> Traceback (most recent call last):
>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>     return func(*args, **kwargs)
>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>     return func(*args, **kwargs)
>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>     return func(*args, **kwargs)
>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
>     self.assertEqual(status, 0, msg=msg)
> AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
> ...
> 2025/09/21 11:59:34 Closing PAM auth
> 2025/09/21 11:59:34 Failure setting user credentials
> 2025/09/21 11:59:34 Authentication failure
> ...
> RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
>
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
>
> Can you have a look at it please?
>
> Thanks,
> Mathieu

In the past auth issues can occur if the user was created after the current
system time (of which the default would be the kernel build time if it is unable
to get a value from NTP).

I've already tested this series with an equivalent config to poky-altcfg, with
both root and rootless x11. I reset my cache and did another local build to
match that CICD failure and it still works for me.

My local.conf for my test build was:

MACHINE ??= "qemux86"
DISTRO ??= "poky-altcfg"
BBMULTICONFIG ?= ""
IMAGE_CLASSES += "testimage"

Other variables were dictated by templateconf.cfg:

meta-poky/conf/templates/default

Is that automation setting anything that could possibly play with the build time
or system time values for the testimage? I'm not seeing anything in the logs,
but I'm also not seeing anything that reports the current config outright.

I guess I should add some messages for that as part of the test function
regardless.


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
       [not found]   ` <1867B951D10D3F9C.23856@lists.openembedded.org>
@ 2025-09-22 22:21     ` Randolph Sapp
       [not found]     ` <1867BAF5F353054B.23856@lists.openembedded.org>
  1 sibling, 0 replies; 23+ messages in thread
From: Randolph Sapp @ 2025-09-22 22:21 UTC (permalink / raw)
  To: rs, Mathieu Dubois-Briand, richard.purdie, ross.burton, alex,
	otavio, kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Mon Sep 22, 2025 at 4:51 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand wrote:
>> On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
>>> From: Randolph Sapp <rs@ti.com>
>>>
>>> We've recently run into some issues with weston-init attempting to start Weston
>>> prior to all drm devices being registered. There's not really a good, scriptable
>>> mechanism to listen in to device registration events that works with the
>>> existing weston-init package. Well, at least one that doesn't involve polling
>>> files or introducing more dependency on the init system being used.
>>>
>>> I also see there is also a lot of scripting around starting X11,
>>> xserver-nodm-init, that (from my limited review) should experience the same
>>> issue.
>>>
>>> I'd like to introduce the following display manager for oe-core, emptty [1].
>>> This display manager is, as described upstream, a "Dead simple CLI Display
>>> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>>> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>>> which shouldn't be an issue for any users. (It is written in Go, if you have
>>> opinions about that.)
>>>
>>> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>>> to leverage this display manager and simply add a user and emptty config for an
>>> autologin session. This can resolve the current behavior across init systems
>>> without additional scripting, and move some development out of this layer.
>>>
>>> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>>> xuser-account since these are currently unassigned and I've reworked them
>>> significantly here.
>>>
>>> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>>> to address before submitting this officially.
>>>
>>
>> Hi Randolph,
>>
>> Thanks for your patch.
>>
>> I took this series, but it looks like we have a build issue, maybe only
>> with altcfg distro:
>>
>> Traceback (most recent call last):
>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>     return func(*args, **kwargs)
>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>     return func(*args, **kwargs)
>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>     return func(*args, **kwargs)
>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
>>     self.assertEqual(status, 0, msg=msg)
>> AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
>> ...
>> 2025/09/21 11:59:34 Closing PAM auth
>> 2025/09/21 11:59:34 Failure setting user credentials
>> 2025/09/21 11:59:34 Authentication failure
>> ...
>> RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
>>
>> https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
>> https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
>>
>> Can you have a look at it please?
>>
>> Thanks,
>> Mathieu
>
> In the past auth issues can occur if the user was created after the current
> system time (of which the default would be the kernel build time if it is unable
> to get a value from NTP).
>
> I've already tested this series with an equivalent config to poky-altcfg, with
> both root and rootless x11. I reset my cache and did another local build to
> match that CICD failure and it still works for me.
>
> My local.conf for my test build was:
>
> MACHINE ??= "qemux86"
> DISTRO ??= "poky-altcfg"
> BBMULTICONFIG ?= ""
> IMAGE_CLASSES += "testimage"
>
> Other variables were dictated by templateconf.cfg:
>
> meta-poky/conf/templates/default
>
> Is that automation setting anything that could possibly play with the build time
> or system time values for the testimage? I'm not seeing anything in the logs,
> but I'm also not seeing anything that reports the current config outright.
>
> I guess I should add some messages for that as part of the test function
> regardless.

Whoops, I see the issue now. v10 inbound.


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
       [not found]     ` <1867BAF5F353054B.23856@lists.openembedded.org>
@ 2025-09-22 23:16       ` Randolph Sapp
  2025-09-23  9:03         ` Richard Purdie
  0 siblings, 1 reply; 23+ messages in thread
From: Randolph Sapp @ 2025-09-22 23:16 UTC (permalink / raw)
  To: rs, Mathieu Dubois-Briand, richard.purdie, ross.burton, alex,
	otavio, kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Mon Sep 22, 2025 at 5:21 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> On Mon Sep 22, 2025 at 4:51 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
>> On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand wrote:
>>> On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
>>>> From: Randolph Sapp <rs@ti.com>
>>>>
>>>> We've recently run into some issues with weston-init attempting to start Weston
>>>> prior to all drm devices being registered. There's not really a good, scriptable
>>>> mechanism to listen in to device registration events that works with the
>>>> existing weston-init package. Well, at least one that doesn't involve polling
>>>> files or introducing more dependency on the init system being used.
>>>>
>>>> I also see there is also a lot of scripting around starting X11,
>>>> xserver-nodm-init, that (from my limited review) should experience the same
>>>> issue.
>>>>
>>>> I'd like to introduce the following display manager for oe-core, emptty [1].
>>>> This display manager is, as described upstream, a "Dead simple CLI Display
>>>> Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>>>> parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>>>> which shouldn't be an issue for any users. (It is written in Go, if you have
>>>> opinions about that.)
>>>>
>>>> With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>>>> to leverage this display manager and simply add a user and emptty config for an
>>>> autologin session. This can resolve the current behavior across init systems
>>>> without additional scripting, and move some development out of this layer.
>>>>
>>>> This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>>>> xuser-account since these are currently unassigned and I've reworked them
>>>> significantly here.
>>>>
>>>> Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>>>> to address before submitting this officially.
>>>>
>>>
>>> Hi Randolph,
>>>
>>> Thanks for your patch.
>>>
>>> I took this series, but it looks like we have a build issue, maybe only
>>> with altcfg distro:
>>>
>>> Traceback (most recent call last):
>>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>>     return func(*args, **kwargs)
>>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>>     return func(*args, **kwargs)
>>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>>     return func(*args, **kwargs)
>>>   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
>>>     self.assertEqual(status, 0, msg=msg)
>>> AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
>>> ...
>>> 2025/09/21 11:59:34 Closing PAM auth
>>> 2025/09/21 11:59:34 Failure setting user credentials
>>> 2025/09/21 11:59:34 Authentication failure
>>> ...
>>> RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
>>>
>>> https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
>>> https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
>>>
>>> Can you have a look at it please?
>>>
>>> Thanks,
>>> Mathieu
>>
>> In the past auth issues can occur if the user was created after the current
>> system time (of which the default would be the kernel build time if it is unable
>> to get a value from NTP).
>>
>> I've already tested this series with an equivalent config to poky-altcfg, with
>> both root and rootless x11. I reset my cache and did another local build to
>> match that CICD failure and it still works for me.
>>
>> My local.conf for my test build was:
>>
>> MACHINE ??= "qemux86"
>> DISTRO ??= "poky-altcfg"
>> BBMULTICONFIG ?= ""
>> IMAGE_CLASSES += "testimage"
>>
>> Other variables were dictated by templateconf.cfg:
>>
>> meta-poky/conf/templates/default
>>
>> Is that automation setting anything that could possibly play with the build time
>> or system time values for the testimage? I'm not seeing anything in the logs,
>> but I'm also not seeing anything that reports the current config outright.
>>
>> I guess I should add some messages for that as part of the test function
>> regardless.
>
> Whoops, I see the issue now. v10 inbound.

Well, I know what the issue is, but I guess I should ask how people want to
address it. Currently, that test expect a root x11 instance to autostart. I have
it attempt to do that currently, and my old test images were being built with
"empty-root-password allow-empty-password allow-root-login" features enabled,
allowing it to proceed as usual. The password auth is what is currently failing.

1. We can do passwordless root auth for these by adjusting the pam rule for
emptty to allow auth as root for that application.

2. I would suggest that we instead make sure the root user is in the
nopasswdlogin group, as it makes it clear that the user has unprotected GUI
access.

I'm not sure either of these should really be allowed in a production
environment though. Technically we can disable this behavior outright when
ROOTLESS_X is set, but it's still a little odd to me.

3. Should the test images explicitly enable the empty-root-password
allow-empty-password? That means the x11 test will have to move from an
arbitrary runtime test to something like the way locales are currently tested.

Seems like solution 2 is the easiest and preserves the expected behavior for
that test, assuming people are okay with that behavior.

- Randolph


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-22 23:16       ` Randolph Sapp
@ 2025-09-23  9:03         ` Richard Purdie
  2025-09-23 17:56           ` Randolph Sapp
       [not found]           ` <1867FB133639FF67.16927@lists.openembedded.org>
  0 siblings, 2 replies; 23+ messages in thread
From: Richard Purdie @ 2025-09-23  9:03 UTC (permalink / raw)
  To: Randolph Sapp, Mathieu Dubois-Briand, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Mon, 2025-09-22 at 18:16 -0500, Randolph Sapp wrote:
> On Mon Sep 22, 2025 at 5:21 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> > On Mon Sep 22, 2025 at 4:51 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> > > On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand wrote:
> > > > On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
> > > > > From: Randolph Sapp <rs@ti.com>
> > > > > 
> > > > > We've recently run into some issues with weston-init attempting to start Weston
> > > > > prior to all drm devices being registered. There's not really a good, scriptable
> > > > > mechanism to listen in to device registration events that works with the
> > > > > existing weston-init package. Well, at least one that doesn't involve polling
> > > > > files or introducing more dependency on the init system being used.
> > > > > 
> > > > > I also see there is also a lot of scripting around starting X11,
> > > > > xserver-nodm-init, that (from my limited review) should experience the same
> > > > > issue.
> > > > > 
> > > > > I'd like to introduce the following display manager for oe-core, emptty [1].
> > > > > This display manager is, as described upstream, a "Dead simple CLI Display
> > > > > Manager on TTY". It supports both x11 and wayland sessions, with togglable build
> > > > > parameters to completely remove x11 and pam dependencies. It's licensed MIT,
> > > > > which shouldn't be an issue for any users. (It is written in Go, if you have
> > > > > opinions about that.)
> > > > > 
> > > > > With this, both weston-init and the xserver-nodm-init packages can be re-tuned
> > > > > to leverage this display manager and simply add a user and emptty config for an
> > > > > autologin session. This can resolve the current behavior across init systems
> > > > > without additional scripting, and move some development out of this layer.
> > > > > 
> > > > > This lists myself as a maintainer of emptty as well as xserver-nodm-init and
> > > > > xuser-account since these are currently unassigned and I've reworked them
> > > > > significantly here.
> > > > > 
> > > > > Sorry for the delay on this series. I found a few bugs in emptty that I wanted
> > > > > to address before submitting this officially.
> > > > > 
> > > > 
> > > > Hi Randolph,
> > > > 
> > > > Thanks for your patch.
> > > > 
> > > > I took this series, but it looks like we have a build issue, maybe only
> > > > with altcfg distro:
> > > > 
> > > > Traceback (most recent call last):
> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
> > > >     return func(*args, **kwargs)
> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
> > > >     return func(*args, **kwargs)
> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
> > > >     return func(*args, **kwargs)
> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
> > > >     self.assertEqual(status, 0, msg=msg)
> > > > AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
> > > > ...
> > > > 2025/09/21 11:59:34 Closing PAM auth
> > > > 2025/09/21 11:59:34 Failure setting user credentials
> > > > 2025/09/21 11:59:34 Authentication failure
> > > > ...
> > > > RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
> > > > 
> > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
> > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
> > > > 
> > > > Can you have a look at it please?
> > > > 
> > > > Thanks,
> > > > Mathieu
> > > 
> > > In the past auth issues can occur if the user was created after the current
> > > system time (of which the default would be the kernel build time if it is unable
> > > to get a value from NTP).
> > > 
> > > I've already tested this series with an equivalent config to poky-altcfg, with
> > > both root and rootless x11. I reset my cache and did another local build to
> > > match that CICD failure and it still works for me.
> > > 
> > > My local.conf for my test build was:
> > > 
> > > MACHINE ??= "qemux86"
> > > DISTRO ??= "poky-altcfg"
> > > BBMULTICONFIG ?= ""
> > > IMAGE_CLASSES += "testimage"
> > > 
> > > Other variables were dictated by templateconf.cfg:
> > > 
> > > meta-poky/conf/templates/default
> > > 
> > > Is that automation setting anything that could possibly play with the build time
> > > or system time values for the testimage? I'm not seeing anything in the logs,
> > > but I'm also not seeing anything that reports the current config outright.
> > > 
> > > I guess I should add some messages for that as part of the test function
> > > regardless.
> > 
> > Whoops, I see the issue now. v10 inbound.
> 
> Well, I know what the issue is, but I guess I should ask how people want to
> address it. Currently, that test expect a root x11 instance to autostart. I have
> it attempt to do that currently, and my old test images were being built with
> "empty-root-password allow-empty-password allow-root-login" features enabled,
> allowing it to proceed as usual. The password auth is what is currently failing.
> 
> 1. We can do passwordless root auth for these by adjusting the pam rule for
> emptty to allow auth as root for that application.
> 
> 2. I would suggest that we instead make sure the root user is in the
> nopasswdlogin group, as it makes it clear that the user has unprotected GUI
> access.
> 
> I'm not sure either of these should really be allowed in a production
> environment though. Technically we can disable this behavior outright when
> ROOTLESS_X is set, but it's still a little odd to me.
> 
> 3. Should the test images explicitly enable the empty-root-password
> allow-empty-password? That means the x11 test will have to move from an
> arbitrary runtime test to something like the way locales are currently tested.
> 
> Seems like solution 2 is the easiest and preserves the expected behavior for
> that test, assuming people are okay with that behavior.

Ideally, we'd create a normal user and have the tests use that normal
user. The "root" based tests are historical and were done as testing
something was better than nothing. The world expects better security
practises and it would be good to ideally update the tests to better
match real world usage.

I say ideally since I appreciate it sometimes can be too much work but
in this case it might not be, I haven't dug into the details though and
I'm a bit distracted. I just thought that info might be helpful for
direction.

Cheers,

Richard



^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-23  9:03         ` Richard Purdie
@ 2025-09-23 17:56           ` Randolph Sapp
       [not found]           ` <1867FB133639FF67.16927@lists.openembedded.org>
  1 sibling, 0 replies; 23+ messages in thread
From: Randolph Sapp @ 2025-09-23 17:56 UTC (permalink / raw)
  To: Richard Purdie, Randolph Sapp, Mathieu Dubois-Briand, ross.burton,
	alex, otavio, kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Tue Sep 23, 2025 at 4:03 AM CDT, Richard Purdie wrote:
> On Mon, 2025-09-22 at 18:16 -0500, Randolph Sapp wrote:
>> On Mon Sep 22, 2025 at 5:21 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
>> > On Mon Sep 22, 2025 at 4:51 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
>> > > On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand wrote:
>> > > > On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
>> > > > > From: Randolph Sapp <rs@ti.com>
>> > > > > 
>> > > > > We've recently run into some issues with weston-init attempting to start Weston
>> > > > > prior to all drm devices being registered. There's not really a good, scriptable
>> > > > > mechanism to listen in to device registration events that works with the
>> > > > > existing weston-init package. Well, at least one that doesn't involve polling
>> > > > > files or introducing more dependency on the init system being used.
>> > > > > 
>> > > > > I also see there is also a lot of scripting around starting X11,
>> > > > > xserver-nodm-init, that (from my limited review) should experience the same
>> > > > > issue.
>> > > > > 
>> > > > > I'd like to introduce the following display manager for oe-core, emptty [1].
>> > > > > This display manager is, as described upstream, a "Dead simple CLI Display
>> > > > > Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>> > > > > parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>> > > > > which shouldn't be an issue for any users. (It is written in Go, if you have
>> > > > > opinions about that.)
>> > > > > 
>> > > > > With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>> > > > > to leverage this display manager and simply add a user and emptty config for an
>> > > > > autologin session. This can resolve the current behavior across init systems
>> > > > > without additional scripting, and move some development out of this layer.
>> > > > > 
>> > > > > This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>> > > > > xuser-account since these are currently unassigned and I've reworked them
>> > > > > significantly here.
>> > > > > 
>> > > > > Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>> > > > > to address before submitting this officially.
>> > > > > 
>> > > > 
>> > > > Hi Randolph,
>> > > > 
>> > > > Thanks for your patch.
>> > > > 
>> > > > I took this series, but it looks like we have a build issue, maybe only
>> > > > with altcfg distro:
>> > > > 
>> > > > Traceback (most recent call last):
>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>> > > >     return func(*args, **kwargs)
>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>> > > >     return func(*args, **kwargs)
>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>> > > >     return func(*args, **kwargs)
>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
>> > > >     self.assertEqual(status, 0, msg=msg)
>> > > > AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
>> > > > ...
>> > > > 2025/09/21 11:59:34 Closing PAM auth
>> > > > 2025/09/21 11:59:34 Failure setting user credentials
>> > > > 2025/09/21 11:59:34 Authentication failure
>> > > > ...
>> > > > RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
>> > > > 
>> > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
>> > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
>> > > > 
>> > > > Can you have a look at it please?
>> > > > 
>> > > > Thanks,
>> > > > Mathieu
>> > > 
>> > > In the past auth issues can occur if the user was created after the current
>> > > system time (of which the default would be the kernel build time if it is unable
>> > > to get a value from NTP).
>> > > 
>> > > I've already tested this series with an equivalent config to poky-altcfg, with
>> > > both root and rootless x11. I reset my cache and did another local build to
>> > > match that CICD failure and it still works for me.
>> > > 
>> > > My local.conf for my test build was:
>> > > 
>> > > MACHINE ??= "qemux86"
>> > > DISTRO ??= "poky-altcfg"
>> > > BBMULTICONFIG ?= ""
>> > > IMAGE_CLASSES += "testimage"
>> > > 
>> > > Other variables were dictated by templateconf.cfg:
>> > > 
>> > > meta-poky/conf/templates/default
>> > > 
>> > > Is that automation setting anything that could possibly play with the build time
>> > > or system time values for the testimage? I'm not seeing anything in the logs,
>> > > but I'm also not seeing anything that reports the current config outright.
>> > > 
>> > > I guess I should add some messages for that as part of the test function
>> > > regardless.
>> > 
>> > Whoops, I see the issue now. v10 inbound.
>> 
>> Well, I know what the issue is, but I guess I should ask how people want to
>> address it. Currently, that test expect a root x11 instance to autostart. I have
>> it attempt to do that currently, and my old test images were being built with
>> "empty-root-password allow-empty-password allow-root-login" features enabled,
>> allowing it to proceed as usual. The password auth is what is currently failing.
>> 
>> 1. We can do passwordless root auth for these by adjusting the pam rule for
>> emptty to allow auth as root for that application.
>> 
>> 2. I would suggest that we instead make sure the root user is in the
>> nopasswdlogin group, as it makes it clear that the user has unprotected GUI
>> access.
>> 
>> I'm not sure either of these should really be allowed in a production
>> environment though. Technically we can disable this behavior outright when
>> ROOTLESS_X is set, but it's still a little odd to me.
>> 
>> 3. Should the test images explicitly enable the empty-root-password
>> allow-empty-password? That means the x11 test will have to move from an
>> arbitrary runtime test to something like the way locales are currently tested.
>> 
>> Seems like solution 2 is the easiest and preserves the expected behavior for
>> that test, assuming people are okay with that behavior.
>
> Ideally, we'd create a normal user and have the tests use that normal
> user. The "root" based tests are historical and were done as testing
> something was better than nothing. The world expects better security
> practises and it would be good to ideally update the tests to better
> match real world usage.
>
> I say ideally since I appreciate it sometimes can be too much work but
> in this case it might not be, I haven't dug into the details though and
> I'm a bit distracted. I just thought that info might be helpful for
> direction.
>
> Cheers,
>
> Richard

Thanks for the feedback Richard. There is currently already an xuser account
that is pulled in when ROOTLESS_X = 0. I assume the default behavior of x11
running as root is a holdover from that period before rootless x was possible.

I can rework these tests and drop the root x11 compatibility path if everyone is
alright with that.

- Randolph


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
       [not found]           ` <1867FB133639FF67.16927@lists.openembedded.org>
@ 2025-09-23 18:04             ` Randolph Sapp
  2025-09-23 22:41               ` Richard Purdie
  0 siblings, 1 reply; 23+ messages in thread
From: Randolph Sapp @ 2025-09-23 18:04 UTC (permalink / raw)
  To: rs, Richard Purdie, Mathieu Dubois-Briand, ross.burton, alex,
	otavio, kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Tue Sep 23, 2025 at 12:56 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
> On Tue Sep 23, 2025 at 4:03 AM CDT, Richard Purdie wrote:
>> On Mon, 2025-09-22 at 18:16 -0500, Randolph Sapp wrote:
>>> On Mon Sep 22, 2025 at 5:21 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
>>> > On Mon Sep 22, 2025 at 4:51 PM CDT, Randolph Sapp via lists.openembedded.org wrote:
>>> > > On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand wrote:
>>> > > > On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
>>> > > > > From: Randolph Sapp <rs@ti.com>
>>> > > > > 
>>> > > > > We've recently run into some issues with weston-init attempting to start Weston
>>> > > > > prior to all drm devices being registered. There's not really a good, scriptable
>>> > > > > mechanism to listen in to device registration events that works with the
>>> > > > > existing weston-init package. Well, at least one that doesn't involve polling
>>> > > > > files or introducing more dependency on the init system being used.
>>> > > > > 
>>> > > > > I also see there is also a lot of scripting around starting X11,
>>> > > > > xserver-nodm-init, that (from my limited review) should experience the same
>>> > > > > issue.
>>> > > > > 
>>> > > > > I'd like to introduce the following display manager for oe-core, emptty [1].
>>> > > > > This display manager is, as described upstream, a "Dead simple CLI Display
>>> > > > > Manager on TTY". It supports both x11 and wayland sessions, with togglable build
>>> > > > > parameters to completely remove x11 and pam dependencies. It's licensed MIT,
>>> > > > > which shouldn't be an issue for any users. (It is written in Go, if you have
>>> > > > > opinions about that.)
>>> > > > > 
>>> > > > > With this, both weston-init and the xserver-nodm-init packages can be re-tuned
>>> > > > > to leverage this display manager and simply add a user and emptty config for an
>>> > > > > autologin session. This can resolve the current behavior across init systems
>>> > > > > without additional scripting, and move some development out of this layer.
>>> > > > > 
>>> > > > > This lists myself as a maintainer of emptty as well as xserver-nodm-init and
>>> > > > > xuser-account since these are currently unassigned and I've reworked them
>>> > > > > significantly here.
>>> > > > > 
>>> > > > > Sorry for the delay on this series. I found a few bugs in emptty that I wanted
>>> > > > > to address before submitting this officially.
>>> > > > > 
>>> > > > 
>>> > > > Hi Randolph,
>>> > > > 
>>> > > > Thanks for your patch.
>>> > > > 
>>> > > > I took this series, but it looks like we have a build issue, maybe only
>>> > > > with altcfg distro:
>>> > > > 
>>> > > > Traceback (most recent call last):
>>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>> > > >     return func(*args, **kwargs)
>>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>> > > >     return func(*args, **kwargs)
>>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/core/decorator/__init__.py", line 35, in wrapped_f
>>> > > >     return func(*args, **kwargs)
>>> > > >   File "/srv/pokybuild/yocto-worker/qemux86-alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31, in test_xorg_running
>>> > > >     self.assertEqual(status, 0, msg=msg)
>>> > > > AssertionError: 1 != 0 : Xorg does not appear to be running   PID USER       VSZ STAT COMMAND
>>> > > > ...
>>> > > > 2025/09/21 11:59:34 Closing PAM auth
>>> > > > 2025/09/21 11:59:34 Failure setting user credentials
>>> > > > 2025/09/21 11:59:34 Authentication failure
>>> > > > ...
>>> > > > RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
>>> > > > 
>>> > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
>>> > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
>>> > > > 
>>> > > > Can you have a look at it please?
>>> > > > 
>>> > > > Thanks,
>>> > > > Mathieu
>>> > > 
>>> > > In the past auth issues can occur if the user was created after the current
>>> > > system time (of which the default would be the kernel build time if it is unable
>>> > > to get a value from NTP).
>>> > > 
>>> > > I've already tested this series with an equivalent config to poky-altcfg, with
>>> > > both root and rootless x11. I reset my cache and did another local build to
>>> > > match that CICD failure and it still works for me.
>>> > > 
>>> > > My local.conf for my test build was:
>>> > > 
>>> > > MACHINE ??= "qemux86"
>>> > > DISTRO ??= "poky-altcfg"
>>> > > BBMULTICONFIG ?= ""
>>> > > IMAGE_CLASSES += "testimage"
>>> > > 
>>> > > Other variables were dictated by templateconf.cfg:
>>> > > 
>>> > > meta-poky/conf/templates/default
>>> > > 
>>> > > Is that automation setting anything that could possibly play with the build time
>>> > > or system time values for the testimage? I'm not seeing anything in the logs,
>>> > > but I'm also not seeing anything that reports the current config outright.
>>> > > 
>>> > > I guess I should add some messages for that as part of the test function
>>> > > regardless.
>>> > 
>>> > Whoops, I see the issue now. v10 inbound.
>>> 
>>> Well, I know what the issue is, but I guess I should ask how people want to
>>> address it. Currently, that test expect a root x11 instance to autostart. I have
>>> it attempt to do that currently, and my old test images were being built with
>>> "empty-root-password allow-empty-password allow-root-login" features enabled,
>>> allowing it to proceed as usual. The password auth is what is currently failing.
>>> 
>>> 1. We can do passwordless root auth for these by adjusting the pam rule for
>>> emptty to allow auth as root for that application.
>>> 
>>> 2. I would suggest that we instead make sure the root user is in the
>>> nopasswdlogin group, as it makes it clear that the user has unprotected GUI
>>> access.
>>> 
>>> I'm not sure either of these should really be allowed in a production
>>> environment though. Technically we can disable this behavior outright when
>>> ROOTLESS_X is set, but it's still a little odd to me.
>>> 
>>> 3. Should the test images explicitly enable the empty-root-password
>>> allow-empty-password? That means the x11 test will have to move from an
>>> arbitrary runtime test to something like the way locales are currently tested.
>>> 
>>> Seems like solution 2 is the easiest and preserves the expected behavior for
>>> that test, assuming people are okay with that behavior.
>>
>> Ideally, we'd create a normal user and have the tests use that normal
>> user. The "root" based tests are historical and were done as testing
>> something was better than nothing. The world expects better security
>> practises and it would be good to ideally update the tests to better
>> match real world usage.
>>
>> I say ideally since I appreciate it sometimes can be too much work but
>> in this case it might not be, I haven't dug into the details though and
>> I'm a bit distracted. I just thought that info might be helpful for
>> direction.
>>
>> Cheers,
>>
>> Richard
>
> Thanks for the feedback Richard. There is currently already an xuser account
> that is pulled in when ROOTLESS_X = 0. I assume the default behavior of x11
> running as root is a holdover from that period before rootless x was possible.
>
> I can rework these tests and drop the root x11 compatibility path if everyone is
> alright with that.
>
> - Randolph

Ah, should have proof read that a little more.
... when ROOTLESS_X = 1 ...

Point still stands. I'll drop the root x11 path unless anyone objects.


^ permalink raw reply	[flat|nested] 23+ messages in thread

* Re: [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland
  2025-09-23 18:04             ` Randolph Sapp
@ 2025-09-23 22:41               ` Richard Purdie
  0 siblings, 0 replies; 23+ messages in thread
From: Richard Purdie @ 2025-09-23 22:41 UTC (permalink / raw)
  To: Randolph Sapp, Mathieu Dubois-Briand, ross.burton, alex, otavio,
	kexin.hao, afd, detheridge, denis, reatmon
  Cc: openembedded-core, vijayp

On Tue, 2025-09-23 at 13:04 -0500, Randolph Sapp wrote:
> On Tue Sep 23, 2025 at 12:56 PM CDT, Randolph Sapp via
> lists.openembedded.org wrote:
> > On Tue Sep 23, 2025 at 4:03 AM CDT, Richard Purdie wrote:
> > > On Mon, 2025-09-22 at 18:16 -0500, Randolph Sapp wrote:
> > > > On Mon Sep 22, 2025 at 5:21 PM CDT, Randolph Sapp via
> > > > lists.openembedded.org wrote:
> > > > > On Mon Sep 22, 2025 at 4:51 PM CDT, Randolph Sapp via
> > > > > lists.openembedded.org wrote:
> > > > > > On Sun Sep 21, 2025 at 7:25 AM CDT, Mathieu Dubois-Briand
> > > > > > wrote:
> > > > > > > On Thu Sep 18, 2025 at 11:48 PM CEST, rs wrote:
> > > > > > > > From: Randolph Sapp <rs@ti.com>
> > > > > > > > 
> > > > > > > > We've recently run into some issues with weston-init
> > > > > > > > attempting to start Weston
> > > > > > > > prior to all drm devices being registered. There's not
> > > > > > > > really a good, scriptable
> > > > > > > > mechanism to listen in to device registration events
> > > > > > > > that works with the
> > > > > > > > existing weston-init package. Well, at least one that
> > > > > > > > doesn't involve polling
> > > > > > > > files or introducing more dependency on the init system
> > > > > > > > being used.
> > > > > > > > 
> > > > > > > > I also see there is also a lot of scripting around
> > > > > > > > starting X11,
> > > > > > > > xserver-nodm-init, that (from my limited review) should
> > > > > > > > experience the same
> > > > > > > > issue.
> > > > > > > > 
> > > > > > > > I'd like to introduce the following display manager for
> > > > > > > > oe-core, emptty [1].
> > > > > > > > This display manager is, as described upstream, a "Dead
> > > > > > > > simple CLI Display
> > > > > > > > Manager on TTY". It supports both x11 and wayland
> > > > > > > > sessions, with togglable build
> > > > > > > > parameters to completely remove x11 and pam
> > > > > > > > dependencies. It's licensed MIT,
> > > > > > > > which shouldn't be an issue for any users. (It is
> > > > > > > > written in Go, if you have
> > > > > > > > opinions about that.)
> > > > > > > > 
> > > > > > > > With this, both weston-init and the xserver-nodm-init
> > > > > > > > packages can be re-tuned
> > > > > > > > to leverage this display manager and simply add a user
> > > > > > > > and emptty config for an
> > > > > > > > autologin session. This can resolve the current
> > > > > > > > behavior across init systems
> > > > > > > > without additional scripting, and move some development
> > > > > > > > out of this layer.
> > > > > > > > 
> > > > > > > > This lists myself as a maintainer of emptty as well as
> > > > > > > > xserver-nodm-init and
> > > > > > > > xuser-account since these are currently unassigned and
> > > > > > > > I've reworked them
> > > > > > > > significantly here.
> > > > > > > > 
> > > > > > > > Sorry for the delay on this series. I found a few bugs
> > > > > > > > in emptty that I wanted
> > > > > > > > to address before submitting this officially.
> > > > > > > > 
> > > > > > > 
> > > > > > > Hi Randolph,
> > > > > > > 
> > > > > > > Thanks for your patch.
> > > > > > > 
> > > > > > > I took this series, but it looks like we have a build
> > > > > > > issue, maybe only
> > > > > > > with altcfg distro:
> > > > > > > 
> > > > > > > Traceback (most recent call last):
> > > > > > >   File "/srv/pokybuild/yocto-worker/qemux86-
> > > > > > > alt/build/meta/lib/oeqa/core/decorator/__init__.py", line
> > > > > > > 35, in wrapped_f
> > > > > > >     return func(*args, **kwargs)
> > > > > > >   File "/srv/pokybuild/yocto-worker/qemux86-
> > > > > > > alt/build/meta/lib/oeqa/core/decorator/__init__.py", line
> > > > > > > 35, in wrapped_f
> > > > > > >     return func(*args, **kwargs)
> > > > > > >   File "/srv/pokybuild/yocto-worker/qemux86-
> > > > > > > alt/build/meta/lib/oeqa/core/decorator/__init__.py", line
> > > > > > > 35, in wrapped_f
> > > > > > >     return func(*args, **kwargs)
> > > > > > >   File "/srv/pokybuild/yocto-worker/qemux86-
> > > > > > > alt/build/meta/lib/oeqa/runtime/cases/xorg.py", line 31,
> > > > > > > in test_xorg_running
> > > > > > >     self.assertEqual(status, 0, msg=msg)
> > > > > > > AssertionError: 1 != 0 : Xorg does not appear to be
> > > > > > > running   PID USER       VSZ STAT COMMAND
> > > > > > > ...
> > > > > > > 2025/09/21 11:59:34 Closing PAM auth
> > > > > > > 2025/09/21 11:59:34 Failure setting user credentials
> > > > > > > 2025/09/21 11:59:34 Authentication failure
> > > > > > > ...
> > > > > > > RESULTS - xorg.XorgTest.test_xorg_running: FAILED (1.41s)
> > > > > > > 
> > > > > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/20/builds/2402
> > > > > > > https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2407
> > > > > > > 
> > > > > > > Can you have a look at it please?
> > > > > > > 
> > > > > > > Thanks,
> > > > > > > Mathieu
> > > > > > 
> > > > > > In the past auth issues can occur if the user was created
> > > > > > after the current
> > > > > > system time (of which the default would be the kernel build
> > > > > > time if it is unable
> > > > > > to get a value from NTP).
> > > > > > 
> > > > > > I've already tested this series with an equivalent config
> > > > > > to poky-altcfg, with
> > > > > > both root and rootless x11. I reset my cache and did
> > > > > > another local build to
> > > > > > match that CICD failure and it still works for me.
> > > > > > 
> > > > > > My local.conf for my test build was:
> > > > > > 
> > > > > > MACHINE ??= "qemux86"
> > > > > > DISTRO ??= "poky-altcfg"
> > > > > > BBMULTICONFIG ?= ""
> > > > > > IMAGE_CLASSES += "testimage"
> > > > > > 
> > > > > > Other variables were dictated by templateconf.cfg:
> > > > > > 
> > > > > > meta-poky/conf/templates/default
> > > > > > 
> > > > > > Is that automation setting anything that could possibly
> > > > > > play with the build time
> > > > > > or system time values for the testimage? I'm not seeing
> > > > > > anything in the logs,
> > > > > > but I'm also not seeing anything that reports the current
> > > > > > config outright.
> > > > > > 
> > > > > > I guess I should add some messages for that as part of the
> > > > > > test function
> > > > > > regardless.
> > > > > 
> > > > > Whoops, I see the issue now. v10 inbound.
> > > > 
> > > > Well, I know what the issue is, but I guess I should ask how
> > > > people want to
> > > > address it. Currently, that test expect a root x11 instance to
> > > > autostart. I have
> > > > it attempt to do that currently, and my old test images were
> > > > being built with
> > > > "empty-root-password allow-empty-password allow-root-login"
> > > > features enabled,
> > > > allowing it to proceed as usual. The password auth is what is
> > > > currently failing.
> > > > 
> > > > 1. We can do passwordless root auth for these by adjusting the
> > > > pam rule for
> > > > emptty to allow auth as root for that application.
> > > > 
> > > > 2. I would suggest that we instead make sure the root user is
> > > > in the
> > > > nopasswdlogin group, as it makes it clear that the user has
> > > > unprotected GUI
> > > > access.
> > > > 
> > > > I'm not sure either of these should really be allowed in a
> > > > production
> > > > environment though. Technically we can disable this behavior
> > > > outright when
> > > > ROOTLESS_X is set, but it's still a little odd to me.
> > > > 
> > > > 3. Should the test images explicitly enable the empty-root-
> > > > password
> > > > allow-empty-password? That means the x11 test will have to move
> > > > from an
> > > > arbitrary runtime test to something like the way locales are
> > > > currently tested.
> > > > 
> > > > Seems like solution 2 is the easiest and preserves the expected
> > > > behavior for
> > > > that test, assuming people are okay with that behavior.
> > > 
> > > Ideally, we'd create a normal user and have the tests use that
> > > normal
> > > user. The "root" based tests are historical and were done as
> > > testing
> > > something was better than nothing. The world expects better
> > > security
> > > practises and it would be good to ideally update the tests to
> > > better
> > > match real world usage.
> > > 
> > > I say ideally since I appreciate it sometimes can be too much
> > > work but
> > > in this case it might not be, I haven't dug into the details
> > > though and
> > > I'm a bit distracted. I just thought that info might be helpful
> > > for
> > > direction.
> > > 
> > > Cheers,
> > > 
> > > Richard
> > 
> > Thanks for the feedback Richard. There is currently already an
> > xuser account
> > that is pulled in when ROOTLESS_X = 0. I assume the default
> > behavior of x11
> > running as root is a holdover from that period before rootless x
> > was possible.
> > 
> > I can rework these tests and drop the root x11 compatibility path
> > if everyone is
> > alright with that.
> > 
> > - Randolph
> 
> Ah, should have proof read that a little more.
> ... when ROOTLESS_X = 1 ...
> 
> Point still stands. I'll drop the root x11 path unless anyone
> objects.

I think it works on some architectures but not all so dropping it may
not be quite that simple.

Cheers,

Richard


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2025-09-23 22:41 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-18 21:48 [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland rs
2025-09-18 21:48 ` [oe-core][PATCHv9 1/6] libx11: create tmpfile dir for x11 domain socket rs
2025-09-18 21:48 ` [oe-core][PATCHv9 2/6] go: fix sigaction usage on i386 platforms rs
2025-09-18 21:48 ` [oe-core][PATCHv9 3/6] emptty: add version 0.14.0 rs
2025-09-18 21:48 ` [oe-core][PATCHv9 4/6] weston-init: convert to virtual-emptty-conf rs
2025-09-18 22:03   ` Patchtest results for " patchtest
2025-09-18 21:49 ` [oe-core][PATCHv9 5/6] weston: remove deprecated weston-start scripts rs
2025-09-18 21:49 ` [oe-core][PATCHv9 6/6] xserver-nodm-init: convert to virtual-emptty-conf rs
2025-09-18 22:25 ` [oe-core][PATCHv9 0/6] Display manager proposal for x11 and wayland Joshua Watt
2025-09-18 22:31   ` Randolph Sapp
2025-09-18 22:35     ` Joshua Watt
2025-09-18 22:39       ` Randolph Sapp
     [not found]       ` <186681957172BF4C.23626@lists.openembedded.org>
2025-09-18 22:42         ` Randolph Sapp
2025-09-18 23:03           ` Joshua Watt
2025-09-18 23:13             ` Randolph Sapp
2025-09-21 12:25 ` Mathieu Dubois-Briand
2025-09-22 21:51   ` Randolph Sapp
     [not found]   ` <1867B951D10D3F9C.23856@lists.openembedded.org>
2025-09-22 22:21     ` Randolph Sapp
     [not found]     ` <1867BAF5F353054B.23856@lists.openembedded.org>
2025-09-22 23:16       ` Randolph Sapp
2025-09-23  9:03         ` Richard Purdie
2025-09-23 17:56           ` Randolph Sapp
     [not found]           ` <1867FB133639FF67.16927@lists.openembedded.org>
2025-09-23 18:04             ` Randolph Sapp
2025-09-23 22:41               ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox