[PATCH] perf: do builds in a clean build tree

[PATCH] perf: do builds in a clean build tree

[Ross Burton]

Set B to WORKDIR/build and clean that on configure so we ensure that the
build tree is clean.

Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 meta/recipes-kernel/perf/perf.bb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 3b9e52fdb84..00b869e8b18 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -69,6 +69,8 @@ include ${@bb.utils.contains('PACKAGECONFIG', 'perl', 'perf-perl.inc', '', d)}
 inherit kernelsrc
 
 S = "${UNPACKDIR}/${BP}"
+B = "${WORKDIR}/build"
+do_configure[cleandirs] += "${B}"
 
 # The LDFLAGS is required or some old kernels fails due missing
 # symbols and this is preferred than requiring patches to every old
@@ -424,7 +426,7 @@ perf_fix_sources () {
 			util/pmu-flex.h util/expr-flex.h util/expr-flex.c; do
 		f=${PKGD}${TARGET_DBGSRC_DIR}/$f
 		if [ -e $f ]; then
-			sed -i -e 's#${S}/##g' $f
+			sed -i -e 's#${B}/##g' $f
 		fi
 	done
 }
-- 
2.43.0

Re: [OE-core] [PATCH] perf: do builds in a clean build tree

[Bruce Ashfield]

[-- Attachment #1: Type: text/plain, Size: 2082 bytes --]

On Thu, Sep 25, 2025 at 11:27 AM Ross Burton via lists.openembedded.org
<ross.burton=arm.com@lists.openembedded.org> wrote:

> Set B to WORKDIR/build and clean that on configure so we ensure that the
> build tree is clean.
>
>
Ack'd

There's no special reason for why we were building it without a designated
build
directory.

Bruce



> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  meta/recipes-kernel/perf/perf.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/
> perf.bb
> index 3b9e52fdb84..00b869e8b18 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -69,6 +69,8 @@ include ${@bb.utils.contains('PACKAGECONFIG', 'perl',
> 'perf-perl.inc', '', d)}
>  inherit kernelsrc
>
>  S = "${UNPACKDIR}/${BP}"
> +B = "${WORKDIR}/build"
> +do_configure[cleandirs] += "${B}"
>
>  # The LDFLAGS is required or some old kernels fails due missing
>  # symbols and this is preferred than requiring patches to every old
> @@ -424,7 +426,7 @@ perf_fix_sources () {
>                         util/pmu-flex.h util/expr-flex.h util/expr-flex.c;
> do
>                 f=${PKGD}${TARGET_DBGSRC_DIR}/$f
>                 if [ -e $f ]; then
> -                       sed -i -e 's#${S}/##g' $f
> +                       sed -i -e 's#${B}/##g' $f
>                 fi
>         done
>  }
> --
> 2.43.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#224043):
> https://lists.openembedded.org/g/openembedded-core/message/224043
> Mute This Topic: https://lists.openembedded.org/mt/115432523/1050810
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
- Thou shalt not follow the NULL pointer, for chaos and madness await thee
at its end
- "Use the force Harry" - Gandalf, Star Trek II

[-- Attachment #2: Type: text/html, Size: 4238 bytes --]

Re: [OE-core] [PATCH] perf: do builds in a clean build tree

[Mathieu Dubois-Briand]

On Thu Sep 25, 2025 at 5:26 PM CEST, Ross Burton via lists.openembedded.org wrote:
> Set B to WORKDIR/build and clean that on configure so we ensure that the
> build tree is clean.
>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---

Hi Ross,

It looks like this is breaking some arm64 builds:

ERROR: perf-1.0-r0 do_compile: Execution of '/srv/pokybuild/yocto-worker/qemuarm64-alt/build/build/tmp/work/qemuarm64-poky-linux/perf/1.0/temp/run.do_compile.221036' failed with exit code 1
...
| make[2]: *** No rule to make target 'tools/arch/arm64/include/uapi/asm/unistd.h', needed by '/srv/pokybuild/yocto-worker/qemuarm64-alt/build/build/tmp/work/qemuarm64-poky-linux/perf/1.0/build/arch/arm64/include/generated/asm/syscalls.c'.  Stop.

https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2440
https://autobuilder.yoctoproject.org/valkyrie/#/builders/22/builds/2487

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH] perf: do builds in a clean build tree

[Khem Raj]

On Mon, Sep 29, 2025 at 1:14 AM Mathieu Dubois-Briand via
lists.openembedded.org
<mathieu.dubois-briand=bootlin.com@lists.openembedded.org> wrote:
>
> On Thu Sep 25, 2025 at 5:26 PM CEST, Ross Burton via lists.openembedded.org wrote:
> > Set B to WORKDIR/build and clean that on configure so we ensure that the
> > build tree is clean.
> >
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
>
> Hi Ross,
>
> It looks like this is breaking some arm64 builds:
>
> ERROR: perf-1.0-r0 do_compile: Execution of '/srv/pokybuild/yocto-worker/qemuarm64-alt/build/build/tmp/work/qemuarm64-poky-linux/perf/1.0/temp/run.do_compile.221036' failed with exit code 1
> ...
> | make[2]: *** No rule to make target 'tools/arch/arm64/include/uapi/asm/unistd.h', needed by '/srv/pokybuild/yocto-worker/qemuarm64-alt/build/build/tmp/work/qemuarm64-poky-linux/perf/1.0/build/arch/arm64/include/generated/asm/syscalls.c'.  Stop.
>
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/9/builds/2440
> https://autobuilder.yoctoproject.org/valkyrie/#/builders/22/builds/2487
>

I wonder if we now need to define KERNEL_SRC in EXTRA_OECONF as well.

> Thanks,
> Mathieu
>
> --
> Mathieu Dubois-Briand, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#224123): https://lists.openembedded.org/g/openembedded-core/message/224123
> Mute This Topic: https://lists.openembedded.org/mt/115432523/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>