public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
* [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes
@ 2026-01-07  4:23 Dmitry Baryshkov
  2026-01-19  6:46 ` Dmitry Baryshkov
  2026-01-19 18:25 ` Paul Barker
  0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-07  4:23 UTC (permalink / raw)
  To: openembedded-core

If INITRAMFS_FSTYPES contains more than one entry, ukify build command
will fail as INITRD_ARCHIVE will contain extra strings. Use only the
first initramfs type, letting the user to specify other fstypes.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
 meta/classes-recipe/uki.bbclass | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/classes-recipe/uki.bbclass b/meta/classes-recipe/uki.bbclass
index a2b1c8a82d6f..7457662f3f5e 100644
--- a/meta/classes-recipe/uki.bbclass
+++ b/meta/classes-recipe/uki.bbclass
@@ -73,7 +73,8 @@ require ../conf/image-uefi.conf
 
 INITRAMFS_IMAGE ?= "core-image-minimal-initramfs"
 
-INITRD_ARCHIVE ?= "${INITRAMFS_IMAGE}-${MACHINE}.${INITRAMFS_FSTYPES}"
+UKI_CPIO_FSTYPE ?= "${@d.getVar("INITRAMFS_FSTYPES").split()[0]}"
+INITRD_ARCHIVE ?= "${INITRAMFS_IMAGE}-${MACHINE}.${UKI_CPIO_FSTYPE}"
 
 do_image_complete[depends] += "${INITRAMFS_IMAGE}:do_image_complete"
 
-- 
2.47.3



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes
  2026-01-07  4:23 [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes Dmitry Baryshkov
@ 2026-01-19  6:46 ` Dmitry Baryshkov
  2026-01-19  9:05   ` [OE-core] " Antonin Godard
  2026-01-19 18:25 ` Paul Barker
  1 sibling, 1 reply; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-19  6:46 UTC (permalink / raw)
  To: openembedded-core

On Wed, Jan 07, 2026 at 06:23:45AM +0200, Dmitry Baryshkov wrote:
> If INITRAMFS_FSTYPES contains more than one entry, ukify build command
> will fail as INITRD_ARCHIVE will contain extra strings. Use only the
> first initramfs type, letting the user to specify other fstypes.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  meta/classes-recipe/uki.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

And gracious ping. This was sent almost two weeks ago with no feedback
to it up to now.

-- 
With best wishes
Dmitry


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [OE-core] [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes
  2026-01-19  6:46 ` Dmitry Baryshkov
@ 2026-01-19  9:05   ` Antonin Godard
  0 siblings, 0 replies; 4+ messages in thread
From: Antonin Godard @ 2026-01-19  9:05 UTC (permalink / raw)
  To: dmitry.baryshkov, openembedded-core

Hi,

On Mon Jan 19, 2026 at 7:46 AM CET, Dmitry Baryshkov via lists.openembedded.org wrote:
> On Wed, Jan 07, 2026 at 06:23:45AM +0200, Dmitry Baryshkov wrote:
>> If INITRAMFS_FSTYPES contains more than one entry, ukify build command
>> will fail as INITRD_ARCHIVE will contain extra strings. Use only the
>> first initramfs type, letting the user to specify other fstypes.
>> 
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>> ---
>>  meta/classes-recipe/uki.bbclass | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>
> And gracious ping. This was sent almost two weeks ago with no feedback
> to it up to now.

This has passed testing, but due do intermittent issues on our test
infrastructure merging patches has slowed down. Reviews should be on their way
soon hopefully.

See https://wiki.yoctoproject.org/wiki/Weekly_Status.

Regards,
Antonin

-- 
Antonin Godard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [OE-core] [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes
  2026-01-07  4:23 [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes Dmitry Baryshkov
  2026-01-19  6:46 ` Dmitry Baryshkov
@ 2026-01-19 18:25 ` Paul Barker
  1 sibling, 0 replies; 4+ messages in thread
From: Paul Barker @ 2026-01-19 18:25 UTC (permalink / raw)
  To: dmitry.baryshkov, openembedded-core

[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]

On Wed, 2026-01-07 at 06:23 +0200, Dmitry Baryshkov via
lists.openembedded.org wrote:
> If INITRAMFS_FSTYPES contains more than one entry, ukify build command
> will fail as INITRD_ARCHIVE will contain extra strings. Use only the
> first initramfs type, letting the user to specify other fstypes.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
>  meta/classes-recipe/uki.bbclass | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes-recipe/uki.bbclass b/meta/classes-recipe/uki.bbclass
> index a2b1c8a82d6f..7457662f3f5e 100644
> --- a/meta/classes-recipe/uki.bbclass
> +++ b/meta/classes-recipe/uki.bbclass
> @@ -73,7 +73,8 @@ require ../conf/image-uefi.conf
>  
>  INITRAMFS_IMAGE ?= "core-image-minimal-initramfs"
>  
> -INITRD_ARCHIVE ?= "${INITRAMFS_IMAGE}-${MACHINE}.${INITRAMFS_FSTYPES}"
> +UKI_CPIO_FSTYPE ?= "${@d.getVar("INITRAMFS_FSTYPES").split()[0]}"
> +INITRD_ARCHIVE ?= "${INITRAMFS_IMAGE}-${MACHINE}.${UKI_CPIO_FSTYPE}"

Hi Dmitry, apologies for the delays in review.

The general idea here is ok but we would like to avoid additional
dynamic calls in variable assignments where we can - each time we add
some Python code in a variable assignment it slows down recipe parsing a
little further.

In this case, INITRD_ARCHIVE is only used in the do_uki() Python
function. Can move the parsing of INITRAMFS_FSTYPES into this function?
That would mean it only executes once during the do_uki task and not
during recipe parsing.

Best regards,

-- 
Paul Barker


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 252 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-01-19 18:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-07  4:23 [PATCH] uki.bbclass: fix building of UKI images with multiple initramfs fstypes Dmitry Baryshkov
2026-01-19  6:46 ` Dmitry Baryshkov
2026-01-19  9:05   ` [OE-core] " Antonin Godard
2026-01-19 18:25 ` Paul Barker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox