public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Mathieu Dubois-Briand" <mathieu.dubois-briand@bootlin.com>
To: <joaomarcos.costa@bootlin.com>,
	<openembedded-core@lists.openembedded.org>
Cc: <thomas.petazzoni@bootlin.com>
Subject: Re: [OE-core] [PATCH] ltp: fix warning in remove_broken_musl_sources
Date: Thu, 19 Mar 2026 18:38:18 +0100	[thread overview]
Message-ID: <DH6XX5V3YO6B.2PRKV55NZP37I@bootlin.com> (raw)
In-Reply-To: <20260319132904.1308436-1-joaomarcos.costa@bootlin.com>

On Thu Mar 19, 2026 at 2:29 PM CET, Joao Marcos Costa via lists.openembedded.org wrote:
> If this was originally intended to be an actual warning, it was not
> behaving as such: echo only prints to log.do_patch, so the message ends
> up hidden there.
>
> Replace 'echo' by bbwarn to display the warning message correctly.
>
> Signed-off-by: João Marcos Costa <joaomarcos.costa@bootlin.com>
> ---

Hi João,

Thanks for your patch.

>  meta/recipes-extended/ltp/ltp_20260130.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-extended/ltp/ltp_20260130.bb b/meta/recipes-extended/ltp/ltp_20260130.bb
> index 75c5b8b7bd..36432c15b2 100644
> --- a/meta/recipes-extended/ltp/ltp_20260130.bb
> +++ b/meta/recipes-extended/ltp/ltp_20260130.bb
> @@ -126,7 +126,7 @@ remove_broken_musl_sources() {
>  	[ "${TCLIBC}" = "musl" ] || return 0
>  
>  	cd ${S}
> -	echo "WARNING: remove unsupported tests (until they're fixed)"
> +	bbwarn "remove unsupported tests (until they're fixed)"

So I believe this will add a WARNING on all musl builds, right? I'm not
sure we can really accept that.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



  reply	other threads:[~2026-03-19 17:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 13:29 [PATCH] ltp: fix warning in remove_broken_musl_sources João Marcos Costa
2026-03-19 17:38 ` Mathieu Dubois-Briand [this message]
2026-03-19 17:55   ` [OE-core] " Joao Marcos Costa
2026-03-19 18:17     ` Mathieu Dubois-Briand
2026-03-20  9:16       ` Joao Marcos Costa
2026-03-20  9:26         ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DH6XX5V3YO6B.2PRKV55NZP37I@bootlin.com \
    --to=mathieu.dubois-briand@bootlin.com \
    --cc=joaomarcos.costa@bootlin.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox