From: Joao Marcos Costa <joaomarcos.costa@bootlin.com>
To: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>,
openembedded-core@lists.openembedded.org
Cc: thomas.petazzoni@bootlin.com
Subject: Re: [OE-core] [PATCH] ltp: fix warning in remove_broken_musl_sources
Date: Fri, 20 Mar 2026 10:16:38 +0100 [thread overview]
Message-ID: <d01181ac-b115-4d87-9902-e7dd5b888341@bootlin.com> (raw)
In-Reply-To: <DH6YQYC6H8Z2.2B8KJW0XH6SI@bootlin.com>
Hello,
On 3/19/26 19:17, Mathieu Dubois-Briand wrote:
> On Thu Mar 19, 2026 at 6:55 PM CET, Joao Marcos Costa wrote:
>> Hello,
>>
>> On 3/19/26 18:38, Mathieu Dubois-Briand wrote:
>>> On Thu Mar 19, 2026 at 2:29 PM CET, Joao Marcos Costa via lists.openembedded.org wrote:
>>>> If this was originally intended to be an actual warning, it was not
>>>> behaving as such: echo only prints to log.do_patch, so the message ends
>>>> up hidden there.
>>>>
>>>> Replace 'echo' by bbwarn to display the warning message correctly.
>>>>
>>>> Signed-off-by: João Marcos Costa <joaomarcos.costa@bootlin.com>
>>>> ---
>>>
(...)>>>
>> Yep, it will. Would an INFO/NOTE be acceptable instead?
>>
>> Thanks!
>
> Yes, I believe info or note are acceptable.
>
> Thanks,
> Mathieu
I sent a v2 to fix that.
One more thing, though: this same function uses an 'rm -rfv' and the
"-f" option will not raise an error if the file is not there.
Do you think this should be addressed? I would send this in a different
patch, of course.
Thanks!
--
Best regards,
João Marcos Costa
next prev parent reply other threads:[~2026-03-20 9:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-19 13:29 [PATCH] ltp: fix warning in remove_broken_musl_sources João Marcos Costa
2026-03-19 17:38 ` [OE-core] " Mathieu Dubois-Briand
2026-03-19 17:55 ` Joao Marcos Costa
2026-03-19 18:17 ` Mathieu Dubois-Briand
2026-03-20 9:16 ` Joao Marcos Costa [this message]
2026-03-20 9:26 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d01181ac-b115-4d87-9902-e7dd5b888341@bootlin.com \
--to=joaomarcos.costa@bootlin.com \
--cc=mathieu.dubois-briand@bootlin.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox