Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include kernel property in DTBO config subnodes
@ 2026-06-21 10:11 AdrianF
  2026-06-21 10:11 ` [PATCH 1/1] oe-selftest: fitimage: Do not expect " AdrianF
  2026-06-22  8:17 ` [OE-core] [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include " Mathieu Dubois-Briand
  0 siblings, 2 replies; 3+ messages in thread
From: AdrianF @ 2026-06-21 10:11 UTC (permalink / raw)
  To: openembedded-core; +Cc: Adrian Freihofer

From: Adrian Freihofer <adrian.freihofer@siemens.com>

This patch
https://patchwork.yoctoproject.org/project/oe-core/patch/20260616220700.41516-1-marek.vasut@mailbox.org/
requires a fix in the oe-selftest.

Without this the tests fail on the autobuilder with the following error:
https://autobuilder.yoctoproject.org/valkyrie/api/v2/logs/7316435/raw_inline

@Mathieu would it be possible to pick the patches in the following order as I
tested them successfully on my WIP branch here?
https://git.openembedded.org/openembedded-core-contrib/log/?h=adrianf/fit-improvements-tests-dtbvendored

It's esentially the same as you have it on
https://git.openembedded.org/openembedded-core-contrib/log/?h=mathieu/master-next-tests
but with the patch here before the two patches from Marek.

Adrian Freihofer (1):
  oe-selftest: fitimage: Do not expect kernel property in DTBO config
    subnodes

 meta/lib/oeqa/selftest/cases/fitimage.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

-- 
2.54.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 1/1] oe-selftest: fitimage: Do not expect kernel property in DTBO config subnodes
  2026-06-21 10:11 [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include kernel property in DTBO config subnodes AdrianF
@ 2026-06-21 10:11 ` AdrianF
  2026-06-22  8:17 ` [OE-core] [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include " Mathieu Dubois-Briand
  1 sibling, 0 replies; 3+ messages in thread
From: AdrianF @ 2026-06-21 10:11 UTC (permalink / raw)
  To: openembedded-core; +Cc: Adrian Freihofer

From: Adrian Freihofer <adrian.freihofer@siemens.com>

A DTBO overlay together with only a kernel cannot form a bootable result,
so DTBO configuration subnodes should not include the kernel property.
Update _get_req_its_fields() accordingly: skip appending
'kernel = "kernel-1"' for .dtbo files, aligning it with
_get_req_sections() which already handles this correctly.

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
---
 meta/lib/oeqa/selftest/cases/fitimage.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/meta/lib/oeqa/selftest/cases/fitimage.py b/meta/lib/oeqa/selftest/cases/fitimage.py
index 23d034517f..67b03c1d9f 100644
--- a/meta/lib/oeqa/selftest/cases/fitimage.py
+++ b/meta/lib/oeqa/selftest/cases/fitimage.py
@@ -924,7 +924,9 @@ class KernelFitImageBase(FitImageTestCase):
         dtb_files, dtb_symlinks = FitImageTestCase._get_dtb_files(bb_vars)
         if dtb_files:
             for dtb in dtb_files:
-                its_field_check.append('kernel = "kernel-1";')
+                # DTBO overlay configs do not include a kernel property
+                if not dtb.endswith('.dtbo'):
+                    its_field_check.append('kernel = "kernel-1";')
                 its_field_check.append('fdt = "fdt-%s";' % dtb)
             for dtb in dtb_symlinks:
                 its_field_check.append('kernel = "kernel-1";')
-- 
2.54.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [OE-core] [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include kernel property in DTBO config subnodes
  2026-06-21 10:11 [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include kernel property in DTBO config subnodes AdrianF
  2026-06-21 10:11 ` [PATCH 1/1] oe-selftest: fitimage: Do not expect " AdrianF
@ 2026-06-22  8:17 ` Mathieu Dubois-Briand
  1 sibling, 0 replies; 3+ messages in thread
From: Mathieu Dubois-Briand @ 2026-06-22  8:17 UTC (permalink / raw)
  To: adrian.freihofer, openembedded-core

On Sun Jun 21, 2026 at 12:11 PM CEST, Adrian Freihofer via lists.openembedded.org wrote:
> From: Adrian Freihofer <adrian.freihofer@siemens.com>
>
> This patch
> https://patchwork.yoctoproject.org/project/oe-core/patch/20260616220700.41516-1-marek.vasut@mailbox.org/
> requires a fix in the oe-selftest.
>
> Without this the tests fail on the autobuilder with the following error:
> https://autobuilder.yoctoproject.org/valkyrie/api/v2/logs/7316435/raw_inline
>
> @Mathieu would it be possible to pick the patches in the following order as I
> tested them successfully on my WIP branch here?
> https://git.openembedded.org/openembedded-core-contrib/log/?h=adrianf/fit-improvements-tests-dtbvendored
>
> It's esentially the same as you have it on
> https://git.openembedded.org/openembedded-core-contrib/log/?h=mathieu/master-next-tests
> but with the patch here before the two patches from Marek.
>
> Adrian Freihofer (1):
>   oe-selftest: fitimage: Do not expect kernel property in DTBO config
>     subnodes
>
>  meta/lib/oeqa/selftest/cases/fitimage.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

I confirm this this now working, it should be in my
mathieu/master-next-success branch in the coming hours.

Thanks,
Mathieu

-- 
Mathieu Dubois-Briand, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-06-22  8:17 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-06-21 10:11 [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include kernel property in DTBO config subnodes AdrianF
2026-06-21 10:11 ` [PATCH 1/1] oe-selftest: fitimage: Do not expect " AdrianF
2026-06-22  8:17 ` [OE-core] [PATCH 0/1] fix tests for kernel-fit-image.bbclass: Do not include " Mathieu Dubois-Briand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox